Skip to content

[C-5273] Add user select to comment text#10201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raymondjacobson merged 1 commit into from
Oct 25, 2024
Merged

[C-5273] Add user select to comment text #10201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/web/src/components/comments/CommentText.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,11 @@ export const CommentText = (props: CommentTextProps) => {
mentions={mentions}
internalLinksOnly
maxLines={isExpanded ? undefined : 3}
css={{ textAlign: 'left', wordBreak: 'break-word' }}
css={{
textAlign: 'left',
wordBreak: 'break-word',
userSelect: 'text'
}}
suffix={
isEdited ? <Text color='subdued'> ({messages.edited})</Text> : null
}
Expand Down
10 changes: 9 additions & 1 deletion packages/web/src/components/user-generated-text/UserGeneratedTextV2.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -313,7 +313,15 @@ export const UserGeneratedTextV2 = forwardRef(function (

return (
<Text
style={{ whiteSpace: 'pre-wrap' }}
style={{
whiteSpace: 'pre-wrap'
}}
css={{
'&::selection': {
backgroundColor: '#a116b7',

@rickyromborickyromboOct 25, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no constant for this?

@DejayJDDejayJDOct 25, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 should be able to pull this from somewhere? Either harmony theme or css var?

@raymondjacobsonraymondjacobsonOct 25, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't - this is actually an "out of band" color, but it's one we use elsewhere. do you want me to add to harmony?

@raymondjacobsonraymondjacobsonOct 25, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me merge this and ill start a harmony thread

@DejayJDDejayJDOct 25, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea on board with that

color: 'var(--harmony-white)'
}
}}
ref={ref as ForwardedRef<'p'>}
{...other}
>
Expand Down