Uh oh!
There was an error while loading. Please reload this page.
[C-5279] Exclude users from comments who are muted by the artist - #10238
Merged
Conversation
|
dylanjeffers
approved these changes
Oct 25, 2024
| MutedUser.muted_user_id == Comment.user_id, | ||
| or_( | ||
| MutedUser.user_id == current_user_id, | ||
| MutedUser.user_id == artist_id, |
| MutedUser.muted_user_id == Comment.user_id, | ||
| or_( | ||
| MutedUser.user_id == current_user_id, | ||
| MutedUser.user_id == artist_id, |
isaacsolo
approved these changes
Oct 25, 2024
isaacsolo
left a comment
There was a problem hiding this comment.
query is good but i think we still need to update notifications
raymondjacobson
commented
Oct 25, 2024
MemberAuthor
Ah gotcha... that makes sense |
raymondjacobson added a commit
that referenced
this pull request
Oct 26, 2024
audius-infra pushed a commit
that referenced
this pull request
Oct 28, 2024
[2ab68ed] [C-5310] Fix comment notification deep links (#10240) Dylan Jeffers [03c3823] [PAY-3552] Finish UDR report and fix bugs (#10186) Raymond Jacobson [1c91f85] Add X-Forwarded-Proto to nginx config to fix resolve endpoint (#10239) Marcus Pasell [c536d3e] [C-5279] Exclude users from comments who are muted by the artist (#10238) Raymond Jacobson [a6dd2b7] [C-5292] Add comment reaction notification setting (#10220) Dylan Jeffers [673ffaf] Add more comment validations (#10189) Isaac Solo
samgutentag pushed a commit
that referenced
this pull request
Nov 1, 2024
samgutentag pushed a commit
that referenced
this pull request
Nov 1, 2024
[2ab68ed] [C-5310] Fix comment notification deep links (#10240) Dylan Jeffers [03c3823] [PAY-3552] Finish UDR report and fix bugs (#10186) Raymond Jacobson [1c91f85] Add X-Forwarded-Proto to nginx config to fix resolve endpoint (#10239) Marcus Pasell [c536d3e] [C-5279] Exclude users from comments who are muted by the artist (#10238) Raymond Jacobson [a6dd2b7] [C-5292] Add comment reaction notification setting (#10220) Dylan Jeffers [673ffaf] Add more comment validations (#10189) Isaac Solo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replacement PR for #10223
It was simpler than we thought + adding more tests
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.