Uh oh!
There was an error while loading. Please reload this page.
Fix validations for unreact comment - #10246
Merged
Merged
Conversation
|
DejayJD
approved these changes
Oct 28, 2024
DejayJD
left a comment
Contributor
There was a problem hiding this comment.
This makes sense to me, but I'm curious how we're getting into that state? 🤔
isaacsolo
commented
Oct 28, 2024
Author
yeaa i couldn't repro but there's probably some edge case |
audius-infra pushed a commit
that referenced
this pull request
Oct 29, 2024
[d49bb52] Add more guards to the migration for idempotency (#10259) Marcus Pasell [263569e] Include specifiers for Audio Match in migration (#10258) Marcus Pasell [7a5772e] Don't rollback the migration (#10256) Marcus Pasell [e9c3e94] [C-5310] Fix comment notifications with explicit type (#10242) Dylan Jeffers [737bec0] Fix validations for unreact comment (#10246) Isaac Solo [a2803dd] [PAY-3469] Reapply "Update DN to use shortened rewards challenge IDs and specifiers (#9803)" (#10099) (#10158) Marcus Pasell [f5e01e0] Revert "Add X-Forwarded-Proto to nginx config to fix resolve endpoint (#10239)" (#10251) Marcus Pasell [0d445df] Use msgpack between servers. (#10244) Steve Perkins
schottra added a commit
that referenced
this pull request
Oct 29, 2024
* origin/main: (78 commits) Remove SEARCH_V2 feature flag (#10264) Fix eth-bridge, consolidate Makefile, remove cruft (#10212) [C-5309] Reset comment form text on location change (#10263) [PAY-3516] Remove is_stream_gated and is_download_gated (#10146) [PAY-3545] Add cover attribution and song ownership to track upload (#10184) Audius Protocol v0.7.22 Add more guards to the migration for idempotency (#10259) Include specifiers for Audio Match in migration (#10258) Don't rollback the migration (#10256) [C-5314] Add load states for comment display names & avatars (#10255) [C-5310] Fix comment notifications with explicit type (#10242) Fix mobile harmony button xs size (#10243) Bump max audio size to 500mb (#10252) Upgrade mobile version to 1.1.121 (#10254) Fix validations for unreact comment (#10246) [PAY-3469] Reapply "Update DN to use shortened rewards challenge IDs and specifiers (#9803)" (#10099) (#10158) Fix purchases with external wallet and wallet adapter (#10087) Make Text component respect theme typography (#10086) Revert "Add X-Forwarded-Proto to nginx config to fix resolve endpoint (#10239)" (#10251) Not hardcoded file limit error message (#10247) ...
samgutentag pushed a commit
that referenced
this pull request
Nov 1, 2024
samgutentag pushed a commit
that referenced
this pull request
Nov 1, 2024
[d49bb52] Add more guards to the migration for idempotency (#10259) Marcus Pasell [263569e] Include specifiers for Audio Match in migration (#10258) Marcus Pasell [7a5772e] Don't rollback the migration (#10256) Marcus Pasell [e9c3e94] [C-5310] Fix comment notifications with explicit type (#10242) Dylan Jeffers [737bec0] Fix validations for unreact comment (#10246) Isaac Solo [a2803dd] [PAY-3469] Reapply "Update DN to use shortened rewards challenge IDs and specifiers (#9803)" (#10099) (#10158) Marcus Pasell [f5e01e0] Revert "Add X-Forwarded-Proto to nginx config to fix resolve endpoint (#10239)" (#10251) Marcus Pasell [0d445df] Use msgpack between servers. (#10244) Steve Perkins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Seeing some skipped transactions because of an error where the existing comment reaction doesn't exist when un-reacting. This modification ignores those txs instead of triggering a skip.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Modified existing invalid test case.