Skip to content

Allow user lookup for guest accounts - #10442

Merged
isaacsolo merged 1 commit into
mainfrom
is-guest-wallet-lookup
Nov 14, 2024
Merged

Allow user lookup for guest accounts#10442
isaacsolo merged 1 commit into
mainfrom
is-guest-wallet-lookup

Conversation

@isaacsolo

@isaacsoloisaacsolo commented Nov 14, 2024

Copy link
Copy Markdown

Description

Some users don't have handles yet. They might not have finished sign up flow or they are in a guest account state.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Tested in sandbox and user without handle works.

@changeset-bot

changeset-botBot commented Nov 14, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: bca2aec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

schottra
schottra approved these changes Nov 14, 2024
View reviewed changes

@schottraschottra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think generally okay, but I would triple check sign-in and sign up flows to make sure this doesn't break the sagas involved.

Comment threadpackages/discovery-provider/src/queries/get_users_account.py
@isaacsolo
isaacsolo merged commit 3bcf561 into mainNov 14, 2024
@isaacsolo
isaacsolo deleted the is-guest-wallet-lookup branch November 14, 2024 20:06
audius-infra pushed a commit that referenced this pull request Nov 15, 2024
audius-infra
Audius Protocol v0.7.35
2c78107
[6af8381] [QA-1824] Don't filter own playlists in collection library queries (#10444) Randy Schott
[9c0ff86] [C-5399] Add saga and basic setup for track audio replace (#10437) Kyle Shanks
[3bcf561] Allow user lookup for guest accounts (#10442) Isaac Solo
[bc14034] Update DiscoverProvider to handle replacing track audio (#10436) Kyle Shanks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DejayJDDejayJDAwaiting requested review from DejayJD
1 more reviewer
@schottraschottraschottra approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@isaacsolo@schottra