Skip to content

[PAY-3614] Add entity manager support for emails - #10521

Merged
faridsalau merged 4 commits into
mainfrom
farid/emails-entity
Nov 26, 2024
Merged

[PAY-3614] Add entity manager support for emails#10521
faridsalau merged 4 commits into
mainfrom
farid/emails-entity

Conversation

@faridsalau

@faridsalaufaridsalau commented Nov 25, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR adds entity manager support for uploading emails.

It does not handle the encryption of the emails, that will be done in a follow up PR.

How Has This Been Tested?

Locally by running the below code in ProfilePage.tsx and checking the local db for the content

constuserId=useGetCurrentUserId({})useEffect(()=>{asyncfunctionaddEmail(){constsdk=awaitaudiusSdk()console.log('calling addEmail')try{awaitsdk.users.addEmail({emailOwnerUserId: 1234,primaryUserId: userId.data??0,encryptedEmail: 'encryptedEmail',encryptedKey: 'encryptedKey'})console.log('addEmail succesful')}catch(error){console.error('Error adding email:',error)}}if(userId.data){addEmail()}},[userId])

@changeset-bot

changeset-botBot commented Nov 25, 2024•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d4d9bcc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

raymondjacobson
raymondjacobson approved these changes Nov 25, 2024
View reviewed changes

@raymondjacobsonraymondjacobson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice this looks super solid!

Comment threadpackages/discovery-provider/src/tasks/entity_manager/entities/email.py Outdated
Comment threadpackages/discovery-provider/src/tasks/entity_manager/entities/email.py Outdated
Comment threadpackages/discovery-provider/src/tasks/entity_manager/entities/email.py
Validates delegated access data
Raises IndexingValidationError if validation fails
"""
if len(delegated_user_ids) != len(delegated_keys):

@raymondjacobsonraymondjacobsonNov 25, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to add any check here to validate who the delegated access is to?

@faridsalaufaridsalauNov 25, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like to see if they exist?

@raymondjacobsonraymondjacobsonNov 25, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah... maybe we don't care, just a thought

raymondjacobson
raymondjacobson reviewed Nov 25, 2024
View reviewed changes
Comment threadpackages/sdk/src/sdk/api/users/UsersApi.ts
raymondjacobson
raymondjacobson approved these changes Nov 26, 2024
View reviewed changes
Comment threadpackages/discovery-provider/src/tasks/entity_manager/entities/email.py
)
if params.action not in [Action.ADD_EMAIL, Action.UPDATE_EMAIL]:
raise IndexingValidationError(
"email.py | Expected action to be AddEmail or UpdateEmail"

@raymondjacobsonraymondjacobsonNov 26, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we typically include this filename in a log msg, but i dont think it makes sense for error copy

also our structured logging adds that now anyway, so it's not really necessary in logs too. https://github.com/AudiusProject/audius-protocol/blob/ab5c06b879800120a9479b7155536b703bb562dc/packages/discovery-provider/src/utils/structured_logger.py#L85

@faridsalau
faridsalau merged commit d32ca5e into mainNov 26, 2024
@faridsalau
faridsalau deleted the farid/emails-entity branch November 26, 2024 18:52
schottra added a commit that referenced this pull request Nov 26, 2024
@schottra
Merge remote-tracking branch 'origin/main' intopay-3579-migrate-signup
6f60be1
* origin/main:
[QA-1544] Fix UI jitter (#10515)
rm logs and run indexer once every 3 seconds (#10536)
[PAY-3614] Add entity manager support for emails (#10521)
Handle duplicate comment thread records (#10535)
Remove hello world (#10532)
audius-infra pushed a commit that referenced this pull request Nov 27, 2024
audius-infra
Audius Protocol v0.7.43
ebb7df1
[e498a37] [PROTO-1989] Rudimentary core health check, fix rollup page bug (#10542) Danny
[3f8ae11] Add proper reporting in EUR to relevant territories (#10530) Raymond Jacobson
[458afb0] [TRIVIAL] Add underscores and rename (#10538) Farid Salau
[f708b1e] rm logs and run indexer once every 3 seconds (#10536) alecsavvy
[d32ca5e] [PAY-3614] Add entity manager support for emails (#10521) Farid Salau
[01cc92c] Handle duplicate comment thread records (#10535) Isaac Solo
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondjacobsonraymondjacobsonraymondjacobson approved these changes

Assignees

No one assigned

Labels

size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@faridsalau@raymondjacobson