Uh oh!
There was an error while loading. Please reload this page.
[PAY-3608] Use sdk auth service in AudiusBackend - #10529
Merged
Merged
Conversation
|
audius-infra
commented
Nov 26, 2024
Collaborator
Preview this change https://demo.audius.co/rt-sign |
raymondjacobson
approved these changes
Nov 26, 2024
raymondjacobson
left a comment
Member
There was a problem hiding this comment.
we can test an app on staging to cover that case, but the flow would be to be to hit oauth on your localhost like this:
audius-infra pushed a commit
that referenced
this pull request
Nov 30, 2024
[c14f623] [PAY-3591] Use direct images for use profile pictures and cover photos (#10546) Raymond Jacobson [623fcfb] [C-5388] Add guest checkout page to purchase modal (#10544) Isaac Solo [23d922b] [PAY-3608] Use sdk auth service in AudiusBackend (#10529) Reed [310c969] [C-5443, C-5444] Web track replace fixes (#10534) Kyle Shanks [265a8c3] [QA-1544] Fix UI jitter (#10515) Dylan Jeffers [ab5c06b] Remove hello world (#10532) Raymond Jacobson [a566460] Improve coinbase pay loading (#10517) Dylan Jeffers [fe6091a] [C-5439] Add theme v2 component changes (#10518) Dylan Jeffers [32018fa] [PAY-3590] Use collection artwork property for playlist/album images (#10503) Raymond Jacobson [426fa27] [PAY-3613] Migrate explore playlists to sdk (#10520) Reed [e00a7f0] Fix broken landing page (#10527) Raymond Jacobson [7028749] [C-5437] Fix previews for edit track form (#10526) Kyle Shanks [92048a9] [C-5442] Add mobile replace track confirmation drawer (#10524) Kyle Shanks [ac0e53b] Fix harmony circular dependency (#10525) Andrew Mendelsohn [fb6da94] Fix something went wrong toast when not logged in (#10508) Isaac Solo [54908ca] [QA-1831][QA-1817][QA-845][QA-1854] Fix misc mobile UI/layout issues (#10513) Raymond Jacobson [b2b69dc] [C-5436] Fix-replace-progress-modal-progress (#10522) Kyle Shanks [e75a220] [C-5406, C-5407] Add file replace to track edit flow (#10510) Kyle Shanks [73362a5] Update RC icons (#10402) Dylan Jeffers [6d8e33f] [C-5017] Add harmony theme v2 (#10506) Dylan Jeffers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use sdk auth service in AudiusBackend instead of libs Web3Manager.
Seems like we might want to wrap the logic in
signDatainside sdk instead of forcing user to manage manually?Thanks to @schottra for figuring out the logic so I could copy it from audius-cmd.
How Has This Been Tested?