Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 134
[PAY-3579] Migrate signup to SDK#10539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
839f6e76f82ac88fb1799d30de0dc288c886f60be15d59e6ac0a26d4fb64d178c05acac90f5c77f6cd3bbc7f0c5939a470dd3dd03b15e391b8889153db019dFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| export const AUDIUS_ACCOUNT_KEY = '@audius/account' | ||
| export const AUDIUS_ACCOUNT_USER_KEY = '@audius/audius-user' | ||
| export const AUDIUS_USER_WALLET_OVERRIDE_KEY = '@audius/user-wallet-override' | ||
| export const IS_MOBILE_USER_KEY = 'is-mobile-user' |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| export * from './LocalStorage' | ||
| export * from './constants' |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feels dangerous to have this inferred on web and from env vars on mobile. maybe it can always be from env vars and we don't need something in app context for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tend to agree, but I'm not sure why it was split in the first place. I just wanted to preserve the logic in case it was meant to handle a specific edge case.
I'll investigate a little more and/or make a ticket to remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I think it's because you can run client from so many different URLs (such as hosted subdomains) that the env variables wouldn't be guaranteed correct, and thus signup wouldn't work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah that's fair.... but i guess mobile has no elegant solve to this