Uh oh!
There was an error while loading. Please reload this page.
Migrate @audius/commands to SDK and Typescript - #10606
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 3249666 | Triggered | Generic Password | a1c7aac | packages/commands/src/utils.ts | View secret |
| 3249666 | Triggered | Generic Password | a1c7aac | packages/commands/src/utils.mjs | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
| throw new Error(`Failed to parse track "${track}"`) | ||
| } | ||
| const parsedStreamConditions = await getStreamConditions({ |
| const { trackId } = await audiusSdk.tracks.uploadTrack({ | ||
| userId, | ||
| coverArtFile: { buffer: createRandomImage(), name: 'coverart' }, | ||
| trackFile: { buffer: await readStreamToBuffer(trackStream) }, |
There was a problem hiding this comment.
we lost support for passing in the ReadStream directly unfortunately :(
There was a problem hiding this comment.
we could probably add it back if we want!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
dharit-tan
left a comment
There was a problem hiding this comment.
ugh so clean... so short... so simple
i didn't read everything super thoroughly but lgtm and it's not external-facing
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| const { trackId } = await audiusSdk.tracks.uploadTrack({ | ||
| userId, | ||
| coverArtFile: { buffer: createRandomImage(), name: 'coverart' }, | ||
| trackFile: { buffer: await readStreamToBuffer(trackStream) }, |
There was a problem hiding this comment.
we could probably add it back if we want!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
@audius/commandsto Typescript@audius/commandsto SDK@audius/commandsinto folders by entity@audius/commandsto be in the formaudius-cmd <entity> <verb>TODO: