Skip to content

Move trending plugin to sdk - #10649

Merged
raymondjacobson merged 7 commits into
mainfrom
rj-trending-fix
Dec 11, 2024
Merged

Move trending plugin to sdk#10649
raymondjacobson merged 7 commits into
mainfrom
rj-trending-fix

Conversation

@raymondjacobson

@raymondjacobsonraymondjacobson commented Dec 7, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Description

Move trending rewards plugin to sdk and make operation a bit more simple.
Add README.

Note: when this ships, it will require updates to the .env vars.

Note2: I unfortunately had to leave axios in there to make the undisbursed call. Even without gzip, node-fetch seems to not be able to handle large response sizes. I believe the issue is upstream in the flask/nginx/caddy/cloudflare world...

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Locally claimed 2024-12-06:* specifiers for tut, tt, and tp

+------------------------------------------+
| Challenge Disbursements |
+-----------+------------------+-----------+
| Challenge | Handle | Slot |
+-----------+------------------+-----------+
| tp | MisterStrawberry | 306064989 |
| tp | ProdbyMiracle | 306064949 |
| tp | chakrarecords | 306079246 |
| tp | chakrarecords | 306064900 |
| tp | _monkemusic | 306079254 |
| tt | chakrarecords | 306064914 |
| tt | cooprecsmusic | 306077907 |
| tt | mjcole | 306064939 |
| tt | headroom_records | 306064977 |
| tt | amouse.dj | 306077916 |
| tut | Bauti | 306064927 |
| tut | froootmusic | 306064964 |
| tut | svmmxns | 306065000 |
| tut | SoundMuseum | 306078691 |
| tut | IsaiahBrownMusic | 306078723 |
+-----------+------------------+-----------+

@changeset-bot

changeset-botBot commented Dec 7, 2024•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 874ed4d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

schottra
schottra approved these changes Dec 9, 2024
View reviewed changes
Comment threadpackages/discovery-provider/plugins/pedalboard/apps/trending-challenge-rewards/package.json
},
"dependencies": {
"@audius/sdk": "*",
"@audius/sdk-legacy": "*",

@schottraschottraDec 9, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Comment threadpackages/discovery-provider/plugins/pedalboard/apps/trending-challenge-rewards/src/config.ts Outdated
Comment threadpackages/discovery-provider/plugins/pedalboard/apps/trending-challenge-rewards/src/main.ts Outdated
Comment threadpackages/discovery-provider/plugins/pedalboard/apps/trending-challenge-rewards/src/rewards.ts Outdated
Comment threadpackages/discovery-provider/plugins/pedalboard/apps/trending-challenge-rewards/src/rewards.ts Outdated
Comment threadpackages/discovery-provider/plugins/pedalboard/apps/trending-challenge-rewards/src/rewards.ts Outdated
Comment threadpackages/discovery-provider/plugins/pedalboard/apps/trending-challenge-rewards/src/rewards.ts Outdated
Comment threadpackages/discovery-provider/plugins/pedalboard/apps/trending-challenge-rewards/src/rewards.ts Outdated
Comment threadpackages/discovery-provider/plugins/pedalboard/apps/trending-challenge-rewards/src/rewards.ts Outdated
return new Err(`completed block number is null ${firstChallenge}`)
const specifier = firstChallenge.specifier
// why we subtract one
// https://www.notion.so/audiusproject/Manually-Complete-Rewards-Challenge-Manually-disburse-trending-24daed058dc54e4a8adb4912814481f2?pvs=4#1ced75c9c41740ce8facd19bf0d46720

@schottraschottraDec 9, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: would prefer we just put a shortened version of whatever text is on the other end of that link here.

@raymondjacobsonraymondjacobsonDec 9, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't even be checked in, but also not my code 😓

Comment threadpackages/discovery-provider/plugins/pedalboard/apps/trending-challenge-rewards/src/sdk.ts Outdated
@raymondjacobson
raymondjacobson enabled auto-merge (squash) December 11, 2024 23:24
@raymondjacobson
raymondjacobson merged commit aa2a940 into mainDec 11, 2024
@raymondjacobson
raymondjacobson deleted the rj-trending-fix branch December 11, 2024 23:35
audius-infra pushed a commit that referenced this pull request Dec 12, 2024
audius-infra
Audius Protocol v0.7.54
b859dfb
[73426e8] fix go linter (#10691) alecsavvy
[aa2a940] Move trending plugin to sdk (#10649) Raymond Jacobson
[9e54e0d] add redis volume to audius-d (#10689) alecsavvy
[45a744a] [QA-1875] Clear badge count on `notification_seen` row add (#10688) Andrew Mendelsohn
[8eb871d] Fix discovery tests (#10686) Raymond Jacobson
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickyromborickyromboAwaiting requested review from rickyrombo
2 more reviewers
@schottraschottraschottra approved these changes
@alecsavvyalecsavvyalecsavvy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@raymondjacobson@schottra@alecsavvy