[PAY-3647] Migrate getTokenAccount, createUserBankIfNeeded to sdk by dharit-tan · Pull Request #10662 · AudiusProject/apps

dharit-tan · 2024-12-10T09:08:57Z

Description

Convert various functions to sdk like getTokenAccount, createUserBankIfNeeded

How Has This Been Tested?

Tested locally on web stage:

USDC balance
withdraw USDC
wAUDIO balance
Send wAUDIO
tip flow
sign up with new user - create user bank flow

changeset-bot · 2024-12-10T09:09:01Z

⚠️ No Changeset found

Latest commit: b0bc84f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

schottra

Looks good, just a couple of suggestions.

schottra · 2024-12-10T15:27:00Z

 type CreateUserBankIfNeededSuccessResult = {
 didExist: boolean
-userbank: PublicKey
+userBank: PublicKey


why the change in casing? I am concerned that we have JS code somewhere using these functions that might have gotten missed and will start failing because the property name changed.
I assume it's to match the property in the User model?

claimableTokensClient uses this casing 😭 i will check for js callsites

oh and we return res.userBank at the bottom of createUserBankIfNeeded so all good!

rickyrombo

LGTM

[8334ed0] [C-5508, C-5510, C-5511] Track Replace QA 2 (#10719) Kyle Shanks [c3617c1] Remove a few miscellaneous libs references (#10715) Randy Schott [3ff1c0e] [C-5524] Sync account details when guest account is created (#10709) Isaac Solo [0609c40] [QA-1864][PAY-3690] Migrate searchTags to SDK (#10706) Randy Schott [b8b3cac] [c-5523] Update inverse color, fix segmented control (#10710) Dylan Jeffers [b2b8eb7] [PAY-3675] Fix issues with scheduled releases (#10711) Sebastian Klingler [5f58ad2] [C-5509] Fix track title reset on replace track edit (#10708) Kyle Shanks [8c4ea49] Misc client analytics tweaks (#10704) JD Francis [cbcb93d] [PAY-3622] Update encryption patterns and add manager delegation (#10690) Farid Salau [e1fe442] [C-5519, C-5521] Add guest mode UI in claim rewards email (#10697) Dylan Jeffers [b0ac142] [PAY-3692] [PAY-3650] Use generate_preview endpoint to improve editing of track previews (#10703) Sebastian Klingler [7c654dc] [C-5505] Fix default track field visibility (#10702) Kyle Shanks [bd0c8ea] Feature flag fast referral signup (#10701) Dylan Jeffers [849bd9e] [C-5503, C-5506] Prevent the user from closing the mobile track replace progress drawer (#10700) Kyle Shanks [22e6fc2] [C-5466] Enable pay with anything and changing guest email (#10695) Isaac Solo [9fcea2c] [PAY-3687] Fix updateCreator wallets issue (#10692) Raymond Jacobson [dfc955d] Make getKeypair async since hedgehog init is async (#10698) Randy Schott [5753021] Fix premium modal footer for signed in users (#10694) Isaac Solo [b9870c4] Refactor profile progress to ts (#10664) Dylan Jeffers [ada3972] [C-5492] Guest sign-up copy and improvements (#10682) Dylan Jeffers [68c830a] [C-5441] Handle sign on redirects (#10683) Dylan Jeffers [2eff7e0] [PAY-3689] Migrate getRootSolanaAccount to an injected common service (#10685) Randy Schott [b12e135] [PAY-2937] Migrate remaining Identity off libs (#10684) Randy Schott [79806b4] Fix mobile lint (#10687) Reed [146ffef] [PAY-3688] Migrate buy-audio to sdk (#10680) Reed [9dafdb2] Fix syncing of guest accounts upon profile completion (#10673) Isaac Solo [015457a] Remove one-to-many-dms feature flag (#10671) Dylan Jeffers [4c89718] [PAY-3645] Cleanup identity and migrate some libs usage (#10670) Randy Schott [16743bb] Pass in ethWallet to decorateCoinflowWithdrawalTransaction (#10676) Reed [18b2d64] Fix connected wallet wAUDIO balance fetching (#10675) Reed [81a4284] [PAY-3649] Fix something went wrong on transactions page (#10679) Andrew Mendelsohn [b13e2a4] Fix buy button width (#10674) Raymond Jacobson [a92a0e6] Fix sentry mobile scope issue (#10672) Raymond Jacobson [cbd8023] Update theme-v2 matrix colors (#10669) Dylan Jeffers [4fad72d] [C-5464] Track Replace QA 1 (#10668) Kyle Shanks [b61b37f] Migrate native TextButton to PlainButton and Divider to harmony (#10666) Dylan Jeffers [4a39102] [C-5479] Add error states for track replace progress (#10656) Kyle Shanks [f28f80f] Revert "[PAY-3643] Improve feed performance (#10661)" (#10667) Raymond Jacobson [dd86ac4] [PAY-3647] Migrate getTokenAccount, createUserBankIfNeeded to sdk (#10662) Reed [dbe38e5] [C-5488] Add hit slop to vanity metrics (#10665) Dylan Jeffers [e79c926] [C-5456] Migrate guest checkout user creation to SDK (#10630) Isaac Solo [1a99df3] Migrate `getAddressWAudioBalance` to sdk (#10654) Reed [6f40973] [PAY-3641] Migrate sendWAudioTokens to sdk (#10652) Reed [09f2da9] [PAY-3643] Improve feed performance (#10661) Raymond Jacobson [6226f09] Sign Up Hardening 2.5 (#10659) JD Francis [bd2309f] C 5473 guest mode UI (#10663) Dylan Jeffers [2233145] [PAY-3637] Add sentry RN perf monitoring (#10621) Farid Salau [2c88017] [PAY-3640] Convert getAssociatedTokenAccountInfo to sdk (#10651) Reed [d4aba7b] [PAY-3632] Migrate socials code off of libs (#10657) Randy Schott [88cdd53] Sign up hardening round 2 (#10643) JD Francis [abed2fe] [C-5481] Mobile harmony-theme-v2 QA (#10653) Dylan Jeffers [7b81b57] Update harmony v2 colors (#10637) Dylan Jeffers [3062618] [PAY-3621] Add email capture after successful purchase (#10577) Farid Salau [976d53c] [C-5455] Add mobile guest checkout sign up (#10607) Dylan Jeffers [353040a] Revert "Downgrade mobile apps to 1.1.128" Dylan Jeffers [0471175] Misc libs cleanup (#10634) Raymond Jacobson [8630e5b] Downgrade mobile apps to 1.1.128 Dylan Jeffers

dharit-tan added 19 commits December 9, 2024 17:07

Convert Transfer wAUDIO to sdk
747855b

dup fns
1ac9e49

lint
0a02bb0

[PAY-3641] Migrate sendWAudioTokens to sdk
c293570

wip
5bfbe20

sdk in WalletClient
dc724b7

sdk in WalletClient
f7575e3

sdk in WalletClient
1cc297b

sdk in WalletClient
3a31920

more sdk cleanup
3341cf8

fix
9f71a68

Merge branch 'rt-send-waudio' into rt-send-waudio-forreal
cf7370c

fixed using BigInt
0bde88d

use fixedDecimal
fd91ea4

use value directly
ae2d9c5

lint
2e6cf11

lint
916c160

lint
e40059c

Various solana sdk migrations
a21cbff

dharit-tan requested review from raymondjacobson and schottra December 10, 2024 09:08

pull-request-sizeBot added the size/L label Dec 10, 2024

dharit-tan requested a review from rickyrombo December 10, 2024 09:10

more
b5e1f04

pull-request-sizeBot added size/XL and removed size/L labels Dec 10, 2024

dharit-tan added 3 commits December 10, 2024 17:02

more calls
fdfac87

lint
9310ef4

lint
d242b35

lint
60676cf

schottra approved these changes Dec 10, 2024
View reviewed changes

dharit-tan added 6 commits December 10, 2024 23:20

always select current user wallet
741c5f9

sdk from audius-query context
d5ba9ca

make ethWallet arg required in createUserBankIfNeeded
44eba2b

!!adapter not needed
f681743

lint
05b8fd5

lint
2aa3f58

dharit-tan removed the request for review from raymondjacobson December 10, 2024 17:33

dharit-tan changed the title ~~Various solana sdk migrations~~[PAY-3647] Migrate getTokenAccount, createUserBankIfNeeded to sdkDec 10, 2024

rickyrombo approved these changes Dec 10, 2024
View reviewed changes

Base automatically changed from rt-send-waudio-forreal to mainDecember 10, 2024 17:45

dharit-tan added 2 commits December 11, 2024 00:49

merge commit
dd9fb8c

lint
b0bc84f

dharit-tan merged commit dd86ac4 into mainDec 10, 2024

dharit-tan deleted the rt-sdk-solana branch December 10, 2024 18:21

dharit-tan mentioned this pull request Dec 11, 2024
Pass in ethWallet to decorateCoinflowWithdrawalTransaction #10676
Merged

Navigation Menu

Uh oh!

[PAY-3647] Migrate getTokenAccount, createUserBankIfNeeded to sdk - #10662

[PAY-3647] Migrate getTokenAccount, createUserBankIfNeeded to sdk#10662
dharit-tan merged 32 commits into
mainfrom
rt-sdk-solana

dharit-tan commented Dec 10, 2024•
edited
Loading

Uh oh!

changeset-botBot commented Dec 10, 2024•
edited
Loading

Uh oh!

schottra left a comment

Uh oh!

Uh oh!

schottraDec 10, 2024

Uh oh!

dharit-tanDec 10, 2024

Uh oh!

dharit-tanDec 10, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rickyrombo left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

dharit-tan commented Dec 10, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Uh oh!

changeset-botBot commented Dec 10, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

schottra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

schottraDec 10, 2024

Choose a reason for hiding this comment

Uh oh!

dharit-tanDec 10, 2024

Choose a reason for hiding this comment

Uh oh!

dharit-tanDec 10, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rickyrombo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dharit-tan commented Dec 10, 2024•
edited
Loading

changeset-botBot commented Dec 10, 2024•
edited
Loading