Skip to content

More trending improvements - #10724

Merged
raymondjacobson merged 4 commits into
mainfrom
rj-more-trending-improvements
Dec 15, 2024
Merged

More trending improvements#10724
raymondjacobson merged 4 commits into
mainfrom
rj-more-trending-improvements

Conversation

@raymondjacobson

@raymondjacobsonraymondjacobson commented Dec 14, 2024

Copy link
Copy Markdown
Member

Description

  • Spawn trending job from index_nethermind rather than kicking off another celery task
  • More retries in attestation plugin
  • Use challenge id to filter rather than starting block

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

  • Deployed some changes to a live discovery node to test indexing + endpoint
  • Ran and attested to rewards locally using plugin

@changeset-bot

changeset-botBot commented Dec 14, 2024•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: dc28578

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

alecsavvy
alecsavvy reviewed Dec 14, 2024
View reviewed changes
Comment threadpackages/discovery-provider/plugins/pedalboard/apps/trending-challenge-rewards/package.json
Comment on lines 28 to 32
"knex": "^2.4.2",
"moment": "^2.29.4",
"morgan": "^1.10.0",
"node-cron": "^3.0.3",
"ts-results": "^3.3.0"

@alecsavvyalecsavvyDec 14, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lot of these are probably me but can we pin?

@raymondjacobsonraymondjacobsonDec 14, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure thing

@raymondjacobsonraymondjacobsonDec 14, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried pinning and... some stuff broke. I think probably a later problem...

alecsavvy
alecsavvy approved these changes Dec 14, 2024
View reviewed changes

@alecsavvyalecsavvy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@raymondjacobson
raymondjacobson merged commit 33bdd26 into mainDec 15, 2024
@raymondjacobson
raymondjacobson deleted the rj-more-trending-improvements branch December 15, 2024 19:02
audius-infra pushed a commit that referenced this pull request Dec 16, 2024
audius-infra
Audius Protocol v0.7.56
d54a65a
[33bdd26] More trending improvements (#10724) Raymond Jacobson
[e98523a] Remove duplicate validator updates (#10725) Danny
[d128ade] Bump stage to testnet-10 (#10723) Danny
[cf8a19a] Bump stage core version (#10722) Danny
[61fbe90] Make audiusd ci build faster (#10721) Danny
[6998abb] rm long migration (#10717) alecsavvy
[51c3cbb] More CI fixes for audiusd (#10716) Danny
[5c81eb8] Fix audiusd ci (#10714) Danny
[3ff1c0e] [C-5524] Sync account details when guest account is created (#10709) Isaac Solo
[7c2d816] Add searchTags SDK support (#10705) Randy Schott
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@alecsavvyalecsavvyalecsavvy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@raymondjacobson@alecsavvy