Uh oh!
There was an error while loading. Please reload this page.
[C-5572] Add cache syncing between redux and react-query - #10833
Merged
Conversation
|
dylanjeffers
requested review from
a team and sliptype
and removed request for
a teamDecember 23, 2024 20:13
sliptype
approved these changes
Dec 23, 2024
| /** | ||
| * Signals to add an entry to the cache. | ||
| * Signals to add an enty to the cache. |
| replace?: boolean | ||
| // persist optionally persists the cache entry to indexdb | ||
| persist?: boolean | ||
| source?: 'react-query' | 'redux' |
| ) | ||
| } | ||
| }, | ||
| [Kind.COLLECTIONS]: { |
Contributor
There was a problem hiding this comment.
Collections doesn't need updateRelations?
ContributorAuthor
There was a problem hiding this comment.
so this is just needed when an entity may be in another entity, which isn't the case for collections.
| ) : null} | ||
| {!IS_PRODUCTION ? ( | ||
| <Route path='/react-query-redux-cache-sync'> | ||
| <ReactQueryReduxCacheSyncPage /> |
audius-infra pushed a commit
that referenced
this pull request
Dec 28, 2024
[de6d2a6] [C-5580] Remove legacy search page (#10856) Dylan Jeffers [ffb9160] [QA-1894] Fix addEntries metadata types (#10854) Dylan Jeffers [af64525] Update tab UI casing (#10853) Dylan Jeffers [b0da4b0] [C-5577] Update web tabs UI (#10849) Dylan Jeffers [7df0234] [C-5576] Dont build harmony (#10850) Dylan Jeffers [e43f533] [C-5561] Remove format utils dupes (#10840) Dylan Jeffers [b1e4dd6] [C-3728] Persist/update playlist image when adding track to playlist (#10852) Sebastian Klingler [1fcf9d7] [PAY-3744] Fix zod validation id error (#10846) Sebastian Klingler [0f0c6c9] Remove some unused packages (#10845) Sebastian Klingler [a3b9a5a] [C-5572] Add cache syncing between redux and react-query (#10833) Dylan Jeffers [162f389] [C-5574] Fix root verify (#10839) Dylan Jeffers [45e5fe9] [C-5575] Fix mobile build (#10835) Sebastian Klingler [107de26] [PAY-3733] Fix localStorage set (#10831) Sebastian Klingler [156936a] [C-5571] Update react-query hooks to use legacy data format (#10832) Dylan Jeffers [277288c] [C-5570] Remove v1 theme (#10826) Dylan Jeffers [246fd88] [PAY-3719] Add ExpandableNavItem component (#10808) Farid Salau
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now that redux and react-query are caching entities in the same data-format, we can add a bidirectional sync.
For redux -> react-query
For react-query -> redux
Other changes
How Has This Been Tested?
Added some example files showing this behavior