Uh oh!
There was an error while loading. Please reload this page.
Add AUDIUSD_CORE_ONLY for full discovery nodes - #10892
Conversation
|
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 2460751 | Triggered | Generic High Entropy Secret | 8319194 | cmd/audiusd/env/prod.env | View secret |
| 2416686 | Triggered | Generic High Entropy Secret | 8319194 | cmd/audiusd/env/stage.env | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
fc49bd9 to
d6f8e08Compare| audius_core_root_dir=/audius-core | ||
| uptimeDataDir=/bolt | ||
| AUDIUSD_STORAGE_ENABLED=true |
| audius_core_root_dir=/audius-core | ||
| uptimeDataDir=/bolt | ||
| AUDIUSD_STORAGE_ENABLED=true |
| @@ -206,16 +209,69 @@ func startEchoProxyWithOptionalTLS(hostUrl *url.URL, logger *common.Logger) erro | |||
| e.Use(middleware.Logger(), middleware.Recover()) | |||
| healthCheckResponse := func() map[string]interface{} { | |||
There was a problem hiding this comment.
not a big deal, but should this just be a separate function at this point? The only data I see injected into it is hostUrl, which could easily be a parameter
27761f0 to
630f6f8CompareAlso add AUDIUSD_CORE_ONLY mode to replace the audius/core docker image.
630f6f8 to
8319194Compare3e757be to
1c6fd22Comparedfab247 to
14ccb0cCompare14ccb0c to
2de7e88Compare2de7e88 to
ca55317Compare
RELATED: AudiusProject/audius-docker-compose#565
Unified
/health-check(note the intentional-because/health_checkis fugly).Also add
AUDIUSD_CORE_ONLYmode to replace the audius/core docker image.Upstream (proxied) health check response routes to be deprecated after this takes over.
LOCAL TEST
STAGE TEST
Tested this docker compose commit on stage dn5...