Skip to content

[PAY-3721] Mobile left nav updates - #10978

Merged
dharit-tan merged 6 commits into
mainfrom
rt-mobile-nav
Jan 9, 2025
Merged

[PAY-3721] Mobile left nav updates#10978
dharit-tan merged 6 commits into
mainfrom
rt-mobile-nav

Conversation

@dharit-tan

@dharit-tandharit-tan commented Jan 9, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

UI updates for mobile left nav.

Updated IconAudioNoTier to remove the extra top-padding.

Note:

  • Currently hardcoded some padding for the bottom-most audius logo. Tried to do justifyContent='space-between' + height='100%' but couldn't get it to work. BUT this means it will look borked on staging as staging has the extra feature flags row in left nav.
  • There is a 1px padding bug in BalancePill that I didn't get to fix elegantly.

How Has This Been Tested?

Simulator Screenshot - iPhone 16 Pro - 2025-01-09 at 00 12 28

@changeset-bot

changeset-botBot commented Jan 9, 2025•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8b6a404

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

faridsalau
faridsalau reviewed Jan 9, 2025
View reviewed changes
Comment threadpackages/common/src/hooks/useAudioBalance.ts
}

return null
return new BN(0) as BNWei

@faridsalaufaridsalauJan 9, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reason for this change?

@dharit-tandharit-tanJan 9, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typecheck was failing when this fn returned null. and the name of the fn has withFallback so i think we should fallback to 0.

faridsalau
faridsalau reviewed Jan 9, 2025
View reviewed changes
Comment threadpackages/mobile/src/components/balance-pill/BalancePill.tsx Outdated
faridsalau
faridsalau reviewed Jan 9, 2025
View reviewed changes
Comment threadpackages/mobile/src/screens/app-drawer-screen/left-nav-drawer/AccountDetails.tsx Outdated
faridsalau
faridsalau reviewed Jan 9, 2025
View reviewed changes
Comment threadpackages/mobile/src/components/balance-pill/BalancePill.tsx Outdated
faridsalau
faridsalau reviewed Jan 9, 2025
View reviewed changes
Comment threadpackages/mobile/src/screens/app-drawer-screen/left-nav-drawer/LeftNavDrawer.tsx Outdated
faridsalau
faridsalau reviewed Jan 9, 2025
View reviewed changes

@faridsalaufaridsalau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we should aim to use spacing from harmony over the spacing function. also, just double checking, does this cover all of these states?

faridsalau
faridsalau reviewed Jan 9, 2025
View reviewed changes
Comment threadpackages/mobile/src/harmony-native/components/BalancePill/BalancePill.tsx Outdated
faridsalau
faridsalau reviewed Jan 9, 2025
View reviewed changes
Comment threadpackages/mobile/src/screens/app-drawer-screen/left-nav-drawer/LeftNavDrawer.tsx
params={null}
/>
{isStaging || isFeatureFlagAccessEnabled ? (
{navItems.map((item) => (

@faridsalaufaridsalauJan 9, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could use a FlatList

@dharit-tandharit-tanJan 9, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of the scrollview?
good point but gonna leave for now, old code

faridsalau
faridsalau reviewed Jan 9, 2025
View reviewed changes

@faridsalaufaridsalau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lookin good 🙏

@dharit-tan
dharit-tan merged commit 357ecb2 into mainJan 9, 2025
@dharit-tan
dharit-tan deleted the rt-mobile-nav branch January 9, 2025 17:40
audius-infra pushed a commit that referenced this pull request Jan 11, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.117
6ab0d5e
[715d98e] Bump android to 1.1.462 (#11017) Raymond Jacobson
[e2577c7] [C-5655] Fix the margin on the mobile profile screen tabs (#11010) Kyle Shanks
[04c0433] [C-5557C-5554] Guest checkout ui fixes (#10993) Dylan Jeffers
[86f166e] [PAY-3706] Add history settings card (#11009) Farid Salau
[07c0d1f] [PAY-3724] Add tier levels to badges table (#10986) Raymond Jacobson
[76f0632] [PAY-3784] Split and Rewards Screens (#11006) Reed
[b687cd1] Default private playlist (#11007) Isaac Solo
[039dbce] Init history with useState to fix tests (#11004) Randy Schott
[0baf426] [QA-1908] Fix supporting tiles text in dark mode (#11003) Dylan Jeffers
[267344a] [C-5616] Improve listening history performance (#10946) Dylan Jeffers
[b83202d] Fix updating playlist/track artwork (#10998) Raymond Jacobson
[283333d] [C-5651] Update start scripts to default to spa (#10999) Dylan Jeffers
[e66eb6d] [PAY-3593] Revert "[PAY-3592] Always mark chat as read (temp fix) (#10397)" (#10983) Reed
[ac20b03] [PAY-3715][PAY-3754] Update playlists in navbar (#10985) Farid Salau
[357ecb2] [PAY-3721] Mobile left nav updates (#10978) Reed
[761eaee] Init history outside of context so it can't change (#10988) Randy Schott
[b2980c9] Cleanup account sagas and migrate to TS (#10970) Randy Schott
[2ed0753] Merge left nav updates into main (#10973) Farid Salau
[d14fe21] [QA-1907] Refresh only if not playing/uploading (#10972) Raymond Jacobson
[8eb29fa] Only init store once per mount of AppProviders (#10971) Randy Schott
[f686398] Fix pagination due to missing main-contont-context-provider (#10969) Dylan Jeffers
[234f28b] [QA-1906] Fix reaction size (#10966) Raymond Jacobson
[ab5b387] [C-5431] Fix web upload flow artwork overwrites when track is replaced (#10960) Kyle Shanks
[9d2601d] [QA-1895] Fix deactivate account styles (#10942) Raymond Jacobson
[a0d8d02] Temporarily disable track replace downloads until the DN code goes out (#10948) Kyle Shanks
[895ece6] [C-556] Fix sign-up completion link navigation (#10952) Dylan Jeffers
[8622abb] Pause track preview when replacing track file (#10950) Kyle Shanks
[2329cef] [PAY-3169] Remove sdkMigrationutils (#10949) Randy Schott
[f301daa] Fix track replace dependencies (#10947) Dylan Jeffers
[1a5c37b] [QA-1904] Fix profile tab SSR (#10941) Dylan Jeffers
[b5002dc] [C-5624] Fix entity image skeleton (#10940) Dylan Jeffers
[c3bc2db] [C-5496] Improve hit-slop for IconButton (#10939) Dylan Jeffers
[17ddf52] [C-5498] Fix track file name overflow (#10938) Dylan Jeffers
[8839160] [C-5630] Add track replace analytics (#10936) Kyle Shanks
[9320f9d] [C-5627] Fix download track after replace (#10937) Dylan Jeffers
[3c03886] Remove Solana wrappers (#10934) Marcus Pasell
[fde8a65] [PAY-3734] Fix useClickOutside behavior breaking WalletModal (#10926) Randy Schott
[7a31de8] [PAY-3732] Fix BuyAudio flow with SDK (#10931) Marcus Pasell
[e14b6ad] [QA-1903] Fix collections tab (#10928) Dylan Jeffers
[53bfbe3] [C-5596] Fix lowercase tabs (#10927) Dylan Jeffers
[aa13ea3] Fix edit track shows errors (#10925) Dylan Jeffers
[9918251] [C-3613] Fix issue with theme persistence (#10922) Dylan Jeffers
[ef4ed4a] Rely on backend to do Wormhole redemption (#10914) Marcus Pasell
[6c3a6f0] Bring back window.store (#10920) Raymond Jacobson
[5588049] [QA-1900] Fix track downloads by not having download service rely on window (#10919) Kyle Shanks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@faridsalaufaridsalaufaridsalau approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dharit-tan@faridsalau