Uh oh!
There was an error while loading. Please reload this page.
[C-5504] Fix mobile track replace reseting the upload form - #11073
Merged
Conversation
|
amendelsohn
approved these changes
Jan 16, 2025
| <Formik<FormValues> | ||
| initialValues={initialValues} | ||
| enableReinitialize | ||
| enableReinitialize={!initialValuesProp.isUpload} |
Contributor
There was a problem hiding this comment.
just checking that replace track will still work properly on the edit page?
ContributorAuthor
There was a problem hiding this comment.
yea this won't change anything for the edit page, it will still be true
Uh oh!
There was an error while loading. Please reload this page.
audius-infra pushed a commit
that referenced
this pull request
Jan 18, 2025
[661a932] Clean up account fetch ordering (#11081) Raymond Jacobson [c3f8251] Version Packages (#10361) github-actions[bot] [0f0084d] Fix listen streak challenge (#11089) Reed [9854cf5] Fix external inline links on web DMs (#11090) Reed [fdeb236] One shot reward UI + notif (#10788) Isaac Solo [b5f5a46] Fix spacing on follows you indicator (#11084) Raymond Jacobson [c7fb4fa] Tweak mobile amplitude config (#11082) JD Francis [bec2090] Remove `added_timestamps` usage from client (#11080) Randy Schott [78e56a9] [C-5676] Fix desktop search bar (#11077) Dylan Jeffers [11c13e6] [PAY-3824] Fix navigation loop bug (#11078) Farid Salau [c243c3a] [C-5504] Fix mobile track replace reseting the upload form (#11073) Kyle Shanks [8bf5600] Revert "[PAY-3593] Revert "[PAY-3592] Always mark chat as read (temp … (#11075) Reed [4c04c6d] [QA-1898] Fix reposts lineup disappearing on play (#11071) JD Francis [f0e7ed6] [PAY-2997] Consolidate hashid usage (#11005) Raymond Jacobson [45eaef8] Go back on exit key press (#11069) Farid Salau [12ab23e] Make wallet fields for tip analytics events optional (#11064) Randy Schott [9c2837c] Fix restriction (#11065) Farid Salau [c0a83bc] [PAY-3548] Split account metadata out of user metadata (#10989) Randy Schott [8ccd105] [QA-1917] Conditional render for dashboard button (#11063) Farid Salau [3e53d5a] Update dapp-store build artifacts audius-infra [fe9c82a] Refactor route matching logic and fix logged out disable state (#11060) Farid Salau [a8f08eb] Add analytics on nav link clicks (#11061) Farid Salau [1d52c62] [PAY-3808] Add proper spacing for sub item (#11058) Farid Salau [323281a] [PAY-3803] Fix web nav item hover/active states (#11055) Reed [0a7d724] [PAY-3812] Fix balance display in nav (#11057) Raymond Jacobson [407d609] [PAY-3807] Show folder kebab when open (#11053) Raymond Jacobson [3b33979] [PAY-3806] Show NowPlaying indicator on left nav items (#11052) Raymond Jacobson [47c0d40] Use PNG icons on web left nav (#11049) Reed [dd3cfda] [PAY-3809] Fix bad claim all format on mobile web (#11051) Raymond Jacobson [e05b63b] Address navbar nits (#11046) Farid Salau [c0024ed] Upgrade react native amplitude SDK (#11044) JD Francis [addd350] [PAY-3801] Update coinflow on mobile (#11045) Randy Schott [2cfbdaf] Add revelator and clean up ddex-entrypoint (#11040) Raymond Jacobson [9a8575c] [PAY-3792] Persist upload state between navigations (#11042) Raymond Jacobson [9402210] Update to solana 1.98.0 (#11026) Randy Schott [3b253ce] Add back new privacy policy banner (#11018) Raymond Jacobson [a3190df] More mobile left nav drawer UI tweaks (#11037) Reed [1debf83] [C-5542] Fix play counting bug on web track edits (#11039) Kyle Shanks [cd88ad8] [PAY-3799] Re-add playlist update dot (#11036) Farid Salau [49f0707] [PAY-3794] New mobile rewards UI (#11024) Reed [2deb213] Remove z-index on edit form button row to not block the profile complete tooltip (#11031) Kyle Shanks [f57404f] Guest checkout QA fixes (#10959) Isaac Solo [a46e54d] Update amplitude key on staging & revert change to use gain2 (#11032) JD Francis [6f3aab8] Fix playback in unauthenticated state (#11030) Raymond Jacobson [9fbd646] [PAY-3796] Update nav top (#11027) Farid Salau [b9c3101] [PAY-3793] Use png for badge tier icons (#11013) Reed [4d8d83a] Rename to ClaimAllRewardsTile + fix padding (#11023) Reed [97adbf5] Mobile left nav drawer not scrollable (#11014) Reed [3185272] Address bugbash comments (#11021) Farid Salau [e12f274] [PAY-3783] Update UI for Rewards page (#11002) Farid Salau [6690e63] [PAY-3694] Update coinflow on web (#11012) Randy Schott
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small updates to only pass in the initial values to the form screen once, but still update the fields that the user has not updated when the track is changed.
This should only affect the upload flow
How Has This Been Tested?
Manually Tested, also should not affect the edit form (I was mostly worried about the enableReinitialize prop)