Uh oh!
There was an error while loading. Please reload this page.
Update the logic for associated wallets to not brick DNs due to the db level constraint - #11322
Merged
Merged
Conversation
|
| if added_wallets or removed_wallets: | ||
| for wallet in added_wallets: | ||
| session.add(wallet) | ||
| for previous_wallet in previous_wallets: |
Contributor
There was a problem hiding this comment.
Shouldn't this be removed_wallets not previous_wallets?
ContributorAuthor
There was a problem hiding this comment.
yes you are correct. dangit
Uh oh!
There was an error while loading. Please reload this page.
audius-infra pushed a commit
that referenced
this pull request
Feb 10, 2025
[9f8335c] Small fix for the associated wallet logic update (#11324) Kyle Shanks [862fcf8] Fix audius-cmd turbo args (#11323) Marcus Pasell [eeff28d] Update the logic for associated wallets to not brick DNs due to the db level constraint (#11322) Kyle Shanks [94002de] fix local dev (#11317) alecsavvy [1fa4ef8] Add turbo remote caching to solana-relay, verified-notifications, and audius-cmd (#11314) Marcus Pasell [2ddf4c6] Revert "Aggregate step_count for listen streak challenge response (#1… (#11307) Reed
schottra added a commit
that referenced
this pull request
Feb 10, 2025
…xing * origin/main: Audius Protocol v0.7.87 Small fix for the associated wallet logic update (#11324) Fix audius-cmd turbo args (#11323) Update the logic for associated wallets to not brick DNs due to the db level constraint (#11322) Audius Client (Web and Mobile) v1.5.121 [PAY-3926] Fix mobile-web header notif/reward count positions (#11313) fix local dev (#11317) Fix bulk query fetching order (#11315) [C-5765] Profile nav fixes (#11311) Add turbo remote caching to solana-relay, verified-notifications, and audius-cmd (#11314) [PAY-3899] Fix reward modal padding and claim progress styling on web (#11309) [QA-1962] Update the get verified modal to keep the X button when loading (#11310) [PAY-3929] Fix claiming reward button state on mobile (#11308)
isaacsolo pushed a commit
that referenced
this pull request
Feb 10, 2025
…b level constraint (#11322)
isaacsolo pushed a commit
that referenced
this pull request
Feb 10, 2025
[9f8335c] Small fix for the associated wallet logic update (#11324) Kyle Shanks [862fcf8] Fix audius-cmd turbo args (#11323) Marcus Pasell [eeff28d] Update the logic for associated wallets to not brick DNs due to the db level constraint (#11322) Kyle Shanks [94002de] fix local dev (#11317) alecsavvy [1fa4ef8] Add turbo remote caching to solana-relay, verified-notifications, and audius-cmd (#11314) Marcus Pasell [2ddf4c6] Revert "Aggregate step_count for listen streak challenge response (#1… (#11307) Reed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A DB constraint was added to not allow duplicate associated wallets for a user. This was conflicting with how we were updating wallets previously.
The bug was that we were adding and removing all wallets in the previous_wallets and added_wallets lists which caused there to temporarily be duplicate rows for the user with the same wallet address and as a result would brick the DN indexer. This should update the logic to not update unnecessary rows and only add/remove wallets as needed.
no bugs plz
How Has This Been Tested?
It has not been yet. We will test