Skip to content

indexing side effects - #11492

Merged
alecsavvy merged 4 commits into
mainfrom
as/in-side-fx-core
Mar 4, 2025
Merged

indexing side effects#11492
alecsavvy merged 4 commits into
mainfrom
as/in-side-fx-core

Conversation

@alecsavvy

@alecsavvyalecsavvy commented Mar 3, 2025

Copy link
Copy Markdown
Contributor

Description

  • adds back the trending calculation from index_nethermind that was missing in index_core
  • adds back the delist status indexing from index_nethermind that was missing from index_core

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

@alecsavvyalecsavvy self-assigned this Mar 3, 2025
@changeset-bot

changeset-botBot commented Mar 3, 2025•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 697ed8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

faridsalau
faridsalau reviewed Mar 3, 2025
View reviewed changes
Comment threadpackages/discovery-provider/src/tasks/index_core_side_effects.py
# Only dispatch trending challenge computation on a similar block, modulo 100
# so things are consistent. Note that if a discovery node is behind, this will be
# inconsistent.
# TODO: Consider better alternatives for consistency with behind nodes. Maybe this

@faridsalaufaridsalauMar 3, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we attach a linear ticket to this comment. i.e. TODO: [PAY-123] Consider...

@alecsavvyalecsavvyMar 4, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this won't be an issue when the replica version of dn gets phased out + core

@alecsavvy
alecsavvy merged commit 3656b57 into mainMar 4, 2025
@alecsavvy
alecsavvy deleted the as/in-side-fx-core branch March 4, 2025 18:02
audius-infra pushed a commit that referenced this pull request Mar 5, 2025
audius-infra
Audius Protocol v0.7.104
12b263d
[d05de12] Fix missing cover-photo error log (#11512) Raymond Jacobson
[3c02192] Remove invalid model fields for create track/playlist notifs (#11511) Randy Schott
[e4056ed] Make stage first weekly comment backend match prod (#11508) Reed
[ed24d42] Use cross fetch in AAO plugin (#11505) Isaac Solo
[327e915] Enable stage AAO plugin config (#11502) Isaac Solo
[18a5dea] AAO UI (#11499) Steve Perkins
[3656b57] indexing side effects (#11492) alecsavvy
[1ec83cc] [PAY-3954] Add backend for play count challenge (#11473) Farid Salau
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isaacsoloisaacsoloAwaiting requested review from isaacsolo
1 more reviewer
@faridsalaufaridsalaufaridsalau approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@alecsavvyalecsavvy

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alecsavvy@faridsalau