[C-5795] Tan-query search to main by DejayJD · Pull Request #11542 · AudiusProject/apps

DejayJD · 2025-03-07T00:02:40Z

Description

Ports over tan-query search changes from feature-tan-query branch
Adds logic for lineup query cache hits not getting sent to lineup
Misc QA fixes around search components & logic
Brings in lineup changes from feature-tan-query

NOTE: this has changes that aren't on feature-tan-query and will need to overwrite changes on the feature branch

How Has This Been Tested?

web:stage -

Swapping between all/profiles/tracks/albums/playlists works as expected (preloads from all -> others)
All page - QA'd tracks lineup / loading states / no results / no query / recent searches
Profiles - QA'd infinite load / sort / filters / no results / no query
Tracks - QA'd lineup plays / infinite load / single track count lineup / no results / no query / all filters / grid view
Albums - QA'd infinite load / no results / no query / filters / sort
query params work as expected
TODO: cross reference filter data matches current prod data

ios:stage -

Sim looks good but want to test more in real staging app

…jd/tq-search-to-main # Conflicts: # packages/common/src/api/index.ts # packages/common/src/api/tan-query/types.ts # packages/web/src/components/search-bar/DesktopSearchBar.tsx # packages/web/src/components/search-bar/SearchBarResult.tsx

changeset-bot · 2025-03-07T00:02:44Z

⚠️ No Changeset found

Latest commit: 71dcbad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

DejayJD · 2025-03-07T00:09:13Z

 if (!lineupEntry) return

+ // NOTE: SPECIAL CASE - For tan-query search we don't want this behavior
+ if (lineupEntry.actions.prefix === SEARCH_PREFIX) return


really dont love doing this - down to explore something different, I think I just slapped this on right before going OOO lol
Would love ideas

amendelsohn

I can take a deeper look later, but at first readthrough, this looks good to me.

Nervous about the typing and lineup special casing, but I think it's pretty well contained.

amendelsohn · 2025-03-07T00:07:29Z

+ queryKey: getSearchResultsQueryKey(queryKeyArgs),
+ queryFn: async ({
+ pageParam
+ // unfortunately tanquery was having type issues with pageParam here


sad :(
happy to follow up on this together if you want to pair and experiment. ok with merging as is though

amendelsohn · 2025-03-07T00:13:26Z

+ dispatch(lineupActions.reset())
+ // NOTE: This squashes all previously cached pages into the first page of the lineup.
+ // This means the first page may have more entries than the pageSize.
+ // If this causes issues we can slice the data back into pages, but this seems more inefficient.


let's keep an eye on this. I think it'll be okay, but it makes me nervous 😅

…jd/tq-search-to-main # Conflicts: # packages/common/src/api/tan-query/utils/useLineupQuery.ts

…jd/tq-search-to-main

…jd/tq-search-to-main # Conflicts: # packages/common/src/api/index.ts

* origin/main: (138 commits) Add summary table to tastemaker mobile UI (#11617) [PAY-3998] Tastemaker challenge UI (#11615) Fix local eth ganache url (#11616) Fix index_tastemaker tests (#11614) Improve AAO tool UI (#11613) cleanup playwright (#11611) Revert "[C-5833] Avoid spreading queryResults (#11601)" (#11612) Add count for play count cards (#11610) Process challenge events sequentially (#11602) [PAY-4001] Tastemaker challenge backend (#11565) [C-5833] Avoid spreading queryResults (#11601) Use hex in first weekly comment challenge specifier (#11607) [PAY-4021] Address bug bash comments for play count milestones (#11606) Remove chain pubkey recovery. (#11605) Audius Protocol v0.7.110 Add rate limiter to otp on /authentication route (#11604) [C-5795] Tan-query search to main (#11542) [PROTO-2008] Fix search pagination offset issue + remove verified user deduping (#11600) Increase undisbursed challenge req limit to 500 (#11599) adjust relay to work in non dev without acdc (#11597) ...

[dc6bab1] ⚠️ Misc reward QA fixes (#11626) Reed [c6ceaf4] Fix challenge reward sort (#11627) Farid Salau [a11bfff] Query core blocks in block confirm endpoint (#11624) Reed [5aa86b1] Fix type errors that slipped through to main (#11623) Andrew Mendelsohn [ddb9503] [C-5832] Typechecking for tan-query selector option (#11603) Andrew Mendelsohn [50ab5c8] [C-5827] Tan-query profile reposts to main (web) (#11609) JD Francis [a804619] Add summary table to tastemaker mobile UI (#11617) Reed [cd0e6c0] [PAY-3998] Tastemaker challenge UI (#11615) Reed [1d074b0] Revert "[C-5833] Avoid spreading queryResults (#11601)" (#11612) Andrew Mendelsohn [154078a] Add count for play count cards (#11610) Farid Salau [b70578a] [C-5833] Avoid spreading queryResults (#11601) Andrew Mendelsohn [9691d33] [PAY-4021] Address bug bash comments for play count milestones (#11606) Farid Salau [448f5db] [C-5795] Tan-query search to main (#11542) JD Francis [f486072] Increase undisbursed challenge req limit to 500 (#11599) Reed [69c4da2] [QA-2011] Fix mobile-web drawer x close icon (#11593) Reed [ec5ca1a] [C-5815] Migrate followers user-list to tan-query (#11546) Dylan Jeffers [8bc0a7f] Use AAO plugin in prod (#11584) Isaac Solo [b231754] Audius Client (Web and Mobile) v1.5.125 (#11582) Dylan Jeffers [e1db903] Update playcount milestones challenge config & add icons (#11577) Farid Salau [3e4099c] [PAY-3935][PAY-3828] Remove remaining references to metadata_multihash in client and discovery (#11567) Randy Schott [7482138] Remove prop in PlayCountMilestoneContent causing type error (#11575) Farid Salau [df654fa] [C-5828] Fix useQueries default loading state (#11569) Dylan Jeffers [e22bac5] Fix unlocked gated content section on web (#11568) Reed [2a0405e] Remove dependency on getCurrentBlock in SDK (#11560) Randy Schott [84eb2f8] [PAY-3979][PAY-3990] Update play count challenge BE and Add the FE (#11521) Farid Salau [b477340] [QA-2008] Fixes styling issues on receive audio modal (#11559) Randy Schott [6550aa3] [QA-2007] Fix deleted page not respecting max page width (#11558) Randy Schott [c4437c8] [PAY-3982] Re-add trending, tier explainers to mobile & update mobile rewards banners (#11523) Reed [35ffe9e] [QA-2004] Fix delete icon popping above edit collection form footer (#11519) Randy Schott [3f631c1] Summary Table for first weekly comment challenge (#11520) Reed [f51f433] [PAY-3994] Prevent -1 fetches in tan query hooks (#11545) Raymond Jacobson

DejayJD added 9 commits February 25, 2025 16:06

porting over changes + qa changes
ab71945

misc QA things
5d5e87b

comment tweaks
33294dd

type fix
79fba5c

update usage of useLineupQuery
03d364d

fix ts issue
b7c8672

fix grid vs list styling issues
85c1489

port in mobile lineup
c0c97a4

DejayJD requested review from amendelsohn, dylanjeffers and schottra March 7, 2025 00:02

pull-request-sizeBot added the size/XXL label Mar 7, 2025

DejayJD commented Mar 7, 2025
View reviewed changes

amendelsohn approved these changes Mar 7, 2025
View reviewed changes

DejayJD added 7 commits March 7, 2025 14:18

PR feedback
f6a5f76

tweak load state
1cb0eaa

Merge branch 'main' of github.com:AudiusProject/audius-protocol into …
e05ff7e
…jd/tq-search-to-main # Conflicts: # packages/common/src/api/tan-query/utils/useLineupQuery.ts

Merge branch 'main' of github.com:AudiusProject/audius-protocol into …
74a3e5a
…jd/tq-search-to-main

Fix bugs with normalization
c58807a

fix type
a4c18d3

Merge branch 'main' of github.com:AudiusProject/audius-protocol into …
71dcbad
…jd/tq-search-to-main # Conflicts: # packages/common/src/api/index.ts

DejayJD enabled auto-merge (squash) March 12, 2025 21:22

DejayJD disabled auto-merge March 12, 2025 21:46

DejayJD merged commit 448f5db into mainMar 12, 2025

DejayJD deleted the jd/tq-search-to-main branch March 12, 2025 21:46

Navigation Menu

Uh oh!

[C-5795] Tan-query search to main - #11542

[C-5795] Tan-query search to main#11542
DejayJD merged 16 commits into
mainfrom
jd/tq-search-to-main

DejayJD commented Mar 7, 2025•
edited
Loading

Uh oh!

changeset-botBot commented Mar 7, 2025•
edited
Loading

Uh oh!

DejayJDMar 7, 2025•
edited
Loading

Uh oh!

amendelsohn left a comment

Uh oh!

amendelsohnMar 7, 2025

Uh oh!

Uh oh!

amendelsohnMar 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

DejayJD commented Mar 7, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Uh oh!

changeset-botBot commented Mar 7, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

DejayJDMar 7, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amendelsohn left a comment

Choose a reason for hiding this comment

Uh oh!

amendelsohnMar 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

amendelsohnMar 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

DejayJD commented Mar 7, 2025•
edited
Loading

changeset-botBot commented Mar 7, 2025•
edited
Loading

DejayJDMar 7, 2025•
edited
Loading