Uh oh!
There was an error while loading. Please reload this page.
Remove unnecessary web3-core dep from SDK - #11619
Conversation
|
| type Hex, | ||
| type TypedDataDefinition | ||
| } from 'viem' | ||
| import type { TransactionReceipt } from 'web3-core' |
There was a problem hiding this comment.
can we also remove this dep in solana-relay / relay too?
There was a problem hiding this comment.
I think so. Though we use more properties from that type in the coreRelay function
[e4ee76f] [PAY-4025] Fix listen streak, comment challenge inconsistent state (#11632) Reed [8172bea] Check cache before trying to get key from peers. (#11630) Steve Perkins [dc6bab1]⚠️ Misc reward QA fixes (#11626) Reed [a11bfff] Query core blocks in block confirm endpoint (#11624) Reed [2fe393c] Update TS for archiver to fix build errors (#11625) Randy Schott [ab53cf6] move current block up so num accessible down below (#11598) alecsavvy [22b34d0] Set pubkey for wallet if missing. (#11622) Steve Perkins [23c21d6] Add redis back to solana-relay (#11621) Reed [5a55e66] Remove unnecessary web3-core dep from SDK (#11619) Randy Schott
Description
We were relying on web3-core existing somewhere in the parent node_modules resolution path so we could import a single type from it and pick off two properties. It's easier to just define a local type for this result instead of importing one from a package we don't otherwise use.
How Has This Been Tested?
Types change only, so just need to verify typecheck in CI.