Skip to content

Add sort and filtering to remixes API - #11808

Merged
isaacsolo merged 1 commit into
mainfrom
is-remixes-sort-filter
Apr 10, 2025
Merged

Add sort and filtering to remixes API#11808
isaacsolo merged 1 commit into
mainfrom
is-remixes-sort-filter

Conversation

@isaacsolo

@isaacsoloisaacsolo commented Apr 9, 2025•
edited
Loading

Copy link
Copy Markdown

Description

Add sorting and filtering for remixes submission page.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Added some basic integration tests for getting remixes

@changeset-bot

changeset-botBot commented Apr 9, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6d84a2e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Kyle-Shanks
Kyle-Shanks reviewed Apr 10, 2025
View reviewed changes
Comment threadpackages/discovery-provider/src/queries/get_remixes_of.py
Comment on lines +110 to +111
ParentTrack.owner_id == Save.user_id,
ParentTrack.owner_id == Repost.user_id,

@Kyle-ShanksKyle-ShanksApr 10, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are cosigns just a like or repost? i thought there was a special field for this?

@isaacsoloisaacsoloApr 10, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah it's just a favorite or repost from the parent track owner

@isaacsolo
isaacsolo merged commit 15cbf16 into mainApr 10, 2025
@isaacsolo
isaacsolo deleted the is-remixes-sort-filter branch April 10, 2025 19:09
audius-infra pushed a commit that referenced this pull request Apr 11, 2025
audius-infra
Audius Protocol v0.7.131
dd8c398
[f9a8e41] [API-41] Clean up old trending versions add query idx (#11818) Raymond Jacobson
[200196b] Stop lying to ourselves about discovery node health (#11826) Raymond Jacobson
[1a74a87] Add missing package (#11827) Raymond Jacobson
[7a7aa6c] Update validation for end_date for events (#11829) KJ
[15cbf16] Add sort and filtering to remixes API (#11808) Isaac Solo
[8ba4da0] Delete challenges with _ in specifier (#11816) Reed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Kyle-ShanksKyle-ShanksKyle-Shanks approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@isaacsolo@Kyle-Shanks