Skip to content

[PE-6017] Mobile remix contest info section - #11930

Merged
dharit-tan merged 3 commits into
mainfrom
rt-mobile-remix-view
Apr 24, 2025
Merged

[PE-6017] Mobile remix contest info section#11930
dharit-tan merged 3 commits into
mainfrom
rt-mobile-remix-view

Conversation

@dharit-tan

@dharit-tandharit-tan commented Apr 24, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • New remix contest info section on TrackScreen
  • Uses react-native-tab-view for the Tab View UI
  • Not swipeable (left/right), can only press the headers (design confirmed swiping is nice-to-have but not needed)

Auto-resizing was tricky:

  • On first render, set position: absolute so that the onLayout handler can correctly measure the height of each tab's content (without position: absolute, the content is size 0). (This logic is handled in TabBody)
  • Use the resulting values in an animated style for height

TODO:

  • Expandable description
  • Scrolling is borked in the tab view
  • Loading state
  • Header styles aren't perfect

How Has This Been Tested?

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-04-23.at.20.07.32.mp4

@changeset-bot

changeset-botBot commented Apr 24, 2025•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4e1e8fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Kyle-Shanks
Kyle-Shanks approved these changes Apr 24, 2025
View reviewed changes

@Kyle-ShanksKyle-Shanks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat. whats up with the floating audio badge in the vid?

@dharit-tan

dharit-tan commented Apr 24, 2025

Copy link
Copy Markdown
ContributorAuthor

neat. whats up with the floating audio badge in the vid?

overflow bug from left nav that doesn't seem to be an issue on prod??

@dharit-tan
dharit-tan merged commit 6b8131a into mainApr 24, 2025
@dharit-tan
dharit-tan deleted the rt-mobile-remix-view branch April 24, 2025 16:41
audius-infra pushed a commit that referenced this pull request Apr 26, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.132
8561486
[194d43f] Fix unauth'd accounts fetching public data (#11948) Reed
[01b89e2] [PE-6021] Expandable remix contest description on web (#11946) Reed
[47be06f] [PE-6049] Remix contest container for mobile web (#11944) KJ
[26db394] [PE-5929] Upgrade react-native-collapsible-tab-view (#11811) Dylan Jeffers
[8f8e96c] [PE-6022] Mobile expandable remix contest description (#11936) Reed
[2e99134] Close 404 page when error is fixed (#11940) Farid Salau
[8b5c3b8] [PE-6020] Add submissions section to remix contest container on mobile (#11939) KJ
[636118d] Adjust cosign copy post limit (#11938) Isaac Solo
[ed9c2e1] [PE-6041] Android remix contest section styling (#11934) Reed
[cb0f1d8] Fix missing collection mobile artwork (#11935) Isaac Solo
[c75ac99] Add feature flags to tests, fix collection-card (#11907) Dylan Jeffers
[20a7174] Address async feedback on wallet UI m1 (#11933) Farid Salau
[cc18101] Prevent download-all-button from triggering expand download (#11922) Dylan Jeffers
[6b8131a] [PE-6017] Mobile remix contest info section (#11930) Reed
[0eb1682] Finish reverting back to favorite saga (#11931) Isaac Solo
[d8e9879] [PE-6019] Add submissions tab contest to the remix contest container (#11932) KJ
[e1a4561] Fix track tile layout spacing (#11929) Isaac Solo
[2a4ad5a] [PE-6015] Update the remix contest drawer on mobile (#11926) KJ
[afd52b2] Remove rogue fetchLineupMetadata call (#11928) JD Francis
[95ec68e] Add delay to hover card (#11927) Farid Salau
[603270a] Add remix contest flair (#11921) Isaac Solo
[bd5bda8] Fix user link on comment page (#11919) Farid Salau
[e36871e] Add new images to harmony for Wallet UI (#11925) Farid Salau
[a77a316] [PE-6034, PE 6033] Fix edit track (#11920) Dylan Jeffers
[ebc696a] Update cosign to use generic track flair component (#11911) Isaac Solo
[7b01e4b] Fix mobile lineup reset (#11914) Dylan Jeffers
[7243c38] [PE-6024] Use real remix eventData in remix contest section (#11916) Reed
[6150ac7] Small remix contest modal fix (#11917) KJ
[9300b39] Fix remix tracks skeleton issues (#11910) JD Francis
[deb0249] [PE-6005] Add mobile wallet UI (#11890) Farid Salau
[000d470] Fix stems not showing up in edit form (#11913) KJ
[f8c06b4] Update stem dup logic (#11912) KJ
[d8c9b65] [PE-6014] Add description and prize fields for remix contests (#11908) KJ
[4640162] [PE-6016] Web Remix Contest Section (#11906) Reed
[011438a] [PE-5994] Fix mobile lineups (#11905) Dylan Jeffers
[36e6f5d] Gate new user-badges in user-link behind wallet-ui flag (#11904) Dylan Jeffers
[96f9d7f] Fix remixes scroll bug (#11902) JD Francis
[d630cac] Add query client to tests (#11903) Farid Salau
[6798bde] Fix remix countdown timer wrong day count (#11901) Reed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dylanjeffersdylanjeffersAwaiting requested review from dylanjeffers
1 more reviewer
@Kyle-ShanksKyle-ShanksKyle-Shanks approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dharit-tan@Kyle-Shanks