Uh oh!
There was an error while loading. Please reload this page.
Fix type errors from last SDK update - #12641
Merged
Merged
Conversation
|
raymondjacobson
approved these changes
Aug 1, 2025
rickyrombo
commented
Aug 1, 2025
| !userId || | ||
| !entityType || | ||
| // 0 is a valid entityId for some actions | ||
| (!entityId && entityId !== 0n) || |
ContributorAuthor
There was a problem hiding this comment.
FYI @raymondjacobson you gotta use BigInt(0) for now until we target newer
ContributorAuthor
There was a problem hiding this comment.
Also... I'm pretty sure this check will never be false? 0x00000000000000000000000000000000 would be 0, right? Would missing bytes be null or undefined?
Uh oh!
There was an error while loading. Please reload this page.
audius-infra pushed a commit
that referenced
this pull request
Aug 2, 2025
[da813d6] Fix type errors from last SDK update (#12641) Marcus Pasell [1942623] [QA-2217] Add unread indicator for minimized chat list items (#12631) KJ [ee09eb2] [QA-1765] Fix mobile chat list item width then reacted to (#12633) KJ [9fd16dc] Update prod bundlesize check to 111 kB (#12632) Dylan Jeffers [c7cc739] [PE-6596] Add carousels to all results page (#12630) Dylan Jeffers [7595eb9] [PE-6589] Improve mobile search/explore header (#12629) Dylan Jeffers [b9f5f7b] Adhere to ios rich push naming standards (#12627) Dylan Jeffers [686aac2] [QA-2260] Update end_date logic for remix contest (#12623) KJ [9de7268] Fix staging ios build by avoiding harmony build (#12625) Dylan Jeffers [0dd8685] [QA-2241] Fix DMs playlist tile playback (#12621) KJ [2740ea2] Fix ConnectedWallets typeerror in mobile (#12617) Marcus Pasell [ed29921] [PE-6520] Add animation for highlight comments on web and mobile (#12609) KJ [dbcc819] [PE-6552] Adds quick search filters to explore page. (#12604) Randy Schott [f2c6de9] [QA-2253][QA-2252] Fix swaps and hexagon icon (#12615) Farid Salau [e245269] Fix crash on AudioBreakdownModal (#12614) Marcus Pasell [e2e33b2] [QA-2258] Fix mobile env for local development (#12611) Dylan Jeffers [11152c1] [QA-2259] Fix sentry errors and warnings for logged out user (#12612) Dylan Jeffers [ab69d7c] Squash unnecessary sentry reports (#12613) Marcus Pasell [239ceb0] [QA-2254] Fix unable to unlock special access tracks (#12610) Dylan Jeffers [f3b8dc8] [QA-2021] Fix artist dashboard year filter (#12608) Dylan Jeffers [bbd40f0] [QA-1877] Fix track page repost overflow menu (#12607) Dylan Jeffers [1546c2b] [QA-2176] Fix top supporter text (#12606) Dylan Jeffers [def820c] [QA-2177] Fix collectible deep links (#12605) Dylan Jeffers [93f4cf2] Make SDK mint agnostic and have solana-relay respect ArtistCoins table (#12603) Marcus Pasell [17e8def] [PE-6556] Adds trending playlists to explore page (#12587) Randy Schott [fce25f8] [QA-2230] Fix trending navigation issues (#12600) Dylan Jeffers [f3d02de] [QA-2227] Fix user-link font colors (#12599) Dylan Jeffers [f10c029] [PE-6574] Mobile Token Leaderboard (#12595) Dylan Jeffers [ab02fda] [PE-6449] Add Rich Push (#12597) Dylan Jeffers [1355e52] [QA-2229] Fix special access track tile (#12601) Dylan Jeffers [d0de748] Add meta-externalfetcher to isBot check (#12598) Marcus Pasell [300a2fb] Remove more coins section (#12596) Farid Salau
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes type errors issues introduced in #12635