Skip to content

[PE-6657] Artist coin leaderboard card - #12734

Merged
DejayJD merged 10 commits into
mainfrom
jd/leaderboard-card-web
Aug 15, 2025
Merged

[PE-6657] Artist coin leaderboard card#12734
DejayJD merged 10 commits into
mainfrom
jd/leaderboard-card-web

Conversation

@DejayJD

@DejayJDDejayJD commented Aug 14, 2025

Copy link
Copy Markdown
Contributor

Description

2025-08-14 13 20 24

  • Moves the leaderboard feature to a card UI
  • Fixed the leaderboard modal not showing decimals
  • Tweaked token balance hooks to return a locale readable balance alongside other balance

How Has This Been Tested?

web:stage - tested in small and big browser sizes, tested with bonk and audio, tested loading state with TQ tools

@DejayJD
DejayJD requested review from Kyle-Shanks, dharit-tan, dylanjeffers and faridsalau and removed request for dylanjeffersAugust 14, 2025 18:22
faridsalau
faridsalau reviewed Aug 14, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts Outdated
faridsalau
faridsalau reviewed Aug 14, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts Outdated
faridsalau
faridsalau reviewed Aug 14, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
return {
userId: decodeHashId(member.userId) ?? 0,
balance: member.balance,
balanceLocaleString: balanceFD.toLocaleString('en-US', {

@faridsalaufaridsalauAug 14, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel like we should probably be using packages/common/src/store/ui/buy-sell/useTokenAmountFormatting.ts here?

@DejayJDDejayJDAug 14, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My goal is actually to eventually consolidate that hook!
I just don't have that as part of that PR. Ideally that hook doesn't exist as it's own hook; the formatted value should either be baked into the slice, or as a reusable selector that we pass onto this hook (leaning towards selector but again, more todo here)
Let me add a todo here actually

faridsalau
faridsalau reviewed Aug 14, 2025
View reviewed changes
Comment threadpackages/web/src/pages/asset-detail-page/components/AssetLeaderboardCard.tsx
Comment on lines +85 to +92
<AvatarSkeleton css={{ marginLeft: '0' }} />
<AvatarSkeleton />
<AvatarSkeleton />
<AvatarSkeleton />
<AvatarSkeleton />
<AvatarSkeleton />
<AvatarSkeleton />
<AvatarSkeleton />

@faridsalaufaridsalauAug 14, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could just map over an arr

dylanjeffers
dylanjeffers approved these changes Aug 14, 2025
View reviewed changes

@dylanjeffersdylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dope

Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts Outdated
Comment threadpackages/web/src/pages/asset-detail-page/components/AssetLeaderboardCard.tsx Outdated
} from '@audius/harmony'
import { useDispatch } from 'react-redux'

import { UserProfilePictureList } from 'components/notification/Notification/components/UserProfilePictureList'

@dylanjeffersdylanjeffersAug 14, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one day we move this to a common space :D

@DejayJDDejayJDAug 14, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao I didnt even realize this was coming from such a weird import. Should be able to move in this PR without too much effort

@DejayJDDejayJDAug 14, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f013b4a

@changeset-bot

changeset-botBot commented Aug 14, 2025•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 612b4b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DejayJD
DejayJD enabled auto-merge (squash) August 14, 2025 22:18
@DejayJD
DejayJD disabled auto-merge August 15, 2025 03:16
@DejayJD
DejayJD merged commit e4241dc into mainAug 15, 2025
3 of 5 checks passed
@DejayJD
DejayJD deleted the jd/leaderboard-card-web branch August 15, 2025 03:16
audius-infra pushed a commit that referenced this pull request Aug 16, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.148
55deb3c
[c667cb7] Fix share profile drawer issue (#12751) JD Francis
[65212e8] Fix E2E tests by fixing remix notification (#12748) Marcus Pasell
[42bb9d1] Tweak your coins skeletons (#12756) JD Francis
[f20aa78] [PE-6664] Fix small screen coin page layout issues (#12754) JD Francis
[3d82588] Fix responsiveness on AUDIO page (#12755) Farid Salau
[1f9434e] Show correct image in user badge stack on AllCoinsPage (#12753) Farid Salau
[270363a] Invalidate 'userCoins' query after swap (#12752) Farid Salau
[11b6310] [PE-6668] Update add external wallets button to send to sign up if user is not signed in (#12750) KJ
[fdb8cc9] Small lint fix (#12749) JD Francis
[e4241dc] [PE-6657] Artist coin leaderboard card (#12734) JD Francis
[edac449] Update qr code colors (#12741) Dylan Jeffers
[02b5d48] [PE-6677] Fix user badge artist coins (#12745) Dylan Jeffers
[f631cf3] Fix coin options (#12743) Dylan Jeffers
[d0ad5ae] [PE-6667] Fix token balance swap issues (#12738) JD Francis
[5c2570c] Fix listening history (#12731) Randy Schott
[d42fb2e] [PE-6636] Add receive-tokens modal. (#12725) Dylan Jeffers
[5841688] Adjust remix contest timezone (#12722) Dylan Jeffers
[b883712] Fix buy-sell modal error handling and UI improvements (#12728) Farid Salau
[7f4cb6a] Remove original param for download (#12686) Ray Jacobson
[4f88de6] [PE-6638] Update coin leaderboard user list to handle long user names (#12730) KJ
[1fb49f5] [PE-6588] Add downloads available section to search/explore (#12723) Randy Schott
[19a745e] Revert "Speed up sdk build by only building for web and native (#12391)" (#12727) Dylan Jeffers
[ddfbaa5] [PE-6621] Connected wallets UI (#12697) JD Francis
[bb58d64] Clean up unnecessary amplitude events (#12684) JD Francis
[76fd651] [PE-6651, PE-6647, PE-6634, PE-6646] Artist Coin QA 2 (#12724) KJ
[b1aec05] [PE-6637, PE-6639] Artist Coin QA 1 (#12721) KJ
[e161b05] Speed up sdk build by only building for web and native (#12391) Dylan Jeffers
[5ba4590] [PE-6608] Fix persistence of recent searches on web (#12718) Randy Schott
[d4d4a39] Web Search/Explore QA fixes (#12717) Randy Schott
[d75ae2e] [PE-6643] Add unauth state for Wallet pages (#12714) Farid Salau
[31e7687] Update Asset Detail Pages to use proper data (#12713) Farid Salau
[b50ccef] Fix trending playlists playback on web (#12712) Randy Schott
[74e5991] [QA-2163] Delete collections with tan-query (#12700) Dylan Jeffers
[515f884] Fix left-align page container (#12711) Dylan Jeffers
[3554bb2] [PE-6656] Fix dupe playlist track uids (#12715) JD Francis
[39a3f54] Add support for oembeds (#12692) Marcus Pasell
[3ccbd99] Improve mobile profile refresh (#12699) Dylan Jeffers
[b186d9b] [PE-6541] Update UserBadges to display top token (#12710) KJ
[cd468d8] [QA-2202] Improve podcast support (#12698) Dylan Jeffers
[1b2f943] add best of section back to mobile if we aren't showing new explore content (#12708) Randy Schott
[6e8f43b] Fix skeletons for title/artist on track tiles (#12707) Randy Schott
[f626163] [PE-6605] Add dropdown menu to artist coins (#12705) Farid Salau
[36e2a6a] Revert mobile Artwork changes (#12706) Farid Salau
schottra added a commit that referenced this pull request Aug 18, 2025
@schottra
Merge remote-tracking branch 'origin/main' into search-explore-fixes
b0ebd89
* origin/main: (25 commits)
Drop es indexes before reindexing (#12762)
Audius Protocol v0.7.222
Audius Client (Web and Mobile) v1.5.148
Setup elasticsearch for bridge in local dev (#12760)
Fix share profile drawer issue (#12751)
Fix E2E tests by fixing remix notification (#12748)
Fix sort order (#12758)
Tweak your coins skeletons (#12756)
[PE-6664] Fix small screen coin page layout issues (#12754)
Fix responsiveness on AUDIO page (#12755)
Show correct image in user badge stack on AllCoinsPage (#12753)
Invalidate 'userCoins' query after swap (#12752)
[PE-6668] Update add external wallets button to send to sign up if user is not signed in (#12750)
Small lint fix (#12749)
Audius Protocol v0.7.221
Added loaded addresses to account_keys in user bank indexer (#12747)
Update postgres version in local dev to 15.5 (#12746)
[PE-6657] Artist coin leaderboard card (#12734)
Update qr code colors (#12741)
[PE-6677] Fix user badge artist coins (#12745)
...
schottra added a commit that referenced this pull request Aug 18, 2025
@schottra
Merge remote-tracking branch 'origin/main' into more-change-email-logs
786e5f2
* origin/main: (26 commits)
Drop es indexes before reindexing (#12762)
Audius Protocol v0.7.222
Audius Client (Web and Mobile) v1.5.148
Setup elasticsearch for bridge in local dev (#12760)
Fix share profile drawer issue (#12751)
Fix E2E tests by fixing remix notification (#12748)
Fix sort order (#12758)
Tweak your coins skeletons (#12756)
[PE-6664] Fix small screen coin page layout issues (#12754)
Fix responsiveness on AUDIO page (#12755)
Show correct image in user badge stack on AllCoinsPage (#12753)
Invalidate 'userCoins' query after swap (#12752)
[PE-6668] Update add external wallets button to send to sign up if user is not signed in (#12750)
Small lint fix (#12749)
Audius Protocol v0.7.221
Added loaded addresses to account_keys in user bank indexer (#12747)
Update postgres version in local dev to 15.5 (#12746)
[PE-6657] Artist coin leaderboard card (#12734)
Update qr code colors (#12741)
[PE-6677] Fix user badge artist coins (#12745)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dylanjeffersdylanjeffersdylanjeffers approved these changes
@dharit-tandharit-tanAwaiting requested review from dharit-tan
@Kyle-ShanksKyle-ShanksAwaiting requested review from Kyle-Shanks
+1 more reviewer
@faridsalaufaridsalaufaridsalau left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DejayJD@dylanjeffers@faridsalau
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[PE-6657] Artist coin leaderboard card by DejayJD · Pull Request #12734 · AudiusProject/apps · GitHub
Skip to content
[PE-6657] Artist coin leaderboard card - #12734
Merged
DejayJD merged 10 commits into
mainfrom 
jd/leaderboard-card-web
Aug 15, 2025
Merged
[PE-6657] Artist coin leaderboard card#12734
DejayJD merged 10 commits into
mainfrom 
jd/leaderboard-card-web
Conversation
@DejayJD
@DejayJDDejayJD
commented
Aug 14, 2025

Copy link


Copy Markdown

Contributor
Description
2025-08-14 13 20 24
  • Moves the leaderboard feature to a card UI
  • Fixed the leaderboard modal not showing decimals
  • Tweaked token balance hooks to return a locale readable balance alongside other balance
How Has This Been Tested?
web:stage - tested in small and big browser sizes, tested with bonk and audio, tested loading state with TQ tools
@DejayJD
DejayJD
requested review from
Kyle-Shanks, dharit-tan, dylanjeffers and faridsalau
and removed request for
dylanjeffersAugust 14, 2025 18:22
faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
Outdated

faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
Outdated

faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
 return {
 userId: decodeHashId(member.userId) ?? 0,
 balance: member.balance,
 balanceLocaleString: balanceFD.toLocaleString('en-US', {
@faridsalaufaridsalauAug 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel like we should probably be using packages/common/src/store/ui/buy-sell/useTokenAmountFormatting.ts here?
@DejayJDDejayJDAug 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My goal is actually to eventually consolidate that hook!

I just don't have that as part of that PR. Ideally that hook doesn't exist as it's own hook; the formatted value should either be baked into the slice, or as a reusable selector that we pass onto this hook (leaning towards selector but again, more todo here)

Let me add a todo here actually
faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/web/src/pages/asset-detail-page/components/AssetLeaderboardCard.tsx

Comment on lines

+85
 to 
+92

 <AvatarSkeleton css={{ marginLeft: '0' }} />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
@faridsalaufaridsalauAug 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could just map over an arr
dylanjeffers
dylanjeffers
approved these changes
Aug 14, 2025
View reviewed changes
@dylanjeffersdylanjeffers
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dope
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
Outdated

Comment threadpackages/web/src/pages/asset-detail-page/components/AssetLeaderboardCard.tsx
Outdated

} from '@audius/harmony'
import { useDispatch } from 'react-redux'

import { UserProfilePictureList } from 'components/notification/Notification/components/UserProfilePictureList'
@dylanjeffersdylanjeffersAug 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one day we move this to a common space :D
@DejayJDDejayJDAug 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao I didnt even realize this was coming from such a weird import. Should be able to move in this PR without too much effort
@DejayJDDejayJDAug 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f013b4a
@changeset-bot
changeset-botBot
commented
Aug 14, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 612b4b6
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@DejayJD
DejayJD
enabled auto-merge (squash)
August 14, 2025 22:18
@DejayJD
DejayJD
disabled auto-merge
August 15, 2025 03:16
@DejayJD
DejayJD
merged commit e4241dc
into
mainAug 15, 2025

3 of 5 checks passed

@DejayJD
DejayJD
deleted the

jd/leaderboard-card-web

branch
August 15, 2025 03:16
audius-infra pushed a commit
that referenced
this pull request
Aug 16, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.148
55deb3c
[c667cb7] Fix share profile drawer issue (#12751) JD Francis
[65212e8] Fix E2E tests by fixing remix notification (#12748) Marcus Pasell
[42bb9d1] Tweak your coins skeletons (#12756) JD Francis
[f20aa78] [PE-6664] Fix small screen coin page layout issues (#12754) JD Francis
[3d82588] Fix responsiveness on AUDIO page (#12755) Farid Salau
[1f9434e] Show correct image in user badge stack on AllCoinsPage (#12753) Farid Salau
[270363a] Invalidate 'userCoins' query after swap (#12752) Farid Salau
[11b6310] [PE-6668] Update add external wallets button to send to sign up if user is not signed in (#12750) KJ
[fdb8cc9] Small lint fix (#12749) JD Francis
[e4241dc] [PE-6657] Artist coin leaderboard card (#12734) JD Francis
[edac449] Update qr code colors (#12741) Dylan Jeffers
[02b5d48] [PE-6677] Fix user badge artist coins (#12745) Dylan Jeffers
[f631cf3] Fix coin options (#12743) Dylan Jeffers
[d0ad5ae] [PE-6667] Fix token balance swap issues (#12738) JD Francis
[5c2570c] Fix listening history (#12731) Randy Schott
[d42fb2e] [PE-6636] Add receive-tokens modal. (#12725) Dylan Jeffers
[5841688] Adjust remix contest timezone (#12722) Dylan Jeffers
[b883712] Fix buy-sell modal error handling and UI improvements (#12728) Farid Salau
[7f4cb6a] Remove original param for download (#12686) Ray Jacobson
[4f88de6] [PE-6638] Update coin leaderboard user list to handle long user names (#12730) KJ
[1fb49f5] [PE-6588] Add downloads available section to search/explore (#12723) Randy Schott
[19a745e] Revert "Speed up sdk build by only building for web and native (#12391)" (#12727) Dylan Jeffers
[ddfbaa5] [PE-6621] Connected wallets UI (#12697) JD Francis
[bb58d64] Clean up unnecessary amplitude events (#12684) JD Francis
[76fd651] [PE-6651, PE-6647, PE-6634, PE-6646] Artist Coin QA 2 (#12724) KJ
[b1aec05] [PE-6637, PE-6639] Artist Coin QA 1 (#12721) KJ
[e161b05] Speed up sdk build by only building for web and native (#12391) Dylan Jeffers
[5ba4590] [PE-6608] Fix persistence of recent searches on web (#12718) Randy Schott
[d4d4a39] Web Search/Explore QA fixes (#12717) Randy Schott
[d75ae2e] [PE-6643] Add unauth state for Wallet pages (#12714) Farid Salau
[31e7687] Update Asset Detail Pages to use proper data (#12713) Farid Salau
[b50ccef] Fix trending playlists playback on web (#12712) Randy Schott
[74e5991] [QA-2163] Delete collections with tan-query (#12700) Dylan Jeffers
[515f884] Fix left-align page container (#12711) Dylan Jeffers
[3554bb2] [PE-6656] Fix dupe playlist track uids (#12715) JD Francis
[39a3f54] Add support for oembeds (#12692) Marcus Pasell
[3ccbd99] Improve mobile profile refresh (#12699) Dylan Jeffers
[b186d9b] [PE-6541] Update UserBadges to display top token (#12710) KJ
[cd468d8] [QA-2202] Improve podcast support (#12698) Dylan Jeffers
[1b2f943] add best of section back to mobile if we aren't showing new explore content (#12708) Randy Schott
[6e8f43b] Fix skeletons for title/artist on track tiles (#12707) Randy Schott
[f626163] [PE-6605] Add dropdown menu to artist coins (#12705) Farid Salau
[36e2a6a] Revert mobile Artwork changes (#12706) Farid Salau
schottra added a commit
that referenced
this pull request
Aug 18, 2025
@schottra
Merge remote-tracking branch 'origin/main' into search-explore-fixes
b0ebd89
* origin/main: (25 commits)
Drop es indexes before reindexing (#12762)
Audius Protocol v0.7.222
Audius Client (Web and Mobile) v1.5.148
Setup elasticsearch for bridge in local dev (#12760)
Fix share profile drawer issue (#12751)
Fix E2E tests by fixing remix notification (#12748)
Fix sort order (#12758)
Tweak your coins skeletons (#12756)
[PE-6664] Fix small screen coin page layout issues (#12754)
Fix responsiveness on AUDIO page (#12755)
Show correct image in user badge stack on AllCoinsPage (#12753)
Invalidate 'userCoins' query after swap (#12752)
[PE-6668] Update add external wallets button to send to sign up if user is not signed in (#12750)
Small lint fix (#12749)
Audius Protocol v0.7.221
Added loaded addresses to account_keys in user bank indexer (#12747)
Update postgres version in local dev to 15.5 (#12746)
[PE-6657] Artist coin leaderboard card (#12734)
Update qr code colors (#12741)
[PE-6677] Fix user badge artist coins (#12745)
...
schottra added a commit
that referenced
this pull request
Aug 18, 2025
@schottra
Merge remote-tracking branch 'origin/main' into more-change-email-logs
786e5f2
* origin/main: (26 commits)
Drop es indexes before reindexing (#12762)
Audius Protocol v0.7.222
Audius Client (Web and Mobile) v1.5.148
Setup elasticsearch for bridge in local dev (#12760)
Fix share profile drawer issue (#12751)
Fix E2E tests by fixing remix notification (#12748)
Fix sort order (#12758)
Tweak your coins skeletons (#12756)
[PE-6664] Fix small screen coin page layout issues (#12754)
Fix responsiveness on AUDIO page (#12755)
Show correct image in user badge stack on AllCoinsPage (#12753)
Invalidate 'userCoins' query after swap (#12752)
[PE-6668] Update add external wallets button to send to sign up if user is not signed in (#12750)
Small lint fix (#12749)
Audius Protocol v0.7.221
Added loaded addresses to account_keys in user bank indexer (#12747)
Update postgres version in local dev to 15.5 (#12746)
[PE-6657] Artist coin leaderboard card (#12734)
Update qr code colors (#12741)
[PE-6677] Fix user badge artist coins (#12745)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dylanjeffersdylanjeffersdylanjeffers approved these changes
@dharit-tandharit-tanAwaiting requested review from dharit-tan
@Kyle-ShanksKyle-ShanksAwaiting requested review from Kyle-Shanks

+1 more reviewer

@faridsalaufaridsalaufaridsalau left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

size/L

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@DejayJD@dylanjeffers@faridsalau

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[PE-6657] Artist coin leaderboard card by DejayJD · Pull Request #12734 · AudiusProject/apps · GitHub
Skip to content
[PE-6657] Artist coin leaderboard card - #12734
Merged
DejayJD merged 10 commits into
mainfrom 
jd/leaderboard-card-web
Aug 15, 2025
Merged
[PE-6657] Artist coin leaderboard card#12734
DejayJD merged 10 commits into
mainfrom 
jd/leaderboard-card-web
Conversation
@DejayJD
@DejayJDDejayJD
commented
Aug 14, 2025

Copy link


Copy Markdown

Contributor
Description
2025-08-14 13 20 24
  • Moves the leaderboard feature to a card UI
  • Fixed the leaderboard modal not showing decimals
  • Tweaked token balance hooks to return a locale readable balance alongside other balance
How Has This Been Tested?
web:stage - tested in small and big browser sizes, tested with bonk and audio, tested loading state with TQ tools
@DejayJD
DejayJD
requested review from
Kyle-Shanks, dharit-tan, dylanjeffers and faridsalau
and removed request for
dylanjeffersAugust 14, 2025 18:22
faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
Outdated

faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
Outdated

faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
 return {
 userId: decodeHashId(member.userId) ?? 0,
 balance: member.balance,
 balanceLocaleString: balanceFD.toLocaleString('en-US', {
@faridsalaufaridsalauAug 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel like we should probably be using packages/common/src/store/ui/buy-sell/useTokenAmountFormatting.ts here?
@DejayJDDejayJDAug 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My goal is actually to eventually consolidate that hook!

I just don't have that as part of that PR. Ideally that hook doesn't exist as it's own hook; the formatted value should either be baked into the slice, or as a reusable selector that we pass onto this hook (leaning towards selector but again, more todo here)

Let me add a todo here actually
faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/web/src/pages/asset-detail-page/components/AssetLeaderboardCard.tsx

Comment on lines

+85
 to 
+92

 <AvatarSkeleton css={{ marginLeft: '0' }} />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
@faridsalaufaridsalauAug 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could just map over an arr
dylanjeffers
dylanjeffers
approved these changes
Aug 14, 2025
View reviewed changes
@dylanjeffersdylanjeffers
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dope
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
Outdated

Comment threadpackages/web/src/pages/asset-detail-page/components/AssetLeaderboardCard.tsx
Outdated

} from '@audius/harmony'
import { useDispatch } from 'react-redux'

import { UserProfilePictureList } from 'components/notification/Notification/components/UserProfilePictureList'
@dylanjeffersdylanjeffersAug 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one day we move this to a common space :D
@DejayJDDejayJDAug 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao I didnt even realize this was coming from such a weird import. Should be able to move in this PR without too much effort
@DejayJDDejayJDAug 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f013b4a
@changeset-bot
changeset-botBot
commented
Aug 14, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 612b4b6
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@DejayJD
DejayJD
enabled auto-merge (squash)
August 14, 2025 22:18
@DejayJD
DejayJD
disabled auto-merge
August 15, 2025 03:16
@DejayJD
DejayJD
merged commit e4241dc
into
mainAug 15, 2025

3 of 5 checks passed

@DejayJD
DejayJD
deleted the

jd/leaderboard-card-web

branch
August 15, 2025 03:16
audius-infra pushed a commit
that referenced
this pull request
Aug 16, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.148
55deb3c
[c667cb7] Fix share profile drawer issue (#12751) JD Francis
[65212e8] Fix E2E tests by fixing remix notification (#12748) Marcus Pasell
[42bb9d1] Tweak your coins skeletons (#12756) JD Francis
[f20aa78] [PE-6664] Fix small screen coin page layout issues (#12754) JD Francis
[3d82588] Fix responsiveness on AUDIO page (#12755) Farid Salau
[1f9434e] Show correct image in user badge stack on AllCoinsPage (#12753) Farid Salau
[270363a] Invalidate 'userCoins' query after swap (#12752) Farid Salau
[11b6310] [PE-6668] Update add external wallets button to send to sign up if user is not signed in (#12750) KJ
[fdb8cc9] Small lint fix (#12749) JD Francis
[e4241dc] [PE-6657] Artist coin leaderboard card (#12734) JD Francis
[edac449] Update qr code colors (#12741) Dylan Jeffers
[02b5d48] [PE-6677] Fix user badge artist coins (#12745) Dylan Jeffers
[f631cf3] Fix coin options (#12743) Dylan Jeffers
[d0ad5ae] [PE-6667] Fix token balance swap issues (#12738) JD Francis
[5c2570c] Fix listening history (#12731) Randy Schott
[d42fb2e] [PE-6636] Add receive-tokens modal. (#12725) Dylan Jeffers
[5841688] Adjust remix contest timezone (#12722) Dylan Jeffers
[b883712] Fix buy-sell modal error handling and UI improvements (#12728) Farid Salau
[7f4cb6a] Remove original param for download (#12686) Ray Jacobson
[4f88de6] [PE-6638] Update coin leaderboard user list to handle long user names (#12730) KJ
[1fb49f5] [PE-6588] Add downloads available section to search/explore (#12723) Randy Schott
[19a745e] Revert "Speed up sdk build by only building for web and native (#12391)" (#12727) Dylan Jeffers
[ddfbaa5] [PE-6621] Connected wallets UI (#12697) JD Francis
[bb58d64] Clean up unnecessary amplitude events (#12684) JD Francis
[76fd651] [PE-6651, PE-6647, PE-6634, PE-6646] Artist Coin QA 2 (#12724) KJ
[b1aec05] [PE-6637, PE-6639] Artist Coin QA 1 (#12721) KJ
[e161b05] Speed up sdk build by only building for web and native (#12391) Dylan Jeffers
[5ba4590] [PE-6608] Fix persistence of recent searches on web (#12718) Randy Schott
[d4d4a39] Web Search/Explore QA fixes (#12717) Randy Schott
[d75ae2e] [PE-6643] Add unauth state for Wallet pages (#12714) Farid Salau
[31e7687] Update Asset Detail Pages to use proper data (#12713) Farid Salau
[b50ccef] Fix trending playlists playback on web (#12712) Randy Schott
[74e5991] [QA-2163] Delete collections with tan-query (#12700) Dylan Jeffers
[515f884] Fix left-align page container (#12711) Dylan Jeffers
[3554bb2] [PE-6656] Fix dupe playlist track uids (#12715) JD Francis
[39a3f54] Add support for oembeds (#12692) Marcus Pasell
[3ccbd99] Improve mobile profile refresh (#12699) Dylan Jeffers
[b186d9b] [PE-6541] Update UserBadges to display top token (#12710) KJ
[cd468d8] [QA-2202] Improve podcast support (#12698) Dylan Jeffers
[1b2f943] add best of section back to mobile if we aren't showing new explore content (#12708) Randy Schott
[6e8f43b] Fix skeletons for title/artist on track tiles (#12707) Randy Schott
[f626163] [PE-6605] Add dropdown menu to artist coins (#12705) Farid Salau
[36e2a6a] Revert mobile Artwork changes (#12706) Farid Salau
schottra added a commit
that referenced
this pull request
Aug 18, 2025
@schottra
Merge remote-tracking branch 'origin/main' into search-explore-fixes
b0ebd89
* origin/main: (25 commits)
Drop es indexes before reindexing (#12762)
Audius Protocol v0.7.222
Audius Client (Web and Mobile) v1.5.148
Setup elasticsearch for bridge in local dev (#12760)
Fix share profile drawer issue (#12751)
Fix E2E tests by fixing remix notification (#12748)
Fix sort order (#12758)
Tweak your coins skeletons (#12756)
[PE-6664] Fix small screen coin page layout issues (#12754)
Fix responsiveness on AUDIO page (#12755)
Show correct image in user badge stack on AllCoinsPage (#12753)
Invalidate 'userCoins' query after swap (#12752)
[PE-6668] Update add external wallets button to send to sign up if user is not signed in (#12750)
Small lint fix (#12749)
Audius Protocol v0.7.221
Added loaded addresses to account_keys in user bank indexer (#12747)
Update postgres version in local dev to 15.5 (#12746)
[PE-6657] Artist coin leaderboard card (#12734)
Update qr code colors (#12741)
[PE-6677] Fix user badge artist coins (#12745)
...
schottra added a commit
that referenced
this pull request
Aug 18, 2025
@schottra
Merge remote-tracking branch 'origin/main' into more-change-email-logs
786e5f2
* origin/main: (26 commits)
Drop es indexes before reindexing (#12762)
Audius Protocol v0.7.222
Audius Client (Web and Mobile) v1.5.148
Setup elasticsearch for bridge in local dev (#12760)
Fix share profile drawer issue (#12751)
Fix E2E tests by fixing remix notification (#12748)
Fix sort order (#12758)
Tweak your coins skeletons (#12756)
[PE-6664] Fix small screen coin page layout issues (#12754)
Fix responsiveness on AUDIO page (#12755)
Show correct image in user badge stack on AllCoinsPage (#12753)
Invalidate 'userCoins' query after swap (#12752)
[PE-6668] Update add external wallets button to send to sign up if user is not signed in (#12750)
Small lint fix (#12749)
Audius Protocol v0.7.221
Added loaded addresses to account_keys in user bank indexer (#12747)
Update postgres version in local dev to 15.5 (#12746)
[PE-6657] Artist coin leaderboard card (#12734)
Update qr code colors (#12741)
[PE-6677] Fix user badge artist coins (#12745)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dylanjeffersdylanjeffersdylanjeffers approved these changes
@dharit-tandharit-tanAwaiting requested review from dharit-tan
@Kyle-ShanksKyle-ShanksAwaiting requested review from Kyle-Shanks

+1 more reviewer

@faridsalaufaridsalaufaridsalau left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

size/L

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@DejayJD@dylanjeffers@faridsalau

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[PE-6657] Artist coin leaderboard card by DejayJD · Pull Request #12734 · AudiusProject/apps · GitHub
Skip to content
[PE-6657] Artist coin leaderboard card - #12734
Merged
DejayJD merged 10 commits into
mainfrom 
jd/leaderboard-card-web
Aug 15, 2025
Merged
[PE-6657] Artist coin leaderboard card#12734
DejayJD merged 10 commits into
mainfrom 
jd/leaderboard-card-web
Conversation
@DejayJD
@DejayJDDejayJD
commented
Aug 14, 2025

Copy link


Copy Markdown

Contributor
Description
2025-08-14 13 20 24
  • Moves the leaderboard feature to a card UI
  • Fixed the leaderboard modal not showing decimals
  • Tweaked token balance hooks to return a locale readable balance alongside other balance
How Has This Been Tested?
web:stage - tested in small and big browser sizes, tested with bonk and audio, tested loading state with TQ tools
@DejayJD
DejayJD
requested review from
Kyle-Shanks, dharit-tan, dylanjeffers and faridsalau
and removed request for
dylanjeffersAugust 14, 2025 18:22
faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
Outdated

faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
Outdated

faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
 return {
 userId: decodeHashId(member.userId) ?? 0,
 balance: member.balance,
 balanceLocaleString: balanceFD.toLocaleString('en-US', {
@faridsalaufaridsalauAug 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel like we should probably be using packages/common/src/store/ui/buy-sell/useTokenAmountFormatting.ts here?
@DejayJDDejayJDAug 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My goal is actually to eventually consolidate that hook!

I just don't have that as part of that PR. Ideally that hook doesn't exist as it's own hook; the formatted value should either be baked into the slice, or as a reusable selector that we pass onto this hook (leaning towards selector but again, more todo here)

Let me add a todo here actually
faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/web/src/pages/asset-detail-page/components/AssetLeaderboardCard.tsx

Comment on lines

+85
 to 
+92

 <AvatarSkeleton css={{ marginLeft: '0' }} />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
@faridsalaufaridsalauAug 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could just map over an arr
dylanjeffers
dylanjeffers
approved these changes
Aug 14, 2025
View reviewed changes
@dylanjeffersdylanjeffers
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dope
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
Outdated

Comment threadpackages/web/src/pages/asset-detail-page/components/AssetLeaderboardCard.tsx
Outdated

} from '@audius/harmony'
import { useDispatch } from 'react-redux'

import { UserProfilePictureList } from 'components/notification/Notification/components/UserProfilePictureList'
@dylanjeffersdylanjeffersAug 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one day we move this to a common space :D
@DejayJDDejayJDAug 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao I didnt even realize this was coming from such a weird import. Should be able to move in this PR without too much effort
@DejayJDDejayJDAug 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f013b4a
@changeset-bot
changeset-botBot
commented
Aug 14, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 612b4b6
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@DejayJD
DejayJD
enabled auto-merge (squash)
August 14, 2025 22:18
@DejayJD
DejayJD
disabled auto-merge
August 15, 2025 03:16
@DejayJD
DejayJD
merged commit e4241dc
into
mainAug 15, 2025

3 of 5 checks passed

@DejayJD
DejayJD
deleted the

jd/leaderboard-card-web

branch
August 15, 2025 03:16
audius-infra pushed a commit
that referenced
this pull request
Aug 16, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.148
55deb3c
[c667cb7] Fix share profile drawer issue (#12751) JD Francis
[65212e8] Fix E2E tests by fixing remix notification (#12748) Marcus Pasell
[42bb9d1] Tweak your coins skeletons (#12756) JD Francis
[f20aa78] [PE-6664] Fix small screen coin page layout issues (#12754) JD Francis
[3d82588] Fix responsiveness on AUDIO page (#12755) Farid Salau
[1f9434e] Show correct image in user badge stack on AllCoinsPage (#12753) Farid Salau
[270363a] Invalidate 'userCoins' query after swap (#12752) Farid Salau
[11b6310] [PE-6668] Update add external wallets button to send to sign up if user is not signed in (#12750) KJ
[fdb8cc9] Small lint fix (#12749) JD Francis
[e4241dc] [PE-6657] Artist coin leaderboard card (#12734) JD Francis
[edac449] Update qr code colors (#12741) Dylan Jeffers
[02b5d48] [PE-6677] Fix user badge artist coins (#12745) Dylan Jeffers
[f631cf3] Fix coin options (#12743) Dylan Jeffers
[d0ad5ae] [PE-6667] Fix token balance swap issues (#12738) JD Francis
[5c2570c] Fix listening history (#12731) Randy Schott
[d42fb2e] [PE-6636] Add receive-tokens modal. (#12725) Dylan Jeffers
[5841688] Adjust remix contest timezone (#12722) Dylan Jeffers
[b883712] Fix buy-sell modal error handling and UI improvements (#12728) Farid Salau
[7f4cb6a] Remove original param for download (#12686) Ray Jacobson
[4f88de6] [PE-6638] Update coin leaderboard user list to handle long user names (#12730) KJ
[1fb49f5] [PE-6588] Add downloads available section to search/explore (#12723) Randy Schott
[19a745e] Revert "Speed up sdk build by only building for web and native (#12391)" (#12727) Dylan Jeffers
[ddfbaa5] [PE-6621] Connected wallets UI (#12697) JD Francis
[bb58d64] Clean up unnecessary amplitude events (#12684) JD Francis
[76fd651] [PE-6651, PE-6647, PE-6634, PE-6646] Artist Coin QA 2 (#12724) KJ
[b1aec05] [PE-6637, PE-6639] Artist Coin QA 1 (#12721) KJ
[e161b05] Speed up sdk build by only building for web and native (#12391) Dylan Jeffers
[5ba4590] [PE-6608] Fix persistence of recent searches on web (#12718) Randy Schott
[d4d4a39] Web Search/Explore QA fixes (#12717) Randy Schott
[d75ae2e] [PE-6643] Add unauth state for Wallet pages (#12714) Farid Salau
[31e7687] Update Asset Detail Pages to use proper data (#12713) Farid Salau
[b50ccef] Fix trending playlists playback on web (#12712) Randy Schott
[74e5991] [QA-2163] Delete collections with tan-query (#12700) Dylan Jeffers
[515f884] Fix left-align page container (#12711) Dylan Jeffers
[3554bb2] [PE-6656] Fix dupe playlist track uids (#12715) JD Francis
[39a3f54] Add support for oembeds (#12692) Marcus Pasell
[3ccbd99] Improve mobile profile refresh (#12699) Dylan Jeffers
[b186d9b] [PE-6541] Update UserBadges to display top token (#12710) KJ
[cd468d8] [QA-2202] Improve podcast support (#12698) Dylan Jeffers
[1b2f943] add best of section back to mobile if we aren't showing new explore content (#12708) Randy Schott
[6e8f43b] Fix skeletons for title/artist on track tiles (#12707) Randy Schott
[f626163] [PE-6605] Add dropdown menu to artist coins (#12705) Farid Salau
[36e2a6a] Revert mobile Artwork changes (#12706) Farid Salau
schottra added a commit
that referenced
this pull request
Aug 18, 2025
@schottra
Merge remote-tracking branch 'origin/main' into search-explore-fixes
b0ebd89
* origin/main: (25 commits)
Drop es indexes before reindexing (#12762)
Audius Protocol v0.7.222
Audius Client (Web and Mobile) v1.5.148
Setup elasticsearch for bridge in local dev (#12760)
Fix share profile drawer issue (#12751)
Fix E2E tests by fixing remix notification (#12748)
Fix sort order (#12758)
Tweak your coins skeletons (#12756)
[PE-6664] Fix small screen coin page layout issues (#12754)
Fix responsiveness on AUDIO page (#12755)
Show correct image in user badge stack on AllCoinsPage (#12753)
Invalidate 'userCoins' query after swap (#12752)
[PE-6668] Update add external wallets button to send to sign up if user is not signed in (#12750)
Small lint fix (#12749)
Audius Protocol v0.7.221
Added loaded addresses to account_keys in user bank indexer (#12747)
Update postgres version in local dev to 15.5 (#12746)
[PE-6657] Artist coin leaderboard card (#12734)
Update qr code colors (#12741)
[PE-6677] Fix user badge artist coins (#12745)
...
schottra added a commit
that referenced
this pull request
Aug 18, 2025
@schottra
Merge remote-tracking branch 'origin/main' into more-change-email-logs
786e5f2
* origin/main: (26 commits)
Drop es indexes before reindexing (#12762)
Audius Protocol v0.7.222
Audius Client (Web and Mobile) v1.5.148
Setup elasticsearch for bridge in local dev (#12760)
Fix share profile drawer issue (#12751)
Fix E2E tests by fixing remix notification (#12748)
Fix sort order (#12758)
Tweak your coins skeletons (#12756)
[PE-6664] Fix small screen coin page layout issues (#12754)
Fix responsiveness on AUDIO page (#12755)
Show correct image in user badge stack on AllCoinsPage (#12753)
Invalidate 'userCoins' query after swap (#12752)
[PE-6668] Update add external wallets button to send to sign up if user is not signed in (#12750)
Small lint fix (#12749)
Audius Protocol v0.7.221
Added loaded addresses to account_keys in user bank indexer (#12747)
Update postgres version in local dev to 15.5 (#12746)
[PE-6657] Artist coin leaderboard card (#12734)
Update qr code colors (#12741)
[PE-6677] Fix user badge artist coins (#12745)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dylanjeffersdylanjeffersdylanjeffers approved these changes
@dharit-tandharit-tanAwaiting requested review from dharit-tan
@Kyle-ShanksKyle-ShanksAwaiting requested review from Kyle-Shanks

+1 more reviewer

@faridsalaufaridsalaufaridsalau left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

size/L

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@DejayJD@dylanjeffers@faridsalau

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[PE-6657] Artist coin leaderboard card by DejayJD · Pull Request #12734 · AudiusProject/apps · GitHub
Skip to content
[PE-6657] Artist coin leaderboard card - #12734
Merged
DejayJD merged 10 commits into
mainfrom 
jd/leaderboard-card-web
Aug 15, 2025
Merged
[PE-6657] Artist coin leaderboard card#12734
DejayJD merged 10 commits into
mainfrom 
jd/leaderboard-card-web
Conversation
@DejayJD
@DejayJDDejayJD
commented
Aug 14, 2025

Copy link


Copy Markdown

Contributor
Description
2025-08-14 13 20 24
  • Moves the leaderboard feature to a card UI
  • Fixed the leaderboard modal not showing decimals
  • Tweaked token balance hooks to return a locale readable balance alongside other balance
How Has This Been Tested?
web:stage - tested in small and big browser sizes, tested with bonk and audio, tested loading state with TQ tools
@DejayJD
DejayJD
requested review from
Kyle-Shanks, dharit-tan, dylanjeffers and faridsalau
and removed request for
dylanjeffersAugust 14, 2025 18:22
faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
Outdated

faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
Outdated

faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
 return {
 userId: decodeHashId(member.userId) ?? 0,
 balance: member.balance,
 balanceLocaleString: balanceFD.toLocaleString('en-US', {
@faridsalaufaridsalauAug 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel like we should probably be using packages/common/src/store/ui/buy-sell/useTokenAmountFormatting.ts here?
@DejayJDDejayJDAug 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My goal is actually to eventually consolidate that hook!

I just don't have that as part of that PR. Ideally that hook doesn't exist as it's own hook; the formatted value should either be baked into the slice, or as a reusable selector that we pass onto this hook (leaning towards selector but again, more todo here)

Let me add a todo here actually
faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/web/src/pages/asset-detail-page/components/AssetLeaderboardCard.tsx

Comment on lines

+85
 to 
+92

 <AvatarSkeleton css={{ marginLeft: '0' }} />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
@faridsalaufaridsalauAug 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could just map over an arr
dylanjeffers
dylanjeffers
approved these changes
Aug 14, 2025
View reviewed changes
@dylanjeffersdylanjeffers
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dope
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
Outdated

Comment threadpackages/web/src/pages/asset-detail-page/components/AssetLeaderboardCard.tsx
Outdated

} from '@audius/harmony'
import { useDispatch } from 'react-redux'

import { UserProfilePictureList } from 'components/notification/Notification/components/UserProfilePictureList'
@dylanjeffersdylanjeffersAug 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one day we move this to a common space :D
@DejayJDDejayJDAug 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao I didnt even realize this was coming from such a weird import. Should be able to move in this PR without too much effort
@DejayJDDejayJDAug 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f013b4a
@changeset-bot
changeset-botBot
commented
Aug 14, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 612b4b6
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@DejayJD
DejayJD
enabled auto-merge (squash)
August 14, 2025 22:18
@DejayJD
DejayJD
disabled auto-merge
August 15, 2025 03:16
@DejayJD
DejayJD
merged commit e4241dc
into
mainAug 15, 2025

3 of 5 checks passed

@DejayJD
DejayJD
deleted the

jd/leaderboard-card-web

branch
August 15, 2025 03:16
audius-infra pushed a commit
that referenced
this pull request
Aug 16, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.148
55deb3c
[c667cb7] Fix share profile drawer issue (#12751) JD Francis
[65212e8] Fix E2E tests by fixing remix notification (#12748) Marcus Pasell
[42bb9d1] Tweak your coins skeletons (#12756) JD Francis
[f20aa78] [PE-6664] Fix small screen coin page layout issues (#12754) JD Francis
[3d82588] Fix responsiveness on AUDIO page (#12755) Farid Salau
[1f9434e] Show correct image in user badge stack on AllCoinsPage (#12753) Farid Salau
[270363a] Invalidate 'userCoins' query after swap (#12752) Farid Salau
[11b6310] [PE-6668] Update add external wallets button to send to sign up if user is not signed in (#12750) KJ
[fdb8cc9] Small lint fix (#12749) JD Francis
[e4241dc] [PE-6657] Artist coin leaderboard card (#12734) JD Francis
[edac449] Update qr code colors (#12741) Dylan Jeffers
[02b5d48] [PE-6677] Fix user badge artist coins (#12745) Dylan Jeffers
[f631cf3] Fix coin options (#12743) Dylan Jeffers
[d0ad5ae] [PE-6667] Fix token balance swap issues (#12738) JD Francis
[5c2570c] Fix listening history (#12731) Randy Schott
[d42fb2e] [PE-6636] Add receive-tokens modal. (#12725) Dylan Jeffers
[5841688] Adjust remix contest timezone (#12722) Dylan Jeffers
[b883712] Fix buy-sell modal error handling and UI improvements (#12728) Farid Salau
[7f4cb6a] Remove original param for download (#12686) Ray Jacobson
[4f88de6] [PE-6638] Update coin leaderboard user list to handle long user names (#12730) KJ
[1fb49f5] [PE-6588] Add downloads available section to search/explore (#12723) Randy Schott
[19a745e] Revert "Speed up sdk build by only building for web and native (#12391)" (#12727) Dylan Jeffers
[ddfbaa5] [PE-6621] Connected wallets UI (#12697) JD Francis
[bb58d64] Clean up unnecessary amplitude events (#12684) JD Francis
[76fd651] [PE-6651, PE-6647, PE-6634, PE-6646] Artist Coin QA 2 (#12724) KJ
[b1aec05] [PE-6637, PE-6639] Artist Coin QA 1 (#12721) KJ
[e161b05] Speed up sdk build by only building for web and native (#12391) Dylan Jeffers
[5ba4590] [PE-6608] Fix persistence of recent searches on web (#12718) Randy Schott
[d4d4a39] Web Search/Explore QA fixes (#12717) Randy Schott
[d75ae2e] [PE-6643] Add unauth state for Wallet pages (#12714) Farid Salau
[31e7687] Update Asset Detail Pages to use proper data (#12713) Farid Salau
[b50ccef] Fix trending playlists playback on web (#12712) Randy Schott
[74e5991] [QA-2163] Delete collections with tan-query (#12700) Dylan Jeffers
[515f884] Fix left-align page container (#12711) Dylan Jeffers
[3554bb2] [PE-6656] Fix dupe playlist track uids (#12715) JD Francis
[39a3f54] Add support for oembeds (#12692) Marcus Pasell
[3ccbd99] Improve mobile profile refresh (#12699) Dylan Jeffers
[b186d9b] [PE-6541] Update UserBadges to display top token (#12710) KJ
[cd468d8] [QA-2202] Improve podcast support (#12698) Dylan Jeffers
[1b2f943] add best of section back to mobile if we aren't showing new explore content (#12708) Randy Schott
[6e8f43b] Fix skeletons for title/artist on track tiles (#12707) Randy Schott
[f626163] [PE-6605] Add dropdown menu to artist coins (#12705) Farid Salau
[36e2a6a] Revert mobile Artwork changes (#12706) Farid Salau
schottra added a commit
that referenced
this pull request
Aug 18, 2025
@schottra
Merge remote-tracking branch 'origin/main' into search-explore-fixes
b0ebd89
* origin/main: (25 commits)
Drop es indexes before reindexing (#12762)
Audius Protocol v0.7.222
Audius Client (Web and Mobile) v1.5.148
Setup elasticsearch for bridge in local dev (#12760)
Fix share profile drawer issue (#12751)
Fix E2E tests by fixing remix notification (#12748)
Fix sort order (#12758)
Tweak your coins skeletons (#12756)
[PE-6664] Fix small screen coin page layout issues (#12754)
Fix responsiveness on AUDIO page (#12755)
Show correct image in user badge stack on AllCoinsPage (#12753)
Invalidate 'userCoins' query after swap (#12752)
[PE-6668] Update add external wallets button to send to sign up if user is not signed in (#12750)
Small lint fix (#12749)
Audius Protocol v0.7.221
Added loaded addresses to account_keys in user bank indexer (#12747)
Update postgres version in local dev to 15.5 (#12746)
[PE-6657] Artist coin leaderboard card (#12734)
Update qr code colors (#12741)
[PE-6677] Fix user badge artist coins (#12745)
...
schottra added a commit
that referenced
this pull request
Aug 18, 2025
@schottra
Merge remote-tracking branch 'origin/main' into more-change-email-logs
786e5f2
* origin/main: (26 commits)
Drop es indexes before reindexing (#12762)
Audius Protocol v0.7.222
Audius Client (Web and Mobile) v1.5.148
Setup elasticsearch for bridge in local dev (#12760)
Fix share profile drawer issue (#12751)
Fix E2E tests by fixing remix notification (#12748)
Fix sort order (#12758)
Tweak your coins skeletons (#12756)
[PE-6664] Fix small screen coin page layout issues (#12754)
Fix responsiveness on AUDIO page (#12755)
Show correct image in user badge stack on AllCoinsPage (#12753)
Invalidate 'userCoins' query after swap (#12752)
[PE-6668] Update add external wallets button to send to sign up if user is not signed in (#12750)
Small lint fix (#12749)
Audius Protocol v0.7.221
Added loaded addresses to account_keys in user bank indexer (#12747)
Update postgres version in local dev to 15.5 (#12746)
[PE-6657] Artist coin leaderboard card (#12734)
Update qr code colors (#12741)
[PE-6677] Fix user badge artist coins (#12745)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dylanjeffersdylanjeffersdylanjeffers approved these changes
@dharit-tandharit-tanAwaiting requested review from dharit-tan
@Kyle-ShanksKyle-ShanksAwaiting requested review from Kyle-Shanks

+1 more reviewer

@faridsalaufaridsalaufaridsalau left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

size/L

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@DejayJD@dylanjeffers@faridsalau

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[PE-6657] Artist coin leaderboard card by DejayJD · Pull Request #12734 · AudiusProject/apps · GitHub
Skip to content
[PE-6657] Artist coin leaderboard card - #12734
Merged
DejayJD merged 10 commits into
mainfrom 
jd/leaderboard-card-web
Aug 15, 2025
Merged
[PE-6657] Artist coin leaderboard card#12734
DejayJD merged 10 commits into
mainfrom 
jd/leaderboard-card-web
Conversation
@DejayJD
@DejayJDDejayJD
commented
Aug 14, 2025

Copy link


Copy Markdown

Contributor
Description
2025-08-14 13 20 24
  • Moves the leaderboard feature to a card UI
  • Fixed the leaderboard modal not showing decimals
  • Tweaked token balance hooks to return a locale readable balance alongside other balance
How Has This Been Tested?
web:stage - tested in small and big browser sizes, tested with bonk and audio, tested loading state with TQ tools
@DejayJD
DejayJD
requested review from
Kyle-Shanks, dharit-tan, dylanjeffers and faridsalau
and removed request for
dylanjeffersAugust 14, 2025 18:22
faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
Outdated

faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
Outdated

faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
 return {
 userId: decodeHashId(member.userId) ?? 0,
 balance: member.balance,
 balanceLocaleString: balanceFD.toLocaleString('en-US', {
@faridsalaufaridsalauAug 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel like we should probably be using packages/common/src/store/ui/buy-sell/useTokenAmountFormatting.ts here?
@DejayJDDejayJDAug 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My goal is actually to eventually consolidate that hook!

I just don't have that as part of that PR. Ideally that hook doesn't exist as it's own hook; the formatted value should either be baked into the slice, or as a reusable selector that we pass onto this hook (leaning towards selector but again, more todo here)

Let me add a todo here actually
faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/web/src/pages/asset-detail-page/components/AssetLeaderboardCard.tsx

Comment on lines

+85
 to 
+92

 <AvatarSkeleton css={{ marginLeft: '0' }} />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
@faridsalaufaridsalauAug 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could just map over an arr
dylanjeffers
dylanjeffers
approved these changes
Aug 14, 2025
View reviewed changes
@dylanjeffersdylanjeffers
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dope
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
Outdated

Comment threadpackages/web/src/pages/asset-detail-page/components/AssetLeaderboardCard.tsx
Outdated

} from '@audius/harmony'
import { useDispatch } from 'react-redux'

import { UserProfilePictureList } from 'components/notification/Notification/components/UserProfilePictureList'
@dylanjeffersdylanjeffersAug 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one day we move this to a common space :D
@DejayJDDejayJDAug 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao I didnt even realize this was coming from such a weird import. Should be able to move in this PR without too much effort
@DejayJDDejayJDAug 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f013b4a
@changeset-bot
changeset-botBot
commented
Aug 14, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 612b4b6
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@DejayJD
DejayJD
enabled auto-merge (squash)
August 14, 2025 22:18
@DejayJD
DejayJD
disabled auto-merge
August 15, 2025 03:16
@DejayJD
DejayJD
merged commit e4241dc
into
mainAug 15, 2025

3 of 5 checks passed

@DejayJD
DejayJD
deleted the

jd/leaderboard-card-web

branch
August 15, 2025 03:16
audius-infra pushed a commit
that referenced
this pull request
Aug 16, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.148
55deb3c
[c667cb7] Fix share profile drawer issue (#12751) JD Francis
[65212e8] Fix E2E tests by fixing remix notification (#12748) Marcus Pasell
[42bb9d1] Tweak your coins skeletons (#12756) JD Francis
[f20aa78] [PE-6664] Fix small screen coin page layout issues (#12754) JD Francis
[3d82588] Fix responsiveness on AUDIO page (#12755) Farid Salau
[1f9434e] Show correct image in user badge stack on AllCoinsPage (#12753) Farid Salau
[270363a] Invalidate 'userCoins' query after swap (#12752) Farid Salau
[11b6310] [PE-6668] Update add external wallets button to send to sign up if user is not signed in (#12750) KJ
[fdb8cc9] Small lint fix (#12749) JD Francis
[e4241dc] [PE-6657] Artist coin leaderboard card (#12734) JD Francis
[edac449] Update qr code colors (#12741) Dylan Jeffers
[02b5d48] [PE-6677] Fix user badge artist coins (#12745) Dylan Jeffers
[f631cf3] Fix coin options (#12743) Dylan Jeffers
[d0ad5ae] [PE-6667] Fix token balance swap issues (#12738) JD Francis
[5c2570c] Fix listening history (#12731) Randy Schott
[d42fb2e] [PE-6636] Add receive-tokens modal. (#12725) Dylan Jeffers
[5841688] Adjust remix contest timezone (#12722) Dylan Jeffers
[b883712] Fix buy-sell modal error handling and UI improvements (#12728) Farid Salau
[7f4cb6a] Remove original param for download (#12686) Ray Jacobson
[4f88de6] [PE-6638] Update coin leaderboard user list to handle long user names (#12730) KJ
[1fb49f5] [PE-6588] Add downloads available section to search/explore (#12723) Randy Schott
[19a745e] Revert "Speed up sdk build by only building for web and native (#12391)" (#12727) Dylan Jeffers
[ddfbaa5] [PE-6621] Connected wallets UI (#12697) JD Francis
[bb58d64] Clean up unnecessary amplitude events (#12684) JD Francis
[76fd651] [PE-6651, PE-6647, PE-6634, PE-6646] Artist Coin QA 2 (#12724) KJ
[b1aec05] [PE-6637, PE-6639] Artist Coin QA 1 (#12721) KJ
[e161b05] Speed up sdk build by only building for web and native (#12391) Dylan Jeffers
[5ba4590] [PE-6608] Fix persistence of recent searches on web (#12718) Randy Schott
[d4d4a39] Web Search/Explore QA fixes (#12717) Randy Schott
[d75ae2e] [PE-6643] Add unauth state for Wallet pages (#12714) Farid Salau
[31e7687] Update Asset Detail Pages to use proper data (#12713) Farid Salau
[b50ccef] Fix trending playlists playback on web (#12712) Randy Schott
[74e5991] [QA-2163] Delete collections with tan-query (#12700) Dylan Jeffers
[515f884] Fix left-align page container (#12711) Dylan Jeffers
[3554bb2] [PE-6656] Fix dupe playlist track uids (#12715) JD Francis
[39a3f54] Add support for oembeds (#12692) Marcus Pasell
[3ccbd99] Improve mobile profile refresh (#12699) Dylan Jeffers
[b186d9b] [PE-6541] Update UserBadges to display top token (#12710) KJ
[cd468d8] [QA-2202] Improve podcast support (#12698) Dylan Jeffers
[1b2f943] add best of section back to mobile if we aren't showing new explore content (#12708) Randy Schott
[6e8f43b] Fix skeletons for title/artist on track tiles (#12707) Randy Schott
[f626163] [PE-6605] Add dropdown menu to artist coins (#12705) Farid Salau
[36e2a6a] Revert mobile Artwork changes (#12706) Farid Salau
schottra added a commit
that referenced
this pull request
Aug 18, 2025
@schottra
Merge remote-tracking branch 'origin/main' into search-explore-fixes
b0ebd89
* origin/main: (25 commits)
Drop es indexes before reindexing (#12762)
Audius Protocol v0.7.222
Audius Client (Web and Mobile) v1.5.148
Setup elasticsearch for bridge in local dev (#12760)
Fix share profile drawer issue (#12751)
Fix E2E tests by fixing remix notification (#12748)
Fix sort order (#12758)
Tweak your coins skeletons (#12756)
[PE-6664] Fix small screen coin page layout issues (#12754)
Fix responsiveness on AUDIO page (#12755)
Show correct image in user badge stack on AllCoinsPage (#12753)
Invalidate 'userCoins' query after swap (#12752)
[PE-6668] Update add external wallets button to send to sign up if user is not signed in (#12750)
Small lint fix (#12749)
Audius Protocol v0.7.221
Added loaded addresses to account_keys in user bank indexer (#12747)
Update postgres version in local dev to 15.5 (#12746)
[PE-6657] Artist coin leaderboard card (#12734)
Update qr code colors (#12741)
[PE-6677] Fix user badge artist coins (#12745)
...
schottra added a commit
that referenced
this pull request
Aug 18, 2025
@schottra
Merge remote-tracking branch 'origin/main' into more-change-email-logs
786e5f2
* origin/main: (26 commits)
Drop es indexes before reindexing (#12762)
Audius Protocol v0.7.222
Audius Client (Web and Mobile) v1.5.148
Setup elasticsearch for bridge in local dev (#12760)
Fix share profile drawer issue (#12751)
Fix E2E tests by fixing remix notification (#12748)
Fix sort order (#12758)
Tweak your coins skeletons (#12756)
[PE-6664] Fix small screen coin page layout issues (#12754)
Fix responsiveness on AUDIO page (#12755)
Show correct image in user badge stack on AllCoinsPage (#12753)
Invalidate 'userCoins' query after swap (#12752)
[PE-6668] Update add external wallets button to send to sign up if user is not signed in (#12750)
Small lint fix (#12749)
Audius Protocol v0.7.221
Added loaded addresses to account_keys in user bank indexer (#12747)
Update postgres version in local dev to 15.5 (#12746)
[PE-6657] Artist coin leaderboard card (#12734)
Update qr code colors (#12741)
[PE-6677] Fix user badge artist coins (#12745)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dylanjeffersdylanjeffersdylanjeffers approved these changes
@dharit-tandharit-tanAwaiting requested review from dharit-tan
@Kyle-ShanksKyle-ShanksAwaiting requested review from Kyle-Shanks

+1 more reviewer

@faridsalaufaridsalaufaridsalau left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

size/L

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@DejayJD@dylanjeffers@faridsalau

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[PE-6657] Artist coin leaderboard card by DejayJD · Pull Request #12734 · AudiusProject/apps · GitHub
Skip to content
[PE-6657] Artist coin leaderboard card - #12734
Merged
DejayJD merged 10 commits into
mainfrom 
jd/leaderboard-card-web
Aug 15, 2025
Merged
[PE-6657] Artist coin leaderboard card#12734
DejayJD merged 10 commits into
mainfrom 
jd/leaderboard-card-web
Conversation
@DejayJD
@DejayJDDejayJD
commented
Aug 14, 2025

Copy link


Copy Markdown

Contributor
Description
2025-08-14 13 20 24
  • Moves the leaderboard feature to a card UI
  • Fixed the leaderboard modal not showing decimals
  • Tweaked token balance hooks to return a locale readable balance alongside other balance
How Has This Been Tested?
web:stage - tested in small and big browser sizes, tested with bonk and audio, tested loading state with TQ tools
@DejayJD
DejayJD
requested review from
Kyle-Shanks, dharit-tan, dylanjeffers and faridsalau
and removed request for
dylanjeffersAugust 14, 2025 18:22
faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
Outdated

faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
Outdated

faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
 return {
 userId: decodeHashId(member.userId) ?? 0,
 balance: member.balance,
 balanceLocaleString: balanceFD.toLocaleString('en-US', {
@faridsalaufaridsalauAug 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel like we should probably be using packages/common/src/store/ui/buy-sell/useTokenAmountFormatting.ts here?
@DejayJDDejayJDAug 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My goal is actually to eventually consolidate that hook!

I just don't have that as part of that PR. Ideally that hook doesn't exist as it's own hook; the formatted value should either be baked into the slice, or as a reusable selector that we pass onto this hook (leaning towards selector but again, more todo here)

Let me add a todo here actually
faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/web/src/pages/asset-detail-page/components/AssetLeaderboardCard.tsx

Comment on lines

+85
 to 
+92

 <AvatarSkeleton css={{ marginLeft: '0' }} />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
@faridsalaufaridsalauAug 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could just map over an arr
dylanjeffers
dylanjeffers
approved these changes
Aug 14, 2025
View reviewed changes
@dylanjeffersdylanjeffers
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dope
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
Outdated

Comment threadpackages/web/src/pages/asset-detail-page/components/AssetLeaderboardCard.tsx
Outdated

} from '@audius/harmony'
import { useDispatch } from 'react-redux'

import { UserProfilePictureList } from 'components/notification/Notification/components/UserProfilePictureList'
@dylanjeffersdylanjeffersAug 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one day we move this to a common space :D
@DejayJDDejayJDAug 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao I didnt even realize this was coming from such a weird import. Should be able to move in this PR without too much effort
@DejayJDDejayJDAug 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f013b4a
@changeset-bot
changeset-botBot
commented
Aug 14, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 612b4b6
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@DejayJD
DejayJD
enabled auto-merge (squash)
August 14, 2025 22:18
@DejayJD
DejayJD
disabled auto-merge
August 15, 2025 03:16
@DejayJD
DejayJD
merged commit e4241dc
into
mainAug 15, 2025

3 of 5 checks passed

@DejayJD
DejayJD
deleted the

jd/leaderboard-card-web

branch
August 15, 2025 03:16
audius-infra pushed a commit
that referenced
this pull request
Aug 16, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.148
55deb3c
[c667cb7] Fix share profile drawer issue (#12751) JD Francis
[65212e8] Fix E2E tests by fixing remix notification (#12748) Marcus Pasell
[42bb9d1] Tweak your coins skeletons (#12756) JD Francis
[f20aa78] [PE-6664] Fix small screen coin page layout issues (#12754) JD Francis
[3d82588] Fix responsiveness on AUDIO page (#12755) Farid Salau
[1f9434e] Show correct image in user badge stack on AllCoinsPage (#12753) Farid Salau
[270363a] Invalidate 'userCoins' query after swap (#12752) Farid Salau
[11b6310] [PE-6668] Update add external wallets button to send to sign up if user is not signed in (#12750) KJ
[fdb8cc9] Small lint fix (#12749) JD Francis
[e4241dc] [PE-6657] Artist coin leaderboard card (#12734) JD Francis
[edac449] Update qr code colors (#12741) Dylan Jeffers
[02b5d48] [PE-6677] Fix user badge artist coins (#12745) Dylan Jeffers
[f631cf3] Fix coin options (#12743) Dylan Jeffers
[d0ad5ae] [PE-6667] Fix token balance swap issues (#12738) JD Francis
[5c2570c] Fix listening history (#12731) Randy Schott
[d42fb2e] [PE-6636] Add receive-tokens modal. (#12725) Dylan Jeffers
[5841688] Adjust remix contest timezone (#12722) Dylan Jeffers
[b883712] Fix buy-sell modal error handling and UI improvements (#12728) Farid Salau
[7f4cb6a] Remove original param for download (#12686) Ray Jacobson
[4f88de6] [PE-6638] Update coin leaderboard user list to handle long user names (#12730) KJ
[1fb49f5] [PE-6588] Add downloads available section to search/explore (#12723) Randy Schott
[19a745e] Revert "Speed up sdk build by only building for web and native (#12391)" (#12727) Dylan Jeffers
[ddfbaa5] [PE-6621] Connected wallets UI (#12697) JD Francis
[bb58d64] Clean up unnecessary amplitude events (#12684) JD Francis
[76fd651] [PE-6651, PE-6647, PE-6634, PE-6646] Artist Coin QA 2 (#12724) KJ
[b1aec05] [PE-6637, PE-6639] Artist Coin QA 1 (#12721) KJ
[e161b05] Speed up sdk build by only building for web and native (#12391) Dylan Jeffers
[5ba4590] [PE-6608] Fix persistence of recent searches on web (#12718) Randy Schott
[d4d4a39] Web Search/Explore QA fixes (#12717) Randy Schott
[d75ae2e] [PE-6643] Add unauth state for Wallet pages (#12714) Farid Salau
[31e7687] Update Asset Detail Pages to use proper data (#12713) Farid Salau
[b50ccef] Fix trending playlists playback on web (#12712) Randy Schott
[74e5991] [QA-2163] Delete collections with tan-query (#12700) Dylan Jeffers
[515f884] Fix left-align page container (#12711) Dylan Jeffers
[3554bb2] [PE-6656] Fix dupe playlist track uids (#12715) JD Francis
[39a3f54] Add support for oembeds (#12692) Marcus Pasell
[3ccbd99] Improve mobile profile refresh (#12699) Dylan Jeffers
[b186d9b] [PE-6541] Update UserBadges to display top token (#12710) KJ
[cd468d8] [QA-2202] Improve podcast support (#12698) Dylan Jeffers
[1b2f943] add best of section back to mobile if we aren't showing new explore content (#12708) Randy Schott
[6e8f43b] Fix skeletons for title/artist on track tiles (#12707) Randy Schott
[f626163] [PE-6605] Add dropdown menu to artist coins (#12705) Farid Salau
[36e2a6a] Revert mobile Artwork changes (#12706) Farid Salau
schottra added a commit
that referenced
this pull request
Aug 18, 2025
@schottra
Merge remote-tracking branch 'origin/main' into search-explore-fixes
b0ebd89
* origin/main: (25 commits)
Drop es indexes before reindexing (#12762)
Audius Protocol v0.7.222
Audius Client (Web and Mobile) v1.5.148
Setup elasticsearch for bridge in local dev (#12760)
Fix share profile drawer issue (#12751)
Fix E2E tests by fixing remix notification (#12748)
Fix sort order (#12758)
Tweak your coins skeletons (#12756)
[PE-6664] Fix small screen coin page layout issues (#12754)
Fix responsiveness on AUDIO page (#12755)
Show correct image in user badge stack on AllCoinsPage (#12753)
Invalidate 'userCoins' query after swap (#12752)
[PE-6668] Update add external wallets button to send to sign up if user is not signed in (#12750)
Small lint fix (#12749)
Audius Protocol v0.7.221
Added loaded addresses to account_keys in user bank indexer (#12747)
Update postgres version in local dev to 15.5 (#12746)
[PE-6657] Artist coin leaderboard card (#12734)
Update qr code colors (#12741)
[PE-6677] Fix user badge artist coins (#12745)
...
schottra added a commit
that referenced
this pull request
Aug 18, 2025
@schottra
Merge remote-tracking branch 'origin/main' into more-change-email-logs
786e5f2
* origin/main: (26 commits)
Drop es indexes before reindexing (#12762)
Audius Protocol v0.7.222
Audius Client (Web and Mobile) v1.5.148
Setup elasticsearch for bridge in local dev (#12760)
Fix share profile drawer issue (#12751)
Fix E2E tests by fixing remix notification (#12748)
Fix sort order (#12758)
Tweak your coins skeletons (#12756)
[PE-6664] Fix small screen coin page layout issues (#12754)
Fix responsiveness on AUDIO page (#12755)
Show correct image in user badge stack on AllCoinsPage (#12753)
Invalidate 'userCoins' query after swap (#12752)
[PE-6668] Update add external wallets button to send to sign up if user is not signed in (#12750)
Small lint fix (#12749)
Audius Protocol v0.7.221
Added loaded addresses to account_keys in user bank indexer (#12747)
Update postgres version in local dev to 15.5 (#12746)
[PE-6657] Artist coin leaderboard card (#12734)
Update qr code colors (#12741)
[PE-6677] Fix user badge artist coins (#12745)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dylanjeffersdylanjeffersdylanjeffers approved these changes
@dharit-tandharit-tanAwaiting requested review from dharit-tan
@Kyle-ShanksKyle-ShanksAwaiting requested review from Kyle-Shanks

+1 more reviewer

@faridsalaufaridsalaufaridsalau left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

size/L

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@DejayJD@dylanjeffers@faridsalau

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[PE-6657] Artist coin leaderboard card by DejayJD · Pull Request #12734 · AudiusProject/apps · GitHub
Skip to content
[PE-6657] Artist coin leaderboard card - #12734
Merged
DejayJD merged 10 commits into
mainfrom 
jd/leaderboard-card-web
Aug 15, 2025
Merged
[PE-6657] Artist coin leaderboard card#12734
DejayJD merged 10 commits into
mainfrom 
jd/leaderboard-card-web
Conversation
@DejayJD
@DejayJDDejayJD
commented
Aug 14, 2025

Copy link


Copy Markdown

Contributor
Description
2025-08-14 13 20 24
  • Moves the leaderboard feature to a card UI
  • Fixed the leaderboard modal not showing decimals
  • Tweaked token balance hooks to return a locale readable balance alongside other balance
How Has This Been Tested?
web:stage - tested in small and big browser sizes, tested with bonk and audio, tested loading state with TQ tools
@DejayJD
DejayJD
requested review from
Kyle-Shanks, dharit-tan, dylanjeffers and faridsalau
and removed request for
dylanjeffersAugust 14, 2025 18:22
faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
Outdated

faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
Outdated

faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
 return {
 userId: decodeHashId(member.userId) ?? 0,
 balance: member.balance,
 balanceLocaleString: balanceFD.toLocaleString('en-US', {
@faridsalaufaridsalauAug 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel like we should probably be using packages/common/src/store/ui/buy-sell/useTokenAmountFormatting.ts here?
@DejayJDDejayJDAug 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My goal is actually to eventually consolidate that hook!

I just don't have that as part of that PR. Ideally that hook doesn't exist as it's own hook; the formatted value should either be baked into the slice, or as a reusable selector that we pass onto this hook (leaning towards selector but again, more todo here)

Let me add a todo here actually
faridsalau
faridsalau
reviewed
Aug 14, 2025
View reviewed changes
Comment threadpackages/web/src/pages/asset-detail-page/components/AssetLeaderboardCard.tsx

Comment on lines

+85
 to 
+92

 <AvatarSkeleton css={{ marginLeft: '0' }} />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
 <AvatarSkeleton />
@faridsalaufaridsalauAug 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could just map over an arr
dylanjeffers
dylanjeffers
approved these changes
Aug 14, 2025
View reviewed changes
@dylanjeffersdylanjeffers
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dope
Comment threadpackages/common/src/api/tan-query/coins/useArtistCoinMembers.ts
Outdated

Comment threadpackages/web/src/pages/asset-detail-page/components/AssetLeaderboardCard.tsx
Outdated

} from '@audius/harmony'
import { useDispatch } from 'react-redux'

import { UserProfilePictureList } from 'components/notification/Notification/components/UserProfilePictureList'
@dylanjeffersdylanjeffersAug 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one day we move this to a common space :D
@DejayJDDejayJDAug 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao I didnt even realize this was coming from such a weird import. Should be able to move in this PR without too much effort
@DejayJDDejayJDAug 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f013b4a
@changeset-bot
changeset-botBot
commented
Aug 14, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 612b4b6
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@DejayJD
DejayJD
enabled auto-merge (squash)
August 14, 2025 22:18
@DejayJD
DejayJD
disabled auto-merge
August 15, 2025 03:16
@DejayJD
DejayJD
merged commit e4241dc
into
mainAug 15, 2025

3 of 5 checks passed

@DejayJD
DejayJD
deleted the

jd/leaderboard-card-web

branch
August 15, 2025 03:16
audius-infra pushed a commit
that referenced
this pull request
Aug 16, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.148
55deb3c
[c667cb7] Fix share profile drawer issue (#12751) JD Francis
[65212e8] Fix E2E tests by fixing remix notification (#12748) Marcus Pasell
[42bb9d1] Tweak your coins skeletons (#12756) JD Francis
[f20aa78] [PE-6664] Fix small screen coin page layout issues (#12754) JD Francis
[3d82588] Fix responsiveness on AUDIO page (#12755) Farid Salau
[1f9434e] Show correct image in user badge stack on AllCoinsPage (#12753) Farid Salau
[270363a] Invalidate 'userCoins' query after swap (#12752) Farid Salau
[11b6310] [PE-6668] Update add external wallets button to send to sign up if user is not signed in (#12750) KJ
[fdb8cc9] Small lint fix (#12749) JD Francis
[e4241dc] [PE-6657] Artist coin leaderboard card (#12734) JD Francis
[edac449] Update qr code colors (#12741) Dylan Jeffers
[02b5d48] [PE-6677] Fix user badge artist coins (#12745) Dylan Jeffers
[f631cf3] Fix coin options (#12743) Dylan Jeffers
[d0ad5ae] [PE-6667] Fix token balance swap issues (#12738) JD Francis
[5c2570c] Fix listening history (#12731) Randy Schott
[d42fb2e] [PE-6636] Add receive-tokens modal. (#12725) Dylan Jeffers
[5841688] Adjust remix contest timezone (#12722) Dylan Jeffers
[b883712] Fix buy-sell modal error handling and UI improvements (#12728) Farid Salau
[7f4cb6a] Remove original param for download (#12686) Ray Jacobson
[4f88de6] [PE-6638] Update coin leaderboard user list to handle long user names (#12730) KJ
[1fb49f5] [PE-6588] Add downloads available section to search/explore (#12723) Randy Schott
[19a745e] Revert "Speed up sdk build by only building for web and native (#12391)" (#12727) Dylan Jeffers
[ddfbaa5] [PE-6621] Connected wallets UI (#12697) JD Francis
[bb58d64] Clean up unnecessary amplitude events (#12684) JD Francis
[76fd651] [PE-6651, PE-6647, PE-6634, PE-6646] Artist Coin QA 2 (#12724) KJ
[b1aec05] [PE-6637, PE-6639] Artist Coin QA 1 (#12721) KJ
[e161b05] Speed up sdk build by only building for web and native (#12391) Dylan Jeffers
[5ba4590] [PE-6608] Fix persistence of recent searches on web (#12718) Randy Schott
[d4d4a39] Web Search/Explore QA fixes (#12717) Randy Schott
[d75ae2e] [PE-6643] Add unauth state for Wallet pages (#12714) Farid Salau
[31e7687] Update Asset Detail Pages to use proper data (#12713) Farid Salau
[b50ccef] Fix trending playlists playback on web (#12712) Randy Schott
[74e5991] [QA-2163] Delete collections with tan-query (#12700) Dylan Jeffers
[515f884] Fix left-align page container (#12711) Dylan Jeffers
[3554bb2] [PE-6656] Fix dupe playlist track uids (#12715) JD Francis
[39a3f54] Add support for oembeds (#12692) Marcus Pasell
[3ccbd99] Improve mobile profile refresh (#12699) Dylan Jeffers
[b186d9b] [PE-6541] Update UserBadges to display top token (#12710) KJ
[cd468d8] [QA-2202] Improve podcast support (#12698) Dylan Jeffers
[1b2f943] add best of section back to mobile if we aren't showing new explore content (#12708) Randy Schott
[6e8f43b] Fix skeletons for title/artist on track tiles (#12707) Randy Schott
[f626163] [PE-6605] Add dropdown menu to artist coins (#12705) Farid Salau
[36e2a6a] Revert mobile Artwork changes (#12706) Farid Salau
schottra added a commit
that referenced
this pull request
Aug 18, 2025
@schottra
Merge remote-tracking branch 'origin/main' into search-explore-fixes
b0ebd89
* origin/main: (25 commits)
Drop es indexes before reindexing (#12762)
Audius Protocol v0.7.222
Audius Client (Web and Mobile) v1.5.148
Setup elasticsearch for bridge in local dev (#12760)
Fix share profile drawer issue (#12751)
Fix E2E tests by fixing remix notification (#12748)
Fix sort order (#12758)
Tweak your coins skeletons (#12756)
[PE-6664] Fix small screen coin page layout issues (#12754)
Fix responsiveness on AUDIO page (#12755)
Show correct image in user badge stack on AllCoinsPage (#12753)
Invalidate 'userCoins' query after swap (#12752)
[PE-6668] Update add external wallets button to send to sign up if user is not signed in (#12750)
Small lint fix (#12749)
Audius Protocol v0.7.221
Added loaded addresses to account_keys in user bank indexer (#12747)
Update postgres version in local dev to 15.5 (#12746)
[PE-6657] Artist coin leaderboard card (#12734)
Update qr code colors (#12741)
[PE-6677] Fix user badge artist coins (#12745)
...
schottra added a commit
that referenced
this pull request
Aug 18, 2025
@schottra
Merge remote-tracking branch 'origin/main' into more-change-email-logs
786e5f2
* origin/main: (26 commits)
Drop es indexes before reindexing (#12762)
Audius Protocol v0.7.222
Audius Client (Web and Mobile) v1.5.148
Setup elasticsearch for bridge in local dev (#12760)
Fix share profile drawer issue (#12751)
Fix E2E tests by fixing remix notification (#12748)
Fix sort order (#12758)
Tweak your coins skeletons (#12756)
[PE-6664] Fix small screen coin page layout issues (#12754)
Fix responsiveness on AUDIO page (#12755)
Show correct image in user badge stack on AllCoinsPage (#12753)
Invalidate 'userCoins' query after swap (#12752)
[PE-6668] Update add external wallets button to send to sign up if user is not signed in (#12750)
Small lint fix (#12749)
Audius Protocol v0.7.221
Added loaded addresses to account_keys in user bank indexer (#12747)
Update postgres version in local dev to 15.5 (#12746)
[PE-6657] Artist coin leaderboard card (#12734)
Update qr code colors (#12741)
[PE-6677] Fix user badge artist coins (#12745)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dylanjeffersdylanjeffersdylanjeffers approved these changes
@dharit-tandharit-tanAwaiting requested review from dharit-tan
@Kyle-ShanksKyle-ShanksAwaiting requested review from Kyle-Shanks

+1 more reviewer

@faridsalaufaridsalaufaridsalau left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

size/L

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@DejayJD@dylanjeffers@faridsalau