Skip to content

[PE-6709|PE-6710|PE-6707] Artist coin QA pass - #12761

Merged
DejayJD merged 4 commits into
mainfrom
jd/coins-qa-pass-1
Aug 18, 2025
Merged

[PE-6709|PE-6710|PE-6707] Artist coin QA pass#12761
DejayJD merged 4 commits into
mainfrom
jd/coins-qa-pass-1

Conversation

@DejayJD

@DejayJDDejayJD commented Aug 15, 2025

Copy link
Copy Markdown
Contributor

Description

Combined 3 QA items into one PR

  • PE-6709 - Fix swap balances accounting for your external wallets - added a prop to useTokenBalance to ignore external wallets
  • PE-6710 - Fix optimistic updates after swaps - invalidateQueries doesnt seem to be timing out right, I've seen it work a handful of times but I think its a race condition. Swapped it to a calculated mutation instead
  • PE-6707 - Link external wallet infinite spinning - Fixed by using isLoading instead of isPending, bit of a tan-query quirk here where if your queryFn never runs you get isPending forever. isLoading is the more correct status to use here since

How Has This Been Tested?

web:stage

  • swap modal shows internal wallet balance
  • unauthed user shows external wallets as expected
  • did convert flow, mutations look good
    TODO: test buy & sell flows as well
    2025-08-15 17 15 23

@changeset-bot

changeset-botBot commented Aug 15, 2025•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 13c8cca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DejayJD
DejayJD requested review from a team, dylanjeffers and faridsalauAugust 15, 2025 22:18
dylanjeffers
dylanjeffers approved these changes Aug 18, 2025
View reviewed changes

@dylanjeffersdylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff

Comment threadpackages/common/src/api/tan-query/wallets/useTokenBalance.ts
select: (userCoinWithAccounts) => {
if (!userCoinWithAccounts) return null
const { balance: balanceNumber, decimals } = userCoinWithAccounts
select: (aggregateCoinAccounts) => {

@dylanjeffersdylanjeffersAug 18, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@DejayJD
DejayJD merged commit e2661ca into mainAug 18, 2025
7 of 10 checks passed
@DejayJD
DejayJD deleted the jd/coins-qa-pass-1 branch August 18, 2025 21:42
audius-infra pushed a commit that referenced this pull request Aug 23, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.149
a9364e4
[b7a7478] [PE-6729|PE-6728|PE-6724] Various minor artist coin tweaks (#12782) JD Francis
[48903d3] [PE-6744] Connect ExternalWalletsCard to ExternalWalletsScreen on mobile (#12793) KJ
[8dff4f9] OEmbed: Don't use OG url (#12792) Marcus Pasell
[76aae83] [QA-2290] Mobile USDC purchase recovery (#12791) Reed
[e99bbc8] Fix buy-audio wrong change formatting (#12787) Reed
[9d33032] $AUDIO balance includes staked (#12790) Reed
[a15f37e] Bump version of Jupiter price API (#12789) Farid Salau
[8cdd634] [PE-6717] Update default buy/sell token pair based on path (#12788) KJ
[b1792fb] [PE-6721] Fix badge hover card in left nav profile (#12784) Reed
[e656e9f] Update user bank deriver to use artist coins endpoint (#12785) Farid Salau
[52f3c35] Allow direct DBC swaps (#12776) Farid Salau
[2e341b2] Remove hardcoded decimals values from Swap flow (#12763) Farid Salau
[5e4a021] [PE-6735, PE-6738, PE-6739] Updates to the mobile coins screens (#12783) KJ
[930bbe8] [QA-2182] Fix selected tip reaction (#12703) Dylan Jeffers
[80085fe] [QA-1076] Fix notification drawer top inset (#12704) Dylan Jeffers
[c93ad60] [PE-6660] Add new send tokens modal flow (#12777) Dylan Jeffers
[571711c] [PE-6732, PE-6733, PE-6734, PE-6517] Add mobile AllCoinsScreen and CoinDetailsScreen (#12775) KJ
[61aed02] Drop track tile on upload complete screen (#12780) Dylan Jeffers
[881cd6c] [PE-6725] Remove ai-attribution from uploadTrack e2e test (#12779) Reed
[b799ee3] Fix types and type safety in useConnectedWallets, useAudioBalance, useWalletAudioBalance, and useWalletAudioBalances (#12683) Marcus Pasell
[629d200] [PE-6714] Only show add cash when no USDC balance (#12774) Reed
[041f71e] [PE-6670] Redo discord flow with OAuth (#12772) JD Francis
[22e7d18] [PE-6582] Fix mobile musical key filter (#12768) Dylan Jeffers
[8af0b47] [PE-6726] Mobile Search QA (#12767) Dylan Jeffers
[e2661ca] [PE-6709|PE-6710|PE-6707] Artist coin QA pass (#12761) JD Francis
[935c054] update b challenge (#12764) Randy Schott
[e32b36b] [PE-6676] Improve mobile explore content performance (#12739) Dylan Jeffers
[246a276] [PE-6632] Fix selected category display for mobile web search/explore (#12737) Randy Schott
[d155e23] Fix receive modal spacing (#12759) Reed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dylanjeffersdylanjeffersdylanjeffers approved these changes
@faridsalaufaridsalauAwaiting requested review from faridsalau

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[PE-6709|PE-6710|PE-6707] Artist coin QA pass by DejayJD · Pull Request #12761 · AudiusProject/apps · GitHub
Skip to content
[PE-6709|PE-6710|PE-6707] Artist coin QA pass - #12761
Merged
DejayJD merged 4 commits into
mainfrom 
jd/coins-qa-pass-1
Aug 18, 2025
Merged
[PE-6709|PE-6710|PE-6707] Artist coin QA pass#12761
DejayJD merged 4 commits into
mainfrom 
jd/coins-qa-pass-1
Conversation
@DejayJD
@DejayJDDejayJD
commented
Aug 15, 2025

Copy link


Copy Markdown

Contributor
Description
Combined 3 QA items into one PR
  • PE-6709 - Fix swap balances accounting for your external wallets - added a prop to useTokenBalance to ignore external wallets
  • PE-6710 - Fix optimistic updates after swaps - invalidateQueries doesnt seem to be timing out right, I've seen it work a handful of times but I think its a race condition. Swapped it to a calculated mutation instead
  • PE-6707 - Link external wallet infinite spinning - Fixed by using isLoading instead of isPending, bit of a tan-query quirk here where if your queryFn never runs you get isPending forever. isLoading is the more correct status to use here since
How Has This Been Tested?
web:stage
  • swap modal shows internal wallet balance
  • unauthed user shows external wallets as expected
  • did convert flow, mutations look good
    
TODO: test buy & sell flows as well
    2025-08-15 17 15 23
@changeset-bot
changeset-botBot
commented
Aug 15, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 13c8cca
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@DejayJD
DejayJD
requested review from
a team, dylanjeffers and faridsalauAugust 15, 2025 22:18
dylanjeffers
dylanjeffers
approved these changes
Aug 18, 2025
View reviewed changes
@dylanjeffersdylanjeffers
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff
Comment threadpackages/common/src/api/tan-query/wallets/useTokenBalance.ts
 select: (userCoinWithAccounts) => {
 if (!userCoinWithAccounts) return null
 const { balance: balanceNumber, decimals } = userCoinWithAccounts
 select: (aggregateCoinAccounts) => {
@dylanjeffersdylanjeffersAug 18, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice
@DejayJD
DejayJD
merged commit e2661ca
into
mainAug 18, 2025

7 of 10 checks passed

@DejayJD
DejayJD
deleted the

jd/coins-qa-pass-1

branch
August 18, 2025 21:42
audius-infra pushed a commit
that referenced
this pull request
Aug 23, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.149
a9364e4
[b7a7478] [PE-6729|PE-6728|PE-6724] Various minor artist coin tweaks (#12782) JD Francis
[48903d3] [PE-6744] Connect ExternalWalletsCard to ExternalWalletsScreen on mobile (#12793) KJ
[8dff4f9] OEmbed: Don't use OG url (#12792) Marcus Pasell
[76aae83] [QA-2290] Mobile USDC purchase recovery (#12791) Reed
[e99bbc8] Fix buy-audio wrong change formatting (#12787) Reed
[9d33032] $AUDIO balance includes staked (#12790) Reed
[a15f37e] Bump version of Jupiter price API (#12789) Farid Salau
[8cdd634] [PE-6717] Update default buy/sell token pair based on path (#12788) KJ
[b1792fb] [PE-6721] Fix badge hover card in left nav profile (#12784) Reed
[e656e9f] Update user bank deriver to use artist coins endpoint (#12785) Farid Salau
[52f3c35] Allow direct DBC swaps (#12776) Farid Salau
[2e341b2] Remove hardcoded decimals values from Swap flow (#12763) Farid Salau
[5e4a021] [PE-6735, PE-6738, PE-6739] Updates to the mobile coins screens (#12783) KJ
[930bbe8] [QA-2182] Fix selected tip reaction (#12703) Dylan Jeffers
[80085fe] [QA-1076] Fix notification drawer top inset (#12704) Dylan Jeffers
[c93ad60] [PE-6660] Add new send tokens modal flow (#12777) Dylan Jeffers
[571711c] [PE-6732, PE-6733, PE-6734, PE-6517] Add mobile AllCoinsScreen and CoinDetailsScreen (#12775) KJ
[61aed02] Drop track tile on upload complete screen (#12780) Dylan Jeffers
[881cd6c] [PE-6725] Remove ai-attribution from uploadTrack e2e test (#12779) Reed
[b799ee3] Fix types and type safety in useConnectedWallets, useAudioBalance, useWalletAudioBalance, and useWalletAudioBalances (#12683) Marcus Pasell
[629d200] [PE-6714] Only show add cash when no USDC balance (#12774) Reed
[041f71e] [PE-6670] Redo discord flow with OAuth (#12772) JD Francis
[22e7d18] [PE-6582] Fix mobile musical key filter (#12768) Dylan Jeffers
[8af0b47] [PE-6726] Mobile Search QA (#12767) Dylan Jeffers
[e2661ca] [PE-6709|PE-6710|PE-6707] Artist coin QA pass (#12761) JD Francis
[935c054] update b challenge (#12764) Randy Schott
[e32b36b] [PE-6676] Improve mobile explore content performance (#12739) Dylan Jeffers
[246a276] [PE-6632] Fix selected category display for mobile web search/explore (#12737) Randy Schott
[d155e23] Fix receive modal spacing (#12759) Reed
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dylanjeffersdylanjeffersdylanjeffers approved these changes
@faridsalaufaridsalauAwaiting requested review from faridsalau

Assignees


No one assigned


Labels

size/L

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[PE-6709|PE-6710|PE-6707] Artist coin QA pass by DejayJD · Pull Request #12761 · AudiusProject/apps · GitHub
Skip to content
[PE-6709|PE-6710|PE-6707] Artist coin QA pass - #12761
Merged
DejayJD merged 4 commits into
mainfrom 
jd/coins-qa-pass-1
Aug 18, 2025
Merged
[PE-6709|PE-6710|PE-6707] Artist coin QA pass#12761
DejayJD merged 4 commits into
mainfrom 
jd/coins-qa-pass-1
Conversation
@DejayJD
@DejayJDDejayJD
commented
Aug 15, 2025

Copy link


Copy Markdown

Contributor
Description
Combined 3 QA items into one PR
  • PE-6709 - Fix swap balances accounting for your external wallets - added a prop to useTokenBalance to ignore external wallets
  • PE-6710 - Fix optimistic updates after swaps - invalidateQueries doesnt seem to be timing out right, I've seen it work a handful of times but I think its a race condition. Swapped it to a calculated mutation instead
  • PE-6707 - Link external wallet infinite spinning - Fixed by using isLoading instead of isPending, bit of a tan-query quirk here where if your queryFn never runs you get isPending forever. isLoading is the more correct status to use here since
How Has This Been Tested?
web:stage
  • swap modal shows internal wallet balance
  • unauthed user shows external wallets as expected
  • did convert flow, mutations look good
    
TODO: test buy & sell flows as well
    2025-08-15 17 15 23
@changeset-bot
changeset-botBot
commented
Aug 15, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 13c8cca
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@DejayJD
DejayJD
requested review from
a team, dylanjeffers and faridsalauAugust 15, 2025 22:18
dylanjeffers
dylanjeffers
approved these changes
Aug 18, 2025
View reviewed changes
@dylanjeffersdylanjeffers
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff
Comment threadpackages/common/src/api/tan-query/wallets/useTokenBalance.ts
 select: (userCoinWithAccounts) => {
 if (!userCoinWithAccounts) return null
 const { balance: balanceNumber, decimals } = userCoinWithAccounts
 select: (aggregateCoinAccounts) => {
@dylanjeffersdylanjeffersAug 18, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice
@DejayJD
DejayJD
merged commit e2661ca
into
mainAug 18, 2025

7 of 10 checks passed

@DejayJD
DejayJD
deleted the

jd/coins-qa-pass-1

branch
August 18, 2025 21:42
audius-infra pushed a commit
that referenced
this pull request
Aug 23, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.149
a9364e4
[b7a7478] [PE-6729|PE-6728|PE-6724] Various minor artist coin tweaks (#12782) JD Francis
[48903d3] [PE-6744] Connect ExternalWalletsCard to ExternalWalletsScreen on mobile (#12793) KJ
[8dff4f9] OEmbed: Don't use OG url (#12792) Marcus Pasell
[76aae83] [QA-2290] Mobile USDC purchase recovery (#12791) Reed
[e99bbc8] Fix buy-audio wrong change formatting (#12787) Reed
[9d33032] $AUDIO balance includes staked (#12790) Reed
[a15f37e] Bump version of Jupiter price API (#12789) Farid Salau
[8cdd634] [PE-6717] Update default buy/sell token pair based on path (#12788) KJ
[b1792fb] [PE-6721] Fix badge hover card in left nav profile (#12784) Reed
[e656e9f] Update user bank deriver to use artist coins endpoint (#12785) Farid Salau
[52f3c35] Allow direct DBC swaps (#12776) Farid Salau
[2e341b2] Remove hardcoded decimals values from Swap flow (#12763) Farid Salau
[5e4a021] [PE-6735, PE-6738, PE-6739] Updates to the mobile coins screens (#12783) KJ
[930bbe8] [QA-2182] Fix selected tip reaction (#12703) Dylan Jeffers
[80085fe] [QA-1076] Fix notification drawer top inset (#12704) Dylan Jeffers
[c93ad60] [PE-6660] Add new send tokens modal flow (#12777) Dylan Jeffers
[571711c] [PE-6732, PE-6733, PE-6734, PE-6517] Add mobile AllCoinsScreen and CoinDetailsScreen (#12775) KJ
[61aed02] Drop track tile on upload complete screen (#12780) Dylan Jeffers
[881cd6c] [PE-6725] Remove ai-attribution from uploadTrack e2e test (#12779) Reed
[b799ee3] Fix types and type safety in useConnectedWallets, useAudioBalance, useWalletAudioBalance, and useWalletAudioBalances (#12683) Marcus Pasell
[629d200] [PE-6714] Only show add cash when no USDC balance (#12774) Reed
[041f71e] [PE-6670] Redo discord flow with OAuth (#12772) JD Francis
[22e7d18] [PE-6582] Fix mobile musical key filter (#12768) Dylan Jeffers
[8af0b47] [PE-6726] Mobile Search QA (#12767) Dylan Jeffers
[e2661ca] [PE-6709|PE-6710|PE-6707] Artist coin QA pass (#12761) JD Francis
[935c054] update b challenge (#12764) Randy Schott
[e32b36b] [PE-6676] Improve mobile explore content performance (#12739) Dylan Jeffers
[246a276] [PE-6632] Fix selected category display for mobile web search/explore (#12737) Randy Schott
[d155e23] Fix receive modal spacing (#12759) Reed
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dylanjeffersdylanjeffersdylanjeffers approved these changes
@faridsalaufaridsalauAwaiting requested review from faridsalau

Assignees


No one assigned


Labels

size/L

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[PE-6709|PE-6710|PE-6707] Artist coin QA pass by DejayJD · Pull Request #12761 · AudiusProject/apps · GitHub
Skip to content
[PE-6709|PE-6710|PE-6707] Artist coin QA pass - #12761
Merged
DejayJD merged 4 commits into
mainfrom 
jd/coins-qa-pass-1
Aug 18, 2025
Merged
[PE-6709|PE-6710|PE-6707] Artist coin QA pass#12761
DejayJD merged 4 commits into
mainfrom 
jd/coins-qa-pass-1
Conversation
@DejayJD
@DejayJDDejayJD
commented
Aug 15, 2025

Copy link


Copy Markdown

Contributor
Description
Combined 3 QA items into one PR
  • PE-6709 - Fix swap balances accounting for your external wallets - added a prop to useTokenBalance to ignore external wallets
  • PE-6710 - Fix optimistic updates after swaps - invalidateQueries doesnt seem to be timing out right, I've seen it work a handful of times but I think its a race condition. Swapped it to a calculated mutation instead
  • PE-6707 - Link external wallet infinite spinning - Fixed by using isLoading instead of isPending, bit of a tan-query quirk here where if your queryFn never runs you get isPending forever. isLoading is the more correct status to use here since
How Has This Been Tested?
web:stage
  • swap modal shows internal wallet balance
  • unauthed user shows external wallets as expected
  • did convert flow, mutations look good
    
TODO: test buy & sell flows as well
    2025-08-15 17 15 23
@changeset-bot
changeset-botBot
commented
Aug 15, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 13c8cca
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@DejayJD
DejayJD
requested review from
a team, dylanjeffers and faridsalauAugust 15, 2025 22:18
dylanjeffers
dylanjeffers
approved these changes
Aug 18, 2025
View reviewed changes
@dylanjeffersdylanjeffers
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff
Comment threadpackages/common/src/api/tan-query/wallets/useTokenBalance.ts
 select: (userCoinWithAccounts) => {
 if (!userCoinWithAccounts) return null
 const { balance: balanceNumber, decimals } = userCoinWithAccounts
 select: (aggregateCoinAccounts) => {
@dylanjeffersdylanjeffersAug 18, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice
@DejayJD
DejayJD
merged commit e2661ca
into
mainAug 18, 2025

7 of 10 checks passed

@DejayJD
DejayJD
deleted the

jd/coins-qa-pass-1

branch
August 18, 2025 21:42
audius-infra pushed a commit
that referenced
this pull request
Aug 23, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.149
a9364e4
[b7a7478] [PE-6729|PE-6728|PE-6724] Various minor artist coin tweaks (#12782) JD Francis
[48903d3] [PE-6744] Connect ExternalWalletsCard to ExternalWalletsScreen on mobile (#12793) KJ
[8dff4f9] OEmbed: Don't use OG url (#12792) Marcus Pasell
[76aae83] [QA-2290] Mobile USDC purchase recovery (#12791) Reed
[e99bbc8] Fix buy-audio wrong change formatting (#12787) Reed
[9d33032] $AUDIO balance includes staked (#12790) Reed
[a15f37e] Bump version of Jupiter price API (#12789) Farid Salau
[8cdd634] [PE-6717] Update default buy/sell token pair based on path (#12788) KJ
[b1792fb] [PE-6721] Fix badge hover card in left nav profile (#12784) Reed
[e656e9f] Update user bank deriver to use artist coins endpoint (#12785) Farid Salau
[52f3c35] Allow direct DBC swaps (#12776) Farid Salau
[2e341b2] Remove hardcoded decimals values from Swap flow (#12763) Farid Salau
[5e4a021] [PE-6735, PE-6738, PE-6739] Updates to the mobile coins screens (#12783) KJ
[930bbe8] [QA-2182] Fix selected tip reaction (#12703) Dylan Jeffers
[80085fe] [QA-1076] Fix notification drawer top inset (#12704) Dylan Jeffers
[c93ad60] [PE-6660] Add new send tokens modal flow (#12777) Dylan Jeffers
[571711c] [PE-6732, PE-6733, PE-6734, PE-6517] Add mobile AllCoinsScreen and CoinDetailsScreen (#12775) KJ
[61aed02] Drop track tile on upload complete screen (#12780) Dylan Jeffers
[881cd6c] [PE-6725] Remove ai-attribution from uploadTrack e2e test (#12779) Reed
[b799ee3] Fix types and type safety in useConnectedWallets, useAudioBalance, useWalletAudioBalance, and useWalletAudioBalances (#12683) Marcus Pasell
[629d200] [PE-6714] Only show add cash when no USDC balance (#12774) Reed
[041f71e] [PE-6670] Redo discord flow with OAuth (#12772) JD Francis
[22e7d18] [PE-6582] Fix mobile musical key filter (#12768) Dylan Jeffers
[8af0b47] [PE-6726] Mobile Search QA (#12767) Dylan Jeffers
[e2661ca] [PE-6709|PE-6710|PE-6707] Artist coin QA pass (#12761) JD Francis
[935c054] update b challenge (#12764) Randy Schott
[e32b36b] [PE-6676] Improve mobile explore content performance (#12739) Dylan Jeffers
[246a276] [PE-6632] Fix selected category display for mobile web search/explore (#12737) Randy Schott
[d155e23] Fix receive modal spacing (#12759) Reed
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dylanjeffersdylanjeffersdylanjeffers approved these changes
@faridsalaufaridsalauAwaiting requested review from faridsalau

Assignees


No one assigned


Labels

size/L

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[PE-6709|PE-6710|PE-6707] Artist coin QA pass by DejayJD · Pull Request #12761 · AudiusProject/apps · GitHub
Skip to content
[PE-6709|PE-6710|PE-6707] Artist coin QA pass - #12761
Merged
DejayJD merged 4 commits into
mainfrom 
jd/coins-qa-pass-1
Aug 18, 2025
Merged
[PE-6709|PE-6710|PE-6707] Artist coin QA pass#12761
DejayJD merged 4 commits into
mainfrom 
jd/coins-qa-pass-1
Conversation
@DejayJD
@DejayJDDejayJD
commented
Aug 15, 2025

Copy link


Copy Markdown

Contributor
Description
Combined 3 QA items into one PR
  • PE-6709 - Fix swap balances accounting for your external wallets - added a prop to useTokenBalance to ignore external wallets
  • PE-6710 - Fix optimistic updates after swaps - invalidateQueries doesnt seem to be timing out right, I've seen it work a handful of times but I think its a race condition. Swapped it to a calculated mutation instead
  • PE-6707 - Link external wallet infinite spinning - Fixed by using isLoading instead of isPending, bit of a tan-query quirk here where if your queryFn never runs you get isPending forever. isLoading is the more correct status to use here since
How Has This Been Tested?
web:stage
  • swap modal shows internal wallet balance
  • unauthed user shows external wallets as expected
  • did convert flow, mutations look good
    
TODO: test buy & sell flows as well
    2025-08-15 17 15 23
@changeset-bot
changeset-botBot
commented
Aug 15, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 13c8cca
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@DejayJD
DejayJD
requested review from
a team, dylanjeffers and faridsalauAugust 15, 2025 22:18
dylanjeffers
dylanjeffers
approved these changes
Aug 18, 2025
View reviewed changes
@dylanjeffersdylanjeffers
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff
Comment threadpackages/common/src/api/tan-query/wallets/useTokenBalance.ts
 select: (userCoinWithAccounts) => {
 if (!userCoinWithAccounts) return null
 const { balance: balanceNumber, decimals } = userCoinWithAccounts
 select: (aggregateCoinAccounts) => {
@dylanjeffersdylanjeffersAug 18, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice
@DejayJD
DejayJD
merged commit e2661ca
into
mainAug 18, 2025

7 of 10 checks passed

@DejayJD
DejayJD
deleted the

jd/coins-qa-pass-1

branch
August 18, 2025 21:42
audius-infra pushed a commit
that referenced
this pull request
Aug 23, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.149
a9364e4
[b7a7478] [PE-6729|PE-6728|PE-6724] Various minor artist coin tweaks (#12782) JD Francis
[48903d3] [PE-6744] Connect ExternalWalletsCard to ExternalWalletsScreen on mobile (#12793) KJ
[8dff4f9] OEmbed: Don't use OG url (#12792) Marcus Pasell
[76aae83] [QA-2290] Mobile USDC purchase recovery (#12791) Reed
[e99bbc8] Fix buy-audio wrong change formatting (#12787) Reed
[9d33032] $AUDIO balance includes staked (#12790) Reed
[a15f37e] Bump version of Jupiter price API (#12789) Farid Salau
[8cdd634] [PE-6717] Update default buy/sell token pair based on path (#12788) KJ
[b1792fb] [PE-6721] Fix badge hover card in left nav profile (#12784) Reed
[e656e9f] Update user bank deriver to use artist coins endpoint (#12785) Farid Salau
[52f3c35] Allow direct DBC swaps (#12776) Farid Salau
[2e341b2] Remove hardcoded decimals values from Swap flow (#12763) Farid Salau
[5e4a021] [PE-6735, PE-6738, PE-6739] Updates to the mobile coins screens (#12783) KJ
[930bbe8] [QA-2182] Fix selected tip reaction (#12703) Dylan Jeffers
[80085fe] [QA-1076] Fix notification drawer top inset (#12704) Dylan Jeffers
[c93ad60] [PE-6660] Add new send tokens modal flow (#12777) Dylan Jeffers
[571711c] [PE-6732, PE-6733, PE-6734, PE-6517] Add mobile AllCoinsScreen and CoinDetailsScreen (#12775) KJ
[61aed02] Drop track tile on upload complete screen (#12780) Dylan Jeffers
[881cd6c] [PE-6725] Remove ai-attribution from uploadTrack e2e test (#12779) Reed
[b799ee3] Fix types and type safety in useConnectedWallets, useAudioBalance, useWalletAudioBalance, and useWalletAudioBalances (#12683) Marcus Pasell
[629d200] [PE-6714] Only show add cash when no USDC balance (#12774) Reed
[041f71e] [PE-6670] Redo discord flow with OAuth (#12772) JD Francis
[22e7d18] [PE-6582] Fix mobile musical key filter (#12768) Dylan Jeffers
[8af0b47] [PE-6726] Mobile Search QA (#12767) Dylan Jeffers
[e2661ca] [PE-6709|PE-6710|PE-6707] Artist coin QA pass (#12761) JD Francis
[935c054] update b challenge (#12764) Randy Schott
[e32b36b] [PE-6676] Improve mobile explore content performance (#12739) Dylan Jeffers
[246a276] [PE-6632] Fix selected category display for mobile web search/explore (#12737) Randy Schott
[d155e23] Fix receive modal spacing (#12759) Reed
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dylanjeffersdylanjeffersdylanjeffers approved these changes
@faridsalaufaridsalauAwaiting requested review from faridsalau

Assignees


No one assigned


Labels

size/L

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[PE-6709|PE-6710|PE-6707] Artist coin QA pass by DejayJD · Pull Request #12761 · AudiusProject/apps · GitHub
Skip to content
[PE-6709|PE-6710|PE-6707] Artist coin QA pass - #12761
Merged
DejayJD merged 4 commits into
mainfrom 
jd/coins-qa-pass-1
Aug 18, 2025
Merged
[PE-6709|PE-6710|PE-6707] Artist coin QA pass#12761
DejayJD merged 4 commits into
mainfrom 
jd/coins-qa-pass-1
Conversation
@DejayJD
@DejayJDDejayJD
commented
Aug 15, 2025

Copy link


Copy Markdown

Contributor
Description
Combined 3 QA items into one PR
  • PE-6709 - Fix swap balances accounting for your external wallets - added a prop to useTokenBalance to ignore external wallets
  • PE-6710 - Fix optimistic updates after swaps - invalidateQueries doesnt seem to be timing out right, I've seen it work a handful of times but I think its a race condition. Swapped it to a calculated mutation instead
  • PE-6707 - Link external wallet infinite spinning - Fixed by using isLoading instead of isPending, bit of a tan-query quirk here where if your queryFn never runs you get isPending forever. isLoading is the more correct status to use here since
How Has This Been Tested?
web:stage
  • swap modal shows internal wallet balance
  • unauthed user shows external wallets as expected
  • did convert flow, mutations look good
    
TODO: test buy & sell flows as well
    2025-08-15 17 15 23
@changeset-bot
changeset-botBot
commented
Aug 15, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 13c8cca
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@DejayJD
DejayJD
requested review from
a team, dylanjeffers and faridsalauAugust 15, 2025 22:18
dylanjeffers
dylanjeffers
approved these changes
Aug 18, 2025
View reviewed changes
@dylanjeffersdylanjeffers
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff
Comment threadpackages/common/src/api/tan-query/wallets/useTokenBalance.ts
 select: (userCoinWithAccounts) => {
 if (!userCoinWithAccounts) return null
 const { balance: balanceNumber, decimals } = userCoinWithAccounts
 select: (aggregateCoinAccounts) => {
@dylanjeffersdylanjeffersAug 18, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice
@DejayJD
DejayJD
merged commit e2661ca
into
mainAug 18, 2025

7 of 10 checks passed

@DejayJD
DejayJD
deleted the

jd/coins-qa-pass-1

branch
August 18, 2025 21:42
audius-infra pushed a commit
that referenced
this pull request
Aug 23, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.149
a9364e4
[b7a7478] [PE-6729|PE-6728|PE-6724] Various minor artist coin tweaks (#12782) JD Francis
[48903d3] [PE-6744] Connect ExternalWalletsCard to ExternalWalletsScreen on mobile (#12793) KJ
[8dff4f9] OEmbed: Don't use OG url (#12792) Marcus Pasell
[76aae83] [QA-2290] Mobile USDC purchase recovery (#12791) Reed
[e99bbc8] Fix buy-audio wrong change formatting (#12787) Reed
[9d33032] $AUDIO balance includes staked (#12790) Reed
[a15f37e] Bump version of Jupiter price API (#12789) Farid Salau
[8cdd634] [PE-6717] Update default buy/sell token pair based on path (#12788) KJ
[b1792fb] [PE-6721] Fix badge hover card in left nav profile (#12784) Reed
[e656e9f] Update user bank deriver to use artist coins endpoint (#12785) Farid Salau
[52f3c35] Allow direct DBC swaps (#12776) Farid Salau
[2e341b2] Remove hardcoded decimals values from Swap flow (#12763) Farid Salau
[5e4a021] [PE-6735, PE-6738, PE-6739] Updates to the mobile coins screens (#12783) KJ
[930bbe8] [QA-2182] Fix selected tip reaction (#12703) Dylan Jeffers
[80085fe] [QA-1076] Fix notification drawer top inset (#12704) Dylan Jeffers
[c93ad60] [PE-6660] Add new send tokens modal flow (#12777) Dylan Jeffers
[571711c] [PE-6732, PE-6733, PE-6734, PE-6517] Add mobile AllCoinsScreen and CoinDetailsScreen (#12775) KJ
[61aed02] Drop track tile on upload complete screen (#12780) Dylan Jeffers
[881cd6c] [PE-6725] Remove ai-attribution from uploadTrack e2e test (#12779) Reed
[b799ee3] Fix types and type safety in useConnectedWallets, useAudioBalance, useWalletAudioBalance, and useWalletAudioBalances (#12683) Marcus Pasell
[629d200] [PE-6714] Only show add cash when no USDC balance (#12774) Reed
[041f71e] [PE-6670] Redo discord flow with OAuth (#12772) JD Francis
[22e7d18] [PE-6582] Fix mobile musical key filter (#12768) Dylan Jeffers
[8af0b47] [PE-6726] Mobile Search QA (#12767) Dylan Jeffers
[e2661ca] [PE-6709|PE-6710|PE-6707] Artist coin QA pass (#12761) JD Francis
[935c054] update b challenge (#12764) Randy Schott
[e32b36b] [PE-6676] Improve mobile explore content performance (#12739) Dylan Jeffers
[246a276] [PE-6632] Fix selected category display for mobile web search/explore (#12737) Randy Schott
[d155e23] Fix receive modal spacing (#12759) Reed
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dylanjeffersdylanjeffersdylanjeffers approved these changes
@faridsalaufaridsalauAwaiting requested review from faridsalau

Assignees


No one assigned


Labels

size/L

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[PE-6709|PE-6710|PE-6707] Artist coin QA pass by DejayJD · Pull Request #12761 · AudiusProject/apps · GitHub
Skip to content
[PE-6709|PE-6710|PE-6707] Artist coin QA pass - #12761
Merged
DejayJD merged 4 commits into
mainfrom 
jd/coins-qa-pass-1
Aug 18, 2025
Merged
[PE-6709|PE-6710|PE-6707] Artist coin QA pass#12761
DejayJD merged 4 commits into
mainfrom 
jd/coins-qa-pass-1
Conversation
@DejayJD
@DejayJDDejayJD
commented
Aug 15, 2025

Copy link


Copy Markdown

Contributor
Description
Combined 3 QA items into one PR
  • PE-6709 - Fix swap balances accounting for your external wallets - added a prop to useTokenBalance to ignore external wallets
  • PE-6710 - Fix optimistic updates after swaps - invalidateQueries doesnt seem to be timing out right, I've seen it work a handful of times but I think its a race condition. Swapped it to a calculated mutation instead
  • PE-6707 - Link external wallet infinite spinning - Fixed by using isLoading instead of isPending, bit of a tan-query quirk here where if your queryFn never runs you get isPending forever. isLoading is the more correct status to use here since
How Has This Been Tested?
web:stage
  • swap modal shows internal wallet balance
  • unauthed user shows external wallets as expected
  • did convert flow, mutations look good
    
TODO: test buy & sell flows as well
    2025-08-15 17 15 23
@changeset-bot
changeset-botBot
commented
Aug 15, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 13c8cca
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@DejayJD
DejayJD
requested review from
a team, dylanjeffers and faridsalauAugust 15, 2025 22:18
dylanjeffers
dylanjeffers
approved these changes
Aug 18, 2025
View reviewed changes
@dylanjeffersdylanjeffers
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff
Comment threadpackages/common/src/api/tan-query/wallets/useTokenBalance.ts
 select: (userCoinWithAccounts) => {
 if (!userCoinWithAccounts) return null
 const { balance: balanceNumber, decimals } = userCoinWithAccounts
 select: (aggregateCoinAccounts) => {
@dylanjeffersdylanjeffersAug 18, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice
@DejayJD
DejayJD
merged commit e2661ca
into
mainAug 18, 2025

7 of 10 checks passed

@DejayJD
DejayJD
deleted the

jd/coins-qa-pass-1

branch
August 18, 2025 21:42
audius-infra pushed a commit
that referenced
this pull request
Aug 23, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.149
a9364e4
[b7a7478] [PE-6729|PE-6728|PE-6724] Various minor artist coin tweaks (#12782) JD Francis
[48903d3] [PE-6744] Connect ExternalWalletsCard to ExternalWalletsScreen on mobile (#12793) KJ
[8dff4f9] OEmbed: Don't use OG url (#12792) Marcus Pasell
[76aae83] [QA-2290] Mobile USDC purchase recovery (#12791) Reed
[e99bbc8] Fix buy-audio wrong change formatting (#12787) Reed
[9d33032] $AUDIO balance includes staked (#12790) Reed
[a15f37e] Bump version of Jupiter price API (#12789) Farid Salau
[8cdd634] [PE-6717] Update default buy/sell token pair based on path (#12788) KJ
[b1792fb] [PE-6721] Fix badge hover card in left nav profile (#12784) Reed
[e656e9f] Update user bank deriver to use artist coins endpoint (#12785) Farid Salau
[52f3c35] Allow direct DBC swaps (#12776) Farid Salau
[2e341b2] Remove hardcoded decimals values from Swap flow (#12763) Farid Salau
[5e4a021] [PE-6735, PE-6738, PE-6739] Updates to the mobile coins screens (#12783) KJ
[930bbe8] [QA-2182] Fix selected tip reaction (#12703) Dylan Jeffers
[80085fe] [QA-1076] Fix notification drawer top inset (#12704) Dylan Jeffers
[c93ad60] [PE-6660] Add new send tokens modal flow (#12777) Dylan Jeffers
[571711c] [PE-6732, PE-6733, PE-6734, PE-6517] Add mobile AllCoinsScreen and CoinDetailsScreen (#12775) KJ
[61aed02] Drop track tile on upload complete screen (#12780) Dylan Jeffers
[881cd6c] [PE-6725] Remove ai-attribution from uploadTrack e2e test (#12779) Reed
[b799ee3] Fix types and type safety in useConnectedWallets, useAudioBalance, useWalletAudioBalance, and useWalletAudioBalances (#12683) Marcus Pasell
[629d200] [PE-6714] Only show add cash when no USDC balance (#12774) Reed
[041f71e] [PE-6670] Redo discord flow with OAuth (#12772) JD Francis
[22e7d18] [PE-6582] Fix mobile musical key filter (#12768) Dylan Jeffers
[8af0b47] [PE-6726] Mobile Search QA (#12767) Dylan Jeffers
[e2661ca] [PE-6709|PE-6710|PE-6707] Artist coin QA pass (#12761) JD Francis
[935c054] update b challenge (#12764) Randy Schott
[e32b36b] [PE-6676] Improve mobile explore content performance (#12739) Dylan Jeffers
[246a276] [PE-6632] Fix selected category display for mobile web search/explore (#12737) Randy Schott
[d155e23] Fix receive modal spacing (#12759) Reed
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dylanjeffersdylanjeffersdylanjeffers approved these changes
@faridsalaufaridsalauAwaiting requested review from faridsalau

Assignees


No one assigned


Labels

size/L

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[PE-6709|PE-6710|PE-6707] Artist coin QA pass by DejayJD · Pull Request #12761 · AudiusProject/apps · GitHub
Skip to content
[PE-6709|PE-6710|PE-6707] Artist coin QA pass - #12761
Merged
DejayJD merged 4 commits into
mainfrom 
jd/coins-qa-pass-1
Aug 18, 2025
Merged
[PE-6709|PE-6710|PE-6707] Artist coin QA pass#12761
DejayJD merged 4 commits into
mainfrom 
jd/coins-qa-pass-1
Conversation
@DejayJD
@DejayJDDejayJD
commented
Aug 15, 2025

Copy link


Copy Markdown

Contributor
Description
Combined 3 QA items into one PR
  • PE-6709 - Fix swap balances accounting for your external wallets - added a prop to useTokenBalance to ignore external wallets
  • PE-6710 - Fix optimistic updates after swaps - invalidateQueries doesnt seem to be timing out right, I've seen it work a handful of times but I think its a race condition. Swapped it to a calculated mutation instead
  • PE-6707 - Link external wallet infinite spinning - Fixed by using isLoading instead of isPending, bit of a tan-query quirk here where if your queryFn never runs you get isPending forever. isLoading is the more correct status to use here since
How Has This Been Tested?
web:stage
  • swap modal shows internal wallet balance
  • unauthed user shows external wallets as expected
  • did convert flow, mutations look good
    
TODO: test buy & sell flows as well
    2025-08-15 17 15 23
@changeset-bot
changeset-botBot
commented
Aug 15, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 13c8cca
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@DejayJD
DejayJD
requested review from
a team, dylanjeffers and faridsalauAugust 15, 2025 22:18
dylanjeffers
dylanjeffers
approved these changes
Aug 18, 2025
View reviewed changes
@dylanjeffersdylanjeffers
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff
Comment threadpackages/common/src/api/tan-query/wallets/useTokenBalance.ts
 select: (userCoinWithAccounts) => {
 if (!userCoinWithAccounts) return null
 const { balance: balanceNumber, decimals } = userCoinWithAccounts
 select: (aggregateCoinAccounts) => {
@dylanjeffersdylanjeffersAug 18, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice
@DejayJD
DejayJD
merged commit e2661ca
into
mainAug 18, 2025

7 of 10 checks passed

@DejayJD
DejayJD
deleted the

jd/coins-qa-pass-1

branch
August 18, 2025 21:42
audius-infra pushed a commit
that referenced
this pull request
Aug 23, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.149
a9364e4
[b7a7478] [PE-6729|PE-6728|PE-6724] Various minor artist coin tweaks (#12782) JD Francis
[48903d3] [PE-6744] Connect ExternalWalletsCard to ExternalWalletsScreen on mobile (#12793) KJ
[8dff4f9] OEmbed: Don't use OG url (#12792) Marcus Pasell
[76aae83] [QA-2290] Mobile USDC purchase recovery (#12791) Reed
[e99bbc8] Fix buy-audio wrong change formatting (#12787) Reed
[9d33032] $AUDIO balance includes staked (#12790) Reed
[a15f37e] Bump version of Jupiter price API (#12789) Farid Salau
[8cdd634] [PE-6717] Update default buy/sell token pair based on path (#12788) KJ
[b1792fb] [PE-6721] Fix badge hover card in left nav profile (#12784) Reed
[e656e9f] Update user bank deriver to use artist coins endpoint (#12785) Farid Salau
[52f3c35] Allow direct DBC swaps (#12776) Farid Salau
[2e341b2] Remove hardcoded decimals values from Swap flow (#12763) Farid Salau
[5e4a021] [PE-6735, PE-6738, PE-6739] Updates to the mobile coins screens (#12783) KJ
[930bbe8] [QA-2182] Fix selected tip reaction (#12703) Dylan Jeffers
[80085fe] [QA-1076] Fix notification drawer top inset (#12704) Dylan Jeffers
[c93ad60] [PE-6660] Add new send tokens modal flow (#12777) Dylan Jeffers
[571711c] [PE-6732, PE-6733, PE-6734, PE-6517] Add mobile AllCoinsScreen and CoinDetailsScreen (#12775) KJ
[61aed02] Drop track tile on upload complete screen (#12780) Dylan Jeffers
[881cd6c] [PE-6725] Remove ai-attribution from uploadTrack e2e test (#12779) Reed
[b799ee3] Fix types and type safety in useConnectedWallets, useAudioBalance, useWalletAudioBalance, and useWalletAudioBalances (#12683) Marcus Pasell
[629d200] [PE-6714] Only show add cash when no USDC balance (#12774) Reed
[041f71e] [PE-6670] Redo discord flow with OAuth (#12772) JD Francis
[22e7d18] [PE-6582] Fix mobile musical key filter (#12768) Dylan Jeffers
[8af0b47] [PE-6726] Mobile Search QA (#12767) Dylan Jeffers
[e2661ca] [PE-6709|PE-6710|PE-6707] Artist coin QA pass (#12761) JD Francis
[935c054] update b challenge (#12764) Randy Schott
[e32b36b] [PE-6676] Improve mobile explore content performance (#12739) Dylan Jeffers
[246a276] [PE-6632] Fix selected category display for mobile web search/explore (#12737) Randy Schott
[d155e23] Fix receive modal spacing (#12759) Reed
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dylanjeffersdylanjeffersdylanjeffers approved these changes
@faridsalaufaridsalauAwaiting requested review from faridsalau

Assignees


No one assigned


Labels

size/L

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers