Skip to content

Several UI updates for Artist Coins - #12876

Merged
faridsalau merged 10 commits into
mainfrom
fs-ac-ui-updates
Sep 16, 2025
Merged

Several UI updates for Artist Coins#12876
faridsalau merged 10 commits into
mainfrom
fs-ac-ui-updates

Conversation

@faridsalau

@faridsalaufaridsalau commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

Description

Removes ARTIST_COINS feature flag and simplifies coin/token UI components, along with routing and navigation updates.

Changes

  • Feature Flag Removal: Eliminates ARTIST_COINS feature flag logic from coin grouping and UI components
  • Component Simplification: Removes FindMoreCoins component and AllCoinsScreen, simplifies YourCoins layout
  • Routing Updates: Updates coin-related routes and navigation paths
  • Token Updates: Changes AUDIO token name to "Audius Coin" and updates asset detail navigation
  • Code Cleanup: Removes unused imports, components, and TODO comments

Impact

  • Simplifies coin display logic by removing feature flag dependencies
  • Updates navigation paths to use new coin routes
  • Removes unused "All Coins" functionality
  • Improves maintainability by reducing conditional rendering

How Has This Been Tested?

npm run web:prod and play around with flows changes

@changeset-bot

changeset-botBot commented Sep 16, 2025•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: cc4607d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

@faridsalaufaridsalau changed the title Several UI updatesSeveral UI updates for Artist CoinsSep 16, 2025
dharit-tan
dharit-tan reviewed Sep 16, 2025
View reviewed changes
Comment threadpackages/common/src/store/ui/buy-sell/useGroupCoinPairs.ts
return useMemo(() => {
if (!coins) {
return isArtistCoinsEnabled ? [['find-more']] : []
return []

@dharit-tandharit-tanSep 16, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this right? wouldn't we want to return audio still?

@faridsalaufaridsalauSep 16, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AUDIO will always be there

dharit-tan
dharit-tan reviewed Sep 16, 2025
View reviewed changes
Comment threadpackages/common/src/utils/route.ts
ASSET_DETAIL_PAGE,
WALLET_PAGE,
ALL_COINS_PAGE,
COINS_EXPLORE_PAGE,

@dharit-tandharit-tanSep 16, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i used COINS_EXPLORE_PAGE for the coins leaderboard..

@faridsalaufaridsalauSep 16, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea this is still that, just moving routes around

dharit-tan
dharit-tan reviewed Sep 16, 2025
View reviewed changes
Comment threadpackages/web/src/app/web-player/WebPlayer.jsx
component={AllCoinsPage}
/>

{isArtistCoinsEnabled ? (

@dharit-tandharit-tanSep 16, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait PR says we're getting rid of this ff? or are we just moving it to the top-level

@faridsalaufaridsalauSep 16, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meant just removing from useGroupCoinPairs

dharit-tan
dharit-tan approved these changes Sep 16, 2025
View reviewed changes

@dharit-tandharit-tan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont remember discussing these changes but maybe i was spacing out.. lgtm

@faridsalau
faridsalau merged commit 0bff6aa into mainSep 16, 2025
9 of 11 checks passed
@faridsalau
faridsalau deleted the fs-ac-ui-updates branch September 16, 2025 16:55
@faridsalaufaridsalau mentioned this pull request Sep 16, 2025
Merged
faridsalau added a commit that referenced this pull request Sep 16, 2025
@faridsalau
Only show audio card when feature flag is disabled (#12878)
53ee9c8
### Description
[This](#12876) PR
caused a regression that caused non-AUDIO cards to be shown when the
feature flag is off. This is incorrect behavior. Remedying
### How Has This Been Tested?
`npm run web:prod` and turn off feature flag
audius-infra pushed a commit that referenced this pull request Sep 20, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.153
6a06636
[ebb2f7f] [PE-6856] Add check to see if the coin has a discord before rendering (#12910) Ray Jacobson
[89e990c] [PE-6852] Fix artist coin gradient (#12909) Dylan Jeffers
[f3860d1] [PE-6791, PE-6838] Launchpad QA and updates (#12907) Dylan Jeffers
[81ceb79] [PE-6850] Redo launchpad first buy with audio instead of sol (#12912) JD Francis
[aa7565b] Fix bug in asset details navigation (#12919) Reed
[412c9fe] small mobile lint fix for useArtistCoin hook (#12918) KJ
[08b0163] Use subscript notation in artist coin table (#12917) Reed
[076c1a8] Filter $AUDIO from artist coins tables (#12916) Reed
[70ee92d] Update buy artist coin button to open buy sell modal on web (#12915) KJ
[6bc6e31] Artist coin row clickable (#12903) Reed
[f42dac0] Ellipsize coin names in ArtistCoinTable (#12904) Reed
[1203e91] [PE-6825] Add coin batching and cleanup (#12905) Dylan Jeffers
[c32dd72] [PE-6842] Mobile web artist coins explore (#12902) Reed
[414104e] [PE-6817, PE-6818] Update track screen and track tile for coin gating (#12887) KJ
[6e46c76] Reduce coin calls in user-badges (#12888) Dylan Jeffers
[838d0f6] Drop legacy wallet modal (#12827) Dylan Jeffers
[68c0fe2] Fix anchor tag warning (#12892) Farid Salau
[5abeed7] Use correct route on artist coin hover card (#12901) Farid Salau
[8492b52] [PE-6820] Update mobile web track page for coin gating (#12899) KJ
[eb8b1da] Make swaps work for new artist coins (#12900) Farid Salau
[96763dc] [PE-6816] Update mobile upload flow for coin gating (#12898) KJ
[d2926f7] Use env var for AUDIO mint instead of prod mint (#12897) Farid Salau
[7fc0b16] Refactor Token Filtering and Display Logic for Artist Coins (#12893) Farid Salau
[00ca789] Misc launchpad changes (#12889) JD Francis
[39adddd] Fix token-info-row tooltip mount (#12895) Dylan Jeffers
[d531909] [QA-2325] Fix audio balance user badges (#12894) JD Francis
[74d42f6] [PE-6798] Launchpad use actual quote logic (#12877) JD Francis
[e59ff70] [PE-6824] Web artist coins table sort, pagination (#12886) Reed
[54cf5fb] Use webp search explore background image (#12885) Reed
[d086c89] [PE-6788] Mobile coins explore page (#12882) Reed
[d738ea1] [API-100] Add error handling for rewards claiming (#12890) Ray Jacobson
[b808da5] [API-100] Integrate new Rewards endpoint with client (#12875) Ray Jacobson
[2bf3f9d] Use price from BE in formatter and deprecate `useTokenPrice` (#12883) Farid Salau
[1589e25] Fix your coins table on resizing (#12881) Farid Salau
[3014683] Fix tooltip positioning in buy/sell modal (#12880) Farid Salau
[53ee9c8] Only show audio card when feature flag is disabled (#12878) Farid Salau
[0bff6aa] Several UI updates for Artist Coins (#12876) Farid Salau
[50b8fcf] [PE-6808, PE-6809] Update track page and track tiles for coin gating (#12871) KJ
[f0a7e57] [PE-6799] Web artist coin explore page (#12869) Reed
[d7e40eb] [PE-6750] Buy/sell/swap modal v2 (#12864) Dylan Jeffers
[582b918] [PE-6807] Update upload flow for token gating (#12867) KJ
[05e9fb5] Fix download all when track download not available (#12868) Dylan Jeffers
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@DejayJDDejayJDAwaiting requested review from DejayJD
@dylanjeffersdylanjeffersAwaiting requested review from dylanjeffers
@Kyle-ShanksKyle-ShanksAwaiting requested review from Kyle-Shanks
+1 more reviewer
@dharit-tandharit-tandharit-tan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@faridsalau@dharit-tan