Skip to content

[ASI-756] PR #3 - Update snapback logic to consume filesHash - #2186

Merged
SidSethi merged 46 commits into
masterfrom
ss-new-snapback-sync-logic
Jan 28, 2022
Merged

[ASI-756] PR #3 - Update snapback logic to consume filesHash#2186
SidSethi merged 46 commits into
masterfrom
ss-new-snapback-sync-logic

Conversation

@SidSethi

@SidSethiSidSethi commented Dec 21, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • Update Snapback issueSyncRequests logic to consume filesHash, with back-compat
  • New computeSyncModeForUserAndReplica module

Tests

  • unit test coverage for computeSyncModeForUserAndReplica()
  • Existing maddog test coverage + local e2e confirm no regression

How will this change be monitored?

Monitor recurring sync failures, and watch out for logs:

  • "[issueSyncRequestsToSecondaries] [PrimaryShouldSync = true] wallet ${wallet} secondary ${secondary} Clocks: [${primaryClock},${secondaryClock}] Files hashes: [${primaryFilesHash},${secondaryFilesHash}]"
  • "[issueSyncRequestsToSecondaries] Falling back to computeSyncModeForUserAndReplicaLegacy() [primaryFilesHash: ${primaryFilesHash}] secondaryFilesHash: ${secondaryFilesHash}"

Base automatically changed from ss-sec-wipe-resync to masterJanuary 5, 2022 15:35
@SidSethi
SidSethi changed the base branch from master to ss-sec-wipe-resyncJanuary 5, 2022 15:39
@SidSethi
SidSethi changed the base branch from ss-sec-wipe-resync to masterJanuary 5, 2022 15:53
SidSethi
SidSethi commented Jan 5, 2022
View reviewed changes
Comment threadcreator-node/src/snapbackSM/snapbackSM.js Outdated
@SidSethi
SidSethi marked this pull request as ready for review January 5, 2022 19:09
dmanjunath
dmanjunath approved these changes Jan 7, 2022
View reviewed changes

@dmanjunathdmanjunath left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very clean and easy to understand

Comment threadcreator-node/src/snapbackSM/snapbackSM.js
Comment threadcreator-node/src/snapbackSM/snapbackSM.js Outdated
@vicky-g

vicky-g commented Jan 26, 2022

Copy link
Copy Markdown
Contributor

might also be worth while to create loggly dashboards to parse for the logs mentioned in the bio

@SidSethi

SidSethi commented Jan 26, 2022

Copy link
Copy Markdown
ContributorAuthor

might also be worth while to create loggly dashboards to parse for the logs mentioned in the bio

@vicky-g seems overkill - simple to query normally, can revisit after some time if needed

@SidSethi

SidSethi commented Jan 26, 2022

Copy link
Copy Markdown
ContributorAuthor

@vicky-g@dmanjunath addressed all comments, couple outstanding discussions - pls re-review!!

dmanjunath
dmanjunath approved these changes Jan 27, 2022
View reviewed changes

@dmanjunathdmanjunath left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glad to see async-retry works with this!

vicky-g
vicky-g reviewed Jan 27, 2022
View reviewed changes

@vicky-gvicky-g left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there! just a small comment regarding creator-node/src/snapbackSM/computeSyncModeForUserAndReplica.js

Comment threadcreator-node/src/snapbackSM/computeSyncModeForUserAndReplica.js Outdated
vicky-g
vicky-g reviewed Jan 27, 2022
View reviewed changes
Comment threadcreator-node/src/snapbackSM/computeSyncModeForUserAndReplica.js Outdated
@SidSethi
SidSethi requested a review from vicky-gJanuary 27, 2022 21:24
vicky-g
vicky-g approved these changes Jan 27, 2022
View reviewed changes

@vicky-gvicky-g left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@SidSethi
SidSethi merged commit 431544a into masterJan 28, 2022
@SidSethi
SidSethi deleted the ss-new-snapback-sync-logic branch January 28, 2022 17:02
SidSethi added a commit that referenced this pull request Feb 10, 2022
@SidSethi
Revert "[ASI-756] PR#3- Update snapback logic to consume filesHash (#…
f9b758f
…2186)"
This reverts commit 431544a.
@SidSethiSidSethi mentioned this pull request Feb 10, 2022
Merged
SidSethi added a commit that referenced this pull request Feb 10, 2022
@SidSethi
Revert "[ASI-756] PR#3- Update snapback logic to consume filesHash (#…
8503e17
…2186)" (#2460)
This reverts commit 431544a.
SidSethi added a commit that referenced this pull request Feb 10, 2022
@SidSethi
[ASI-756] PR#3- Update snapback logic to consume filesHash (#2186)
6eb8b80
@SidSethiSidSethi mentioned this pull request Feb 15, 2022
Closed
3 tasks
SidSethi added a commit that referenced this pull request Jun 22, 2022
@SidSethi
[ASI-756] PR#3- Update snapback logic to consume filesHash (#2186)
f69e157
@AudiusProjectAudiusProject deleted a comment from linearBotSep 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@cheran-senthilcheran-senthilcheran-senthil left review comments
@dmanjunathdmanjunathdmanjunath approved these changes
@vicky-gvicky-gvicky-g approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SidSethi@vicky-g@dmanjunath@cheran-senthil