Uh oh!
There was an error while loading. Please reload this page.
[ASI-1039] Only set cache-control header on /ipfs/ route success response - #2721
Closed
SidSethi wants to merge 3 commits into
Closed
[ASI-1039] Only set cache-control header on /ipfs/ route success response#2721SidSethi wants to merge 3 commits into
cache-control header on /ipfs/ route success response#2721SidSethi wants to merge 3 commits into
Conversation
SidSethi
commented
Mar 17, 2022
| } | ||
| module.exports.getCID = getCID | ||
| module.exports.streamFromFileSystem = streamFromFileSystem |
ContributorAuthor
There was a problem hiding this comment.
removed since never consumed exteranlly
SidSethi
commented
Mar 17, 2022
| if (end >= stat.size) { | ||
| // Set "Requested Range Not Satisfiable" header and exit | ||
| // Return "Requested Range Not Satisfiable" error | ||
| res.status(416) |
ContributorAuthor
There was a problem hiding this comment.
just moving line from below
cache-control header on /ipfs/ route success responsecache-control header on /ipfs/ route success responsecache-control header on /ipfs/ route success responsecache-control header on /ipfs/ route success responseSidSethi
commented
Jun 27, 2022
ContributorAuthor
closed in favor of #3322 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tests
How will this change be monitored? Are there sufficient logs?