Skip to content

StateMachineQueue improvements - #2911

Closed
SidSethi wants to merge 10 commits into
masterfrom
ss-statemachinequeue-additional-work
Closed

StateMachineQueue improvements#2911
SidSethi wants to merge 10 commits into
masterfrom
ss-statemachinequeue-additional-work

Conversation

@SidSethi

@SidSethiSidSethi commented Apr 13, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • Wipe redis state for state machine queues with Queue#obliterate()
  • Increase max job duration from 2x job interval to 5x, to allow for long running/delayed jobs
  • Add event handlers for all possible events for statemachinequeue to help with debugging
  • add logging after each statemachine phase to help debug when things die

Tests

Ran locally and on staging CN 11, all look good

How will this change be monitored? Are there sufficient logs?

SidSethi
SidSethi commented Apr 13, 2022
View reviewed changes
Comment threadcreator-node/src/snapbackSM/snapbackSM.js Outdated
@SidSethiSidSethi changed the title Multiple changesStateMachineQueue improvementsApr 13, 2022
SidSethi
SidSethi commented Apr 13, 2022
View reviewed changes
Comment threadcreator-node/src/snapbackSM/snapbackSM.js
dmanjunath
dmanjunath reviewed Apr 13, 2022
View reviewed changes

@dmanjunathdmanjunath left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine especially for testing and debugging on stage. do you eventually want to merge this?

@SidSethi
SidSethi marked this pull request as ready for review April 14, 2022 15:44
@theoilie

theoilie commented May 6, 2022

Copy link
Copy Markdown
Contributor

Closing in favor of #3052

@theoilietheoilie closed this May 6, 2022
@SidSethi
SidSethi deleted the ss-statemachinequeue-additional-work branch June 27, 2022 21:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmanjunathdmanjunathAwaiting requested review from dmanjunath

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SidSethi@theoilie@dmanjunath