[CON-76] Add logger param to some libs functions that CN uses

[jonaylor89]

Description

Allows for an optional logger to be passed into libs and passed throughout the services with the default being to use console

Tests

• npm run test in libs/
• A up with no errors

How will this change be monitored? Are there sufficient logs?

All loggers default to console so if when debugging, the way to monitor if something is hooked up correctly is if it's logger is console when it shouldn't be.

[SidSethi]

looks great!
lets get libs CI tests and maddog tests passing to make sure we don't introduce any regressions

[SidSethi]

added @dylanjeffers as a reviewer for typescript 🙂

[dylanjeffers]

looks great! one callout on the logger method return types

[dylanjeffers]

return type void instead of any i believe? basically means doesn't return anything and is a pure side-effect

[jonaylor89]

Are there any loggers that do return something from log()? Is sounds weird but I put any just to cover everything. I can change it if I need to

[dylanjeffers]

i don't think so, but any is fine for now too, no worries

[SidSethi]

approving - if you want to make the changes from code reviews go for it, i'm good with you merging either way

just make sure the tests pass 🙂

[SidSethi]

per discussion, removing approval since we need to separate out CN / libs changes into separate prs
my bad for not calling this out sooner

[jonaylor89]

per discussion, removing approval since we need to separate out CN / libs changes into separate prs my bad for not calling this out sooner

Done

[SidSethi]

lgtm - tagging @dylanjeffers in case you want to take a look again at the ts changes

[dylanjeffers]

nice