Skip to content

[PAY-121] [PAY-150] Index Tipping Leaderboard Notifications - #2993

Merged
rickyrombo merged 23 commits into
masterfrom
mjp-index-tips-notifs
May 4, 2022
Merged

[PAY-121] [PAY-150] Index Tipping Leaderboard Notifications#2993
rickyrombo merged 23 commits into
masterfrom
mjp-index-tips-notifs

Conversation

@rickyrombo

@rickyromborickyrombo commented Apr 28, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Tip notifications for leaderboard

Supports notifications for:

  • If you're the first person to tip an artist
  • If you're entering the leaderboard for the first time
  • If you're moving up the leaderboard

NOTE: Updates anchorpy and solana to get access to get_block_height()

Tests

Tested manually on remote using seed commands and watching database, as well as hitting /solana_notifications endpoint

How will this change be monitored? Are there sufficient logs?

Added some logging as well, and write the latest slot into Redis

@rickyrombo
rickyrombo marked this pull request as ready for review May 3, 2022 01:27
rickyrombo
rickyrombo commented May 3, 2022
View reviewed changes
Comment threaddiscovery-provider/src/utils/seed.py
rickyrombo
rickyrombo commented May 3, 2022
View reviewed changes
Comment threaddiscovery-provider/src/tasks/index_aggregate_tips.py Outdated
dylanjeffers
dylanjeffers approved these changes May 3, 2022
View reviewed changes

@dylanjeffersdylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was really helpful to see! from my end it looks good, but i also don't have all the context

Comment threaddiscovery-provider/src/queries/notifications.py
Comment threaddiscovery-provider/src/solana/solana_client_manager.py Outdated
Comment threaddiscovery-provider/src/tasks/index_aggregate_tips.py
Comment threadservice-commands/src/setup.js Outdated
@rickyromborickyrombo mentioned this pull request May 3, 2022
Merged
piazzatron
piazzatron approved these changes May 4, 2022
View reviewed changes

@piazzatronpiazzatron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks gr8

Comment threaddiscovery-provider/src/tasks/index_aggregate_tips.py
Comment threaddiscovery-provider/src/tasks/index_aggregate_tips.py
Comment threaddiscovery-provider/src/tasks/index_aggregate_tips.py Outdated
Comment threaddiscovery-provider/src/tasks/index_aggregate_tips.py
Comment threaddiscovery-provider/src/utils/seed.py
@rickyromborickyrombo changed the title Index Tipping Leaderboard Notifications[PAY-121] Index Tipping Leaderboard NotificationsMay 4, 2022
@rickyromborickyrombo changed the title [PAY-121] Index Tipping Leaderboard Notifications[PAY-121] [PAY-150] Index Tipping Leaderboard NotificationsMay 4, 2022
jowlee
jowlee approved these changes May 4, 2022
View reviewed changes

@jowleejowlee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked about reversing order of using global slot and vs last tx offline in the index_user_bank, otherwise, looks great!

@rickyrombo
rickyrombo merged commit 1d9aa23 into masterMay 4, 2022
@rickyrombo
rickyrombo deleted the mjp-index-tips-notifs branch May 4, 2022 21:55
@rickyromborickyrombo mentioned this pull request May 9, 2022
Merged
@AudiusProjectAudiusProject deleted a comment from linearBotSep 11, 2023
@AudiusProjectAudiusProject deleted a comment from linearBotSep 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dylanjeffersdylanjeffersdylanjeffers approved these changes
+2 more reviewers
@piazzatronpiazzatronpiazzatron approved these changes
@jowleejowleejowlee approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@piazzatronpiazzatron

@jowleejowlee

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rickyrombo@piazzatron@jowlee@dylanjeffers