Skip to content

Refactor libs base.js and serviceProvider.js classes to Typescript - #3363

Merged
piazzatron merged 3 commits into
masterfrom
piazz-libs-ts-refactor
Jul 6, 2022
Merged

Refactor libs base.js and serviceProvider.js classes to Typescript#3363
piazzatron merged 3 commits into
masterfrom
piazz-libs-ts-refactor

Conversation

@piazzatron

@piazzatronpiazzatron commented Jun 30, 2022

Copy link
Copy Markdown
Contributor

Description

Should be a straightforward port.

Tests

Testing on stage

Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

piazzatron
piazzatron commented Jun 30, 2022
View reviewed changes
Comment threadlibs/src/api/base.ts
SOLANA_WEB3_MANAGER: 'Solana Web3 Manager'
})

export type BaseConstructorArgs = [

@piazzatronpiazzatronJun 30, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda weird – had to export this for use in child classes that have constructor(...args) style constructors. Really should be all object based but bigger change than I wanted to make

piazzatron
piazzatron commented Jun 30, 2022
View reviewed changes
Comment threadlibs/src/services/creatorNode/CreatorNodeSelection.ts
monitoringCallbacks: {
healthCheck?: (config: Record<string, unknown>) => Promise<AxiosResponse>
}
passList: Set<string> | null

@piazzatronpiazzatronJun 30, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old types were wrong

piazzatron
piazzatron commented Jun 30, 2022
View reviewed changes
Comment threadlibs/src/api/serviceProvider.ts Outdated
dylanjeffers
dylanjeffers approved these changes Jul 1, 2022
View reviewed changes

@dylanjeffersdylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

Comment threadlibs/src/api/reactions.ts
Comment threadlibs/src/api/serviceProvider.ts Outdated
Comment threadlibs/src/api/serviceProvider.ts
Comment threadlibs/src/api/serviceProvider.ts
discoveryNodes = (await this.discoveryProvider.serviceSelector.findAll({
verbose: true,
whitelist: useWhitelist ? undefined : null
})) as ServiceWithEndpoint[]

@dylanjeffersdylanjeffersJul 1, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asumming the discoveryProvider here is not typed?

@piazzatronpiazzatronJul 1, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some typing issues that go all the way down to allRequests - sometimes it returns Service and sometimes ServiceWithEndpoint. Gonna avoid poking this bees nest for now

Comment threadlibs/src/api/serviceProvider.ts
Comment threadlibs/src/api/serviceProvider.ts
Comment threadlibs/src/api/serviceProvider.ts
Comment threadlibs/src/api/serviceProvider.ts Outdated
@piazzatron
piazzatron merged commit e7d76e0 into masterJul 6, 2022
@piazzatron
piazzatron deleted the piazz-libs-ts-refactor branch July 6, 2022 18:48
@raymondjacobsonraymondjacobson mentioned this pull request Jul 6, 2022
Merged
dmanjunath added a commit that referenced this pull request Jul 12, 2022
@dmanjunath
Revert "Refactor libs base.js and serviceProvider.js classes to Types…
a555c08
…cript (#3363)"
This reverts commit e7d76e0.
hareeshnagaraj pushed a commit that referenced this pull request Jul 14, 2022
audius-infra
Bump libs to v0.0.17
06ce32a
## Changelog
- #3463 by nicoback2 bump
- #3420 by nicoback2 Use
- #2988 by Cheran [INF-76]
- #3458 by Johannes Naylor
- #3456 by Sid Sethi
- libs by Johannes Naylor
- #3451 by Sebastian Klingler
- #3373 by Sebastian Klingler
- #3449 by Theo Ilie
- #3408 by Theo Ilie
- #3445 by Sebastian Klingler
- #3435 by Reed Added
- #3438 by Raymond Jacobson
- #3434 by Hareesh Nagaraj
- #3433 by Sebastian Klingler
- #3406 by nicoback2 Make
- #3402 by Hareesh Nagaraj
- #3394 by Raymond Jacobson
- #3392 by Raymond Jacobson
- #3363 by Michael Piazza
- #3366 by Joseph Lee
- #3354 by Joseph Lee
- #3362 by Michael Piazza
- #3361 by Raymond Jacobson
- #3360 by Raymond Jacobson
- #3347 by Raymond Jacobson
- #3345 by Raymond Jacobson
- #3337 by Sebastian Klingler
- #3336 by Sid Sethi
hareeshnagaraj pushed a commit that referenced this pull request Jul 14, 2022
audius-infra
Bump libs to v0.0.17
fde7cc4
## Changelog
- #3463 by nicoback2 bump
- #3420 by nicoback2 Use
- #2988 by Cheran [INF-76]
- #3458 by Johannes Naylor
- #3456 by Sid Sethi
- libs by Johannes Naylor
- #3451 by Sebastian Klingler
- #3373 by Sebastian Klingler
- #3449 by Theo Ilie
- #3408 by Theo Ilie
- #3445 by Sebastian Klingler
- #3435 by Reed Added
- #3438 by Raymond Jacobson
- #3434 by Hareesh Nagaraj
- #3433 by Sebastian Klingler
- #3406 by nicoback2 Make
- #3402 by Hareesh Nagaraj
- #3394 by Raymond Jacobson
- #3392 by Raymond Jacobson
- #3363 by Michael Piazza
- #3366 by Joseph Lee
- #3354 by Joseph Lee
- #3362 by Michael Piazza
- #3361 by Raymond Jacobson
- #3360 by Raymond Jacobson
- #3347 by Raymond Jacobson
- #3345 by Raymond Jacobson
- #3337 by Sebastian Klingler
- #3336 by Sid Sethi
hareeshnagaraj pushed a commit that referenced this pull request Jul 14, 2022
audius-infra
Bump libs to v0.0.17
b8df124
## Changelog
- #3463 by nicoback2 bump
- #3420 by nicoback2 Use
- #2988 by Cheran [INF-76]
- #3458 by Johannes Naylor
- #3456 by Sid Sethi
- libs by Johannes Naylor
- #3451 by Sebastian Klingler
- #3373 by Sebastian Klingler
- #3449 by Theo Ilie
- #3408 by Theo Ilie
- #3445 by Sebastian Klingler
- #3435 by Reed Added
- #3438 by Raymond Jacobson
- #3434 by Hareesh Nagaraj
- #3433 by Sebastian Klingler
- #3406 by nicoback2 Make
- #3402 by Hareesh Nagaraj
- #3394 by Raymond Jacobson
- #3392 by Raymond Jacobson
- #3363 by Michael Piazza
- #3366 by Joseph Lee
- #3354 by Joseph Lee
- #3362 by Michael Piazza
- #3361 by Raymond Jacobson
- #3360 by Raymond Jacobson
- #3347 by Raymond Jacobson
- #3345 by Raymond Jacobson
- #3337 by Sebastian Klingler
- #3336 by Sid Sethi
sliptype pushed a commit that referenced this pull request Sep 10, 2023
@dharit-tan
Fix invite reward claimable state on mobile (#3363)
6baac4f
sliptype pushed a commit that referenced this pull request Sep 10, 2023
audius-infra
v1.5.25
7413dba
[9855fd2] Update locks (#3397) Dylan Jeffers
[aecef5f] [PAY-1144] [PAY-1182] [PAY-1147] DMs: Delete chat, message permissions (#3390) Marcus Pasell
[64ccd9d] Add stylelint to ci (#3373) Dylan Jeffers
[b642a16] [C-2518, C-2523, C-2611] Improve playlist create sagas (#3378) Dylan Jeffers
[5620d53] [PAY-1197] Mobile inbox unavailable modal from profile screen (#3376) Reed
[2ebaef5] [PAY-1248] Initial changes to get ready for upcoming PRs that include track and playlist tiles in DMs (#3391) Saliou Diallo
[c2fabf6] [PAY-1218] Mobile block dms drawer switches block/unblock (#3387) Reed
[0acad29] [C-2575] Match length of related artists user list to preview (#3395) Andrew Mendelsohn
[40525ae] [C-2615] Fix favorite tracks error due to empty track entries on web mobile (#3386) Kyle Shanks
[93a8077] [PAY-1145] DMs: Add InboxUnavailableModal (#3369) Marcus Pasell
[633484d] Update edit playlist flow and components (#3361) Kyle Shanks
[334ea0d] Special case ios safari for stem download (#3385) Raymond Jacobson
[d38238d] [C-2607] Pagination wrapper hooks for audius-query (#3375) Andrew Mendelsohn
[0a332d8] Hotfix: Fix stems downloads on mobile web (#3382) Marcus Pasell
[81da65e] Clean up artist_pick_track_id in APIUser (#3381) Michelle Brier
[64d89ef] Fix lint (#3380) Raymond Jacobson
[59129b4] [C-2614] Fix download stems mobile web (#3379) Raymond Jacobson
[df68727] [PAY-1032][PAY-892] Mobile DMs unread indicator, prefetch chats (#3352) Reed
[4a00fad] [PAY-1151] Handle chat reactions near top of screen on mobile (#3370) Reed
[bff316f] [PAY-1139] Throttle calls to fetchMessages on web scroll (#3372) Michael Piazza
[e723cec] C-2483 Fix queue overshot empty track player bug (#3353) nicoback2
[472a41d] [C-2596] Add disabled option to audius-query hooks (#3367) Andrew Mendelsohn
[f518962] [C-2602] Improve playlist library layout (#3364) Dylan Jeffers
[b3db8fa] Fix debounce on notif reaction (#3362) Raymond Jacobson
[2104b2b] [PAY-1183] Make clicking ChatUser handle/displayname lead to profile (#3368) Michael Piazza
[21cb6fc] DMs: Fix click handler in search user list for users you can't chat (#3358) Marcus Pasell
[24e7d8a] DMs: Update copy, scroll inbox-settings modal (#3359) Marcus Pasell
[e5e8d90] [PAY-941] Fix "1 new messages" unread tag (web) (#3366) Michael Piazza
[cfa1b2a] [C-2603] Fix readonly object error in audius-query reducer (#3365) Andrew Mendelsohn
[978c993] Fix invite reward claimable state on mobile (#3363) Reed
[a174fcc] [C-2556, C-2557] Address AI Attribution QA (#3349) Dylan Jeffers
[3c9b0f1] [PAY-1202] Refactor saved collections fetching (#3337) Randy Schott
[a0bdad5] Get call to action for chat permissions (#3325) Marcus Pasell
[03a2721] DMs: Use the optimistic unread count if applicable (#3354) Marcus Pasell
[8b99c2b] [C-2550] Left-nav fixes and improvements (#3357) Dylan Jeffers
[e7b0aab] [PAY-1215] Fix create new message crash (#3356) Reed
[6e7ece9] [PAY-1196] Mobile dms search users empty state (#3355) Reed
[315ae4f] [PAY-1219] Fix mobile chat reactions popup message getting cut off (#3342) Reed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dylanjeffersdylanjeffersdylanjeffers approved these changes

Assignees

@rickyromborickyrombo

@dharit-tandharit-tan

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@piazzatron@dylanjeffers@rickyrombo@dharit-tan