Skip to content

Rewriting Governance to be fully generic - #344

Merged
SidSethi merged 3 commits into
ss-slash-by-governancefrom
ss-governance-v1
Apr 8, 2020
Merged

Rewriting Governance to be fully generic#344
SidSethi merged 3 commits into
ss-slash-by-governancefrom
ss-governance-v1

Conversation

@SidSethi

@SidSethiSidSethi commented Mar 30, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Rewrote governance to allow proposals of any action in Audius protocol. Based off Compound.

Also adds proposal description strings.

@SidSethiSidSethi changed the title [DO NOT REVIEW] Governance v1Rewriting Governance to be fully genericMar 31, 2020
hareeshnagaraj
hareeshnagaraj approved these changes Mar 31, 2020
View reviewed changes

@hareeshnagarajhareeshnagaraj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for a base functionality - this looks great and I think we should merge it.

added a few suggestions and had some q's but nothing to block moving forward with this.

Comment threadeth-contracts/test/governance.test.js
Comment threadeth-contracts/contracts/Governance.sol
Comment threadeth-contracts/contracts/Governance.sol
Comment threadeth-contracts/contracts/Governance.sol
Comment threadeth-contracts/test/governance.test.js
Comment threadeth-contracts/contracts/Governance.sol
@SidSethi

SidSethi commented Apr 8, 2020

Copy link
Copy Markdown
ContributorAuthor

Made a note to address PR comments separately

@SidSethi
SidSethi merged commit fb12e81 into ss-slash-by-governanceApr 8, 2020
@SidSethi
SidSethi deleted the ss-governance-v1 branch April 8, 2020 21:22
SidSethi added a commit that referenced this pull request Apr 8, 2020
@SidSethi
Rewriting Governance to be fully generic (#344)
f12d2fb
SidSethi added a commit that referenced this pull request Apr 10, 2020
@SidSethi
Rewriting Governance to be fully generic (#344)
a7c1c21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@hareeshnagarajhareeshnagarajhareeshnagaraj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SidSethi@hareeshnagaraj