Uh oh!
There was an error while loading. Please reload this page.
[CON-243] - Use prometheus middleware package to track route duration - #3494
Conversation
theoilie
left a comment
There was a problem hiding this comment.
looks great! solid tests and screenshot. only a small nit, no blockers from me
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
oh just realized - we prob want to remove the |
SidSethi
left a comment
There was a problem hiding this comment.
looks great!! few small things - can address and merge
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
## Changelog - 2022-07-21 [6db3974] Sanity check setIsCreatorToTrue (#3531) [Sid Sethi] - 2022-07-21 [4af6a34] Revert Revert [PLAT-254] Remove is_creator usage across protocol (#3475) (#3529) (#3530) [Dylan Jeffers] - 2022-07-21 [6311d71] Revert [PLAT-254] Remove is_creator usage across protocol (#3475) (#3529) [Dylan Jeffers] - 2022-07-21 [e91d0ef] [PAY-455] SDK: Convert TransactionHandler to TypeScript and export on core (#3515) [Marcus Pasell] - 2022-07-21 [17c9130] [CON-233] Add queue history for all remaining queues (#3524) [Johannes Naylor] - 2022-07-21 [9ce2208] More state machine cleanup (#3522) [Theo Ilie] - 2022-07-20 [2fad6f0] [CON-262] Add more test coverage for /export (#3520) [Johannes Naylor] - 2022-07-20 [15006a2] [CON-243] - Use prometheus middleware package to track route duration (#3494) [vicky :)] - 2022-07-20 [43e43fe] Increase write quorum timeout to 1m (#3521) [Theo Ilie] - 2022-07-20 [914bfa3] [CON-103] - Enable cid cache (#3519) [vicky :)] - 2022-07-20 [338f8eb] Clean up misc state machine (#3518) [Theo Ilie] - 2022-07-20 [bfc6505] [C-587] Verify sdk types in ci (#3495) [Sebastian Klingler] - 2022-07-19 [af2e650] [C-688] Move docs over to monorepo (#3504) [Raymond Jacobson] - 2022-07-19 [c993992] CON-258 Modify findSyncRequest.jobProcessor with more detailed metrics (#3478) [Sid Sethi] - 2022-07-19 [afe0b61] Fix primarySyncFromSecondary circular dep by moving initAudiusLibs to separate file (#3507) [Sid Sethi]
[9a0592f] [PAY-1355] Add space before learn more link in inbox unavailable message (#3507) Reed [989390c] [PAY-1267] Add space before placeholder in chat textinput (#3508) Reed [a1e66ce] [PAY-1377] Compose message icon to TouchableOpacity (#3506) Reed [dc12349] Remove write_metadata_through_chain flag (#3432) Michelle Brier [5523041] Add clientVersion to mobile analytics (#3498) Sebastian Klingler [e2ba8ed] [PAY-1343] First message in new chat shows purple unread indicator (#3503) Reed [52096cf] Fix upload regression on stage (#3502) Andrew Mendelsohn [cdf5663] [PAY-1175] DMs: Autofocus, clear search, elevate placeholder (#3486) Marcus Pasell [d012240] [PAY-1318] Missing Shadow and Space Between Divider and Header (#3500) Michael Piazza [e71845e] [PAY-1336] Updates to mobile chats user search screen (#3489) Reed [9d12c62] [PLAT-1005] Parse for add track to playlist notification from backend (#3439) sabrina-kiam [d9c62b1] [C-2708] Improvements around codepush & force pushing (#3501) Sebastian Klingler [aa26688] [pay-1311] Reset chat state on sign out (#3499) Randy Schott [6079466] [PAY-1337] Fix mobile chat message shadows (#3494) Reed [643d3e0] [PAY-1305] DMs: Add skeletons for chats on web (#3496) Marcus Pasell [5e5c900] [] Add styling fixes from mobile playlist updates QA (#3485) Kyle Shanks [e182e8b] [PAY-1308] Use all messages for tracking latest received (#3484) Randy Schott [1e16ea8] Push props down to SelectPage (#3495) Andrew Mendelsohn [8993e52] [C-2705] Port upload files page to new upload form (#3493) Andrew Mendelsohn [986b621] [PAY-1303] Add toastSagas to mobile (#3488) Marcus Pasell [07c35e2] [PAY-1324][PAY-1326][PAY-1323][PAY-1327][PAY-1331][PAY-1328][PAY-1320] DMs UI fixes 2 (#3491) Michael Piazza [f37c767] [C-2658] Fix favorite Hot & New in sign up (#3492) Sebastian Klingler [404acd6] HOTFIX: left-nav delete-confirmation (#3490) Dylan Jeffers [89ac0a5] [C-2699] Fix collection action button sizes (#3487) Dylan Jeffers [bef1745] [PAY-1330][PAY-1317][PAY-1321] Polish DMs #1 (#3482) Michael Piazza [c7611a8] Rename addToast to registerToast (#3472) Marcus Pasell [614863c] [C-2700][C-2701] upload redesign feature flag and placeholder page (#3480) Andrew Mendelsohn [1f70aa4] [PAY-1316] DMs: Do the thing (Fix mobile chats not populating) (#3483) Marcus Pasell [4cf0c1e] [C-2702] Remove initialSelectedNode from disc-node selector (#3481) Dylan Jeffers [6063b9e] SDK v2.0.3 beta.32 (#3479) Marcus Pasell [c106ed8] [PAY-1283] DMs: Listen for chat messages app wide, and get unread message count on load (#3477) Marcus Pasell [8845ae7] [PAY-1329] Fix marking chats as unread (#3478) Reed [c6347af] Update end of message history copy on mobile (#3476) Reed [2700165] [PAY-1293] Adjust portal and animations to get more consistent behavior on Android (#3475) Randy Schott [afe7deb] [PAY-1295] DMs: Add a toast when chats fail to create (#3468) Marcus Pasell [72d2788] DMs: Rename "Thread" to "Conversation" (#3474) Marcus Pasell [5d69114] DMs: Add end of messages notice (#3466) Marcus Pasell [e35a23f] Change delete thread copy to conversation on mobile (#3473) Reed [31a6a55] [PAY-1301] DMs: Add empty state to search users modal (#3470) Marcus Pasell [032107c] [PAY-1292] DMs: Delete chat style updates (#3469) Marcus Pasell [7441321] [pay-1214] add patch to fix inverted list ANR bug (#3457) Randy Schott [018ff3b] [PAY-1291] Adds new message toast when scrolled up on mobile (#3463) Randy Schott [73b3ee0] Add developer apps page, call new SDK developer apps + grants APIs [C-2624] (#3396) nicoback2 [09f08b3] [PAY-1294] Max length for chat text input on mobile (#3465) Reed [ec305cb] [PAY-1278] Indicator for end of chat history on mobile (#3461) Reed [593914c] Filter out self from create chat search results on mobile (#3462) Reed [a42e359] Fix input with explicit input props (#3464) Dylan Jeffers [5ada3f5] [PAY-1138] Fix headers on Chats and fix old header prod bug (#3442) Michael Piazza [8966c0d] [C-2648] Add redesigned playlist management flow (#3456) Dylan Jeffers [5fa7468] [PAY-1297] DMs: Don't show current user in search results (#3460) Marcus Pasell [4a9824c] [C-2635] Fix offline playback; broken signature fetch (#3459) Andrew Mendelsohn [d93537b] [PAY-1246] Mobile delete chat thread UI (#3458) Reed [12107d4] [PAY-1288] DMs: Show max length in composer (#3454) Marcus Pasell [9f8b112] [PAY-1276] Mobile chats change color on press (#3446) Reed [bb53df1] [C-2646] Add idListArgKey for lists of entities; add fetchArgs types (#3452) Andrew Mendelsohn [a954dce] [INF-415] Upgrade to react-native 0.71.8 (#3429) Sebastian Klingler [1591fb2] Retry CodePush installs if they failed the first time C-2659 (#3451) nicoback2 [23f574b] Feature flag unread messages notif bubble (#3453) Reed
Description
The PR is to add duration metric tracking for all routes on Content Node. With this pr, metrics will be added to
/prometheus_metrics, and durations and response status codes will be tracked.Tests
/prometheus_metricsto ensure that the routes are trackedExample of snippet:
Monitoring - How will this change be monitored? Are there sufficient logs / alerts?
/prometheus_metricsfor the api routes to be tracked (will include the keyhttp_request_duration_seconds)DurationTrackinglogs in logs