[CON-301] add prometheus to queues by jonaylor89 · Pull Request #3595 · AudiusProject/apps

jonaylor89 · 2022-08-01T17:23:37Z

Description

This PR add prometheus metrics to many of the queues used for state monitoring and state reconciliation.

Sample metrics

audius_cn_jobs_waiting_duration_milliseconds_bucket{le="1622",status="completed",job_name="__default__",queue_name="find-sync-requests-queue",queue_prefix="bull"} 12
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="7114",status="completed",job_name="__default__",queue_name="find-sync-requests-queue",queue_prefix="bull"} 12
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="31197",status="completed",job_name="__default__",queue_name="find-sync-requests-queue",queue_prefix="bull"} 12
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="136815",status="completed",job_name="__default__",queue_name="find-sync-requests-queue",queue_prefix="bull"} 12
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="600000",status="completed",job_name="__default__",queue_name="find-sync-requests-queue",queue_prefix="bull"} 12
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="+Inf",status="completed",job_name="__default__",queue_name="find-sync-requests-queue",queue_prefix="bull"} 12
audius_cn_jobs_waiting_duration_milliseconds_sum{status="completed",job_name="__default__",queue_name="find-sync-requests-queue",queue_prefix="bull"} 9
audius_cn_jobs_waiting_duration_milliseconds_count{status="completed",job_name="__default__",queue_name="find-sync-requests-queue",queue_prefix="bull"} 12
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="1",status="completed",job_name="__default__",queue_name="find-replica-set-updates-queue",queue_prefix="bull"} 7
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="4",status="completed",job_name="__default__",queue_name="find-replica-set-updates-queue",queue_prefix="bull"} 12
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="19",status="completed",job_name="__default__",queue_name="find-replica-set-updates-queue",queue_prefix="bull"} 12
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="84",status="completed",job_name="__default__",queue_name="find-replica-set-updates-queue",queue_prefix="bull"} 12
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="370",status="completed",job_name="__default__",queue_name="find-replica-set-updates-queue",queue_prefix="bull"} 12
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="1622",status="completed",job_name="__default__",queue_name="find-replica-set-updates-queue",queue_prefix="bull"} 12
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="7114",status="completed",job_name="__default__",queue_name="find-replica-set-updates-queue",queue_prefix="bull"} 12
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="31197",status="completed",job_name="__default__",queue_name="find-replica-set-updates-queue",queue_prefix="bull"} 12
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="136815",status="completed",job_name="__default__",queue_name="find-replica-set-updates-queue",queue_prefix="bull"} 12
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="600000",status="completed",job_name="__default__",queue_name="find-replica-set-updates-queue",queue_prefix="bull"} 12
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="+Inf",status="completed",job_name="__default__",queue_name="find-replica-set-updates-queue",queue_prefix="bull"} 12
audius_cn_jobs_waiting_duration_milliseconds_sum{status="completed",job_name="__default__",queue_name="find-replica-set-updates-queue",queue_prefix="bull"} 18
audius_cn_jobs_waiting_duration_milliseconds_count{status="completed",job_name="__default__",queue_name="find-replica-set-updates-queue",queue_prefix="bull"} 12
# HELP audius_cn_jobs_attempts Job attempts made
# TYPE audius_cn_jobs_attempts histogram
audius_cn_jobs_attempts_bucket{le="1",status="completed",job_name="__default__",queue_name="c-node-to-endpoint-sp-id-map-queue",queue_prefix="bull"} 19
audius_cn_jobs_attempts_bucket{le="4",status="completed",job_name="__default__",queue_name="c-node-to-endpoint-sp-id-map-queue",queue_prefix="bull"} 19
audius_cn_jobs_attempts_bucket{le="19",status="completed",job_name="__default__",queue_name="c-node-to-endpoint-sp-id-map-queue",queue_prefix="bull"} 19
audius_cn_jobs_attempts_bucket{le="84",status="completed",job_name="__default__",queue_name="c-node-to-endpoint-sp-id-map-queue",queue_prefix="bull"} 19
audius_cn_jobs_attempts_bucket{le="370",status="completed",job_name="__default__",queue_name="c-node-to-endpoint-sp-id-map-queue",queue_prefix="bull"} 19
audius_cn_jobs_attempts_bucket{le="1622",status="completed",job_name="__default__",queue_name="c-node-to-endpoint-sp-id-map-queue",queue_prefix="bull"} 19
audius_cn_jobs_attempts_bucket{le="7114",status="completed",job_name="__default__",queue_name="c-node-to-endpoint-sp-id-map-queue",queue_prefix="bull"} 19
audius_cn_jobs_attempts_bucket{le="31197",status="completed",job_name="__default__",queue_name="c-node-to-endpoint-sp-id-map-queue",queue_prefix="bull"} 19
audius_cn_jobs_attempts_bucket{le="136815",status="completed",job_name="__default__",queue_name="c-node-to-endpoint-sp-id-map-queue",queue_prefix="bull"} 19
audius_cn_jobs_attempts_bucket{le="600000",status="completed",job_name="__default__",queue_name="c-node-to-endpoint-sp-id-map-queue",queue_prefix="bull"} 19
audius_cn_jobs_attempts_bucket{le="+Inf",status="completed",job_name="__default__",queue_name="c-node-to-endpoint-sp-id-map-queue",queue_prefix="bull"} 19
audius_cn_jobs_attempts_sum{status="completed",job_name="__default__",queue_name="c-node-to-endpoint-sp-id-map-queue",queue_prefix="bull"} 0
audius_cn_jobs_attempts_count{status="completed",job_name="__default__",queue_name="c-node-to-endpoint-sp-id-map-queue",queue_prefix="bull"} 19
audius_cn_jobs_attempts_bucket{le="1",status="completed",job_name="__default__",queue_name="monitor-state-queue",queue_prefix="bull"} 12

or

audius_cn_jobs_waiting_duration_milliseconds_sum{status="completed",job_name="__default__",queue_name="c-node-to-endpoint-sp-id-map-queue",queue_prefix="bull"} 513404
audius_cn_jobs_waiting_duration_milliseconds_count{status="completed",job_name="__default__",queue_name="c-node-to-endpoint-sp-id-map-queue",queue_prefix="bull"} 57
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="1",status="completed",job_name="__default__",queue_name="monitor-state-queue",queue_prefix="bull"} 5
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="4",status="completed",job_name="__default__",queue_name="monitor-state-queue",queue_prefix="bull"} 17
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="19",status="completed",job_name="__default__",queue_name="monitor-state-queue",queue_prefix="bull"} 18
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="84",status="completed",job_name="__default__",queue_name="monitor-state-queue",queue_prefix="bull"} 18
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="370",status="completed",job_name="__default__",queue_name="monitor-state-queue",queue_prefix="bull"} 18
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="1622",status="completed",job_name="__default__",queue_name="monitor-state-queue",queue_prefix="bull"} 18
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="7114",status="completed",job_name="__default__",queue_name="monitor-state-queue",queue_prefix="bull"} 18
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="31197",status="completed",job_name="__default__",queue_name="monitor-state-queue",queue_prefix="bull"} 19
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="136815",status="completed",job_name="__default__",queue_name="monitor-state-queue",queue_prefix="bull"} 27
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="600000",status="completed",job_name="__default__",queue_name="monitor-state-queue",queue_prefix="bull"} 27
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="+Inf",status="completed",job_name="__default__",queue_name="monitor-state-queue",queue_prefix="bull"} 27
audius_cn_jobs_waiting_duration_milliseconds_sum{status="completed",job_name="__default__",queue_name="monitor-state-queue",queue_prefix="bull"} 509364
audius_cn_jobs_waiting_duration_milliseconds_count{status="completed",job_name="__default__",queue_name="monitor-state-queue",queue_prefix="bull"} 27
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="1",status="completed",job_name="__default__",queue_name="find-sync-requests-queue",queue_prefix="bull"} 24
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="4",status="completed",job_name="__default__",queue_name="find-sync-requests-queue",queue_prefix="bull"} 27
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="19",status="completed",job_name="__default__",queue_name="find-sync-requests-queue",queue_prefix="bull"} 27
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="84",status="completed",job_name="__default__",queue_name="find-sync-requests-queue",queue_prefix="bull"} 27
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="370",status="completed",job_name="__default__",queue_name="find-sync-requests-queue",queue_prefix="bull"} 27
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="1622",status="completed",job_name="__default__",queue_name="find-sync-requests-queue",queue_prefix="bull"} 27
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="7114",status="completed",job_name="__default__",queue_name="find-sync-requests-queue",queue_prefix="bull"} 27
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="31197",status="completed",job_name="__default__",queue_name="find-sync-requests-queue",queue_prefix="bull"} 27
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="136815",status="completed",job_name="__default__",queue_name="find-sync-requests-queue",queue_prefix="bull"} 27
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="600000",status="completed",job_name="__default__",queue_name="find-sync-requests-queue",queue_prefix="bull"} 27
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="+Inf",status="completed",job_name="__default__",queue_name="find-sync-requests-queue",queue_prefix="bull"} 27
audius_cn_jobs_waiting_duration_milliseconds_sum{status="completed",job_name="__default__",queue_name="find-sync-requests-queue",queue_prefix="bull"} 23
audius_cn_jobs_waiting_duration_milliseconds_count{status="completed",job_name="__default__",queue_name="find-sync-requests-queue",queue_prefix="bull"} 27
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="1",status="completed",job_name="__default__",queue_name="find-replica-set-updates-queue",queue_prefix="bull"} 20
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="4",status="completed",job_name="__default__",queue_name="find-replica-set-updates-queue",queue_prefix="bull"} 26
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="19",status="completed",job_name="__default__",queue_name="find-replica-set-updates-queue",queue_prefix="bull"} 27
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="84",status="completed",job_name="__default__",queue_name="find-replica-set-updates-queue",queue_prefix="bull"} 27
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="370",status="completed",job_name="__default__",queue_name="find-replica-set-updates-queue",queue_prefix="bull"} 27
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="1622",status="completed",job_name="__default__",queue_name="find-replica-set-updates-queue",queue_prefix="bull"} 27
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="7114",status="completed",job_name="__default__",queue_name="find-replica-set-updates-queue",queue_prefix="bull"} 27
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="31197",status="completed",job_name="__default__",queue_name="find-replica-set-updates-queue",queue_prefix="bull"} 27
audius_cn_jobs_waiting_duration_milliseconds_bucket{le="136815",status="completed",job_name="__default__",queue_name="find-replica-set-updates-queue",queue_prefix="bull"} 27

Tests

Run locally and tested with A seed upload-track and checking the metrics on localhost:4000/prometheus_metrics

Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

These changes will be monitored with prometheus metrics

JOBS_ACTIVE_TOTAL_GAUGE: 'jobs_active_total',
JOBS_WAITING_TOTAL_GAUGE: 'jobs_waiting_total',
JOBS_COMPLETED_TOTAL_GAUGE: 'jobs_completed_total',
JOBS_FAILED_TOTAL_GAUGE: 'jobs_failed_total',
JOBS_DELAYED_TOTAL_GAUGE: 'jobs_delayed_total',
JOBS_DURATION_SECONDS_HISTOGRAM: 'jobs_duration_seconds',
JOBS_WAITING_DURATION_SECONDS_HISTOGRAM: 'jobs_waiting_duration_seconds',
JOBS_ATTEMPTS_HISTOGRAM: 'jobs_attempts'

and soon grafana panels

vicky-g · 2022-08-01T20:36:00Z

can we replace the __default__ job names with the actual job names here too? if there are any differing jobs in these queues.

some other queues we should monitor should be the imageProcessingQueue, transcodingQueue, updateReplicaSetQueue. I would take a look at these queues here https://github.com/AudiusProject/audius-protocol/blob/master/creator-node/src/serviceRegistry.js#L51

theoilie

good stuff! couple nits/questions:

I'm wondering why this uses ms instead of seconds like the other prometheus metrics?
can we remove the prefix label? I don't think we ever change it from "bull"
it looks like the JOBS_DURATION_MILLISECONDS_HISTOGRAM tracks job runtime? if so, we should exclude the jobs from the metric that already tracks that to avoid duplication in the STATE_MACHINE_${jobName}_JOB_DURATION_SECONDS_HISTOGRAM metric -- see here

jonaylor89 · 2022-08-01T20:51:22Z

good stuff! couple nits/questions:
I'm wondering why this uses ms instead of seconds like the other prometheus metrics?
can we remove the prefix label? I don't think we ever change it from "bull"
it looks like the JOBS_DURATION_MILLISECONDS_HISTOGRAM tracks job runtime? if so, we should exclude the jobs from the metric that already tracks that to avoid duplication in the STATE_MACHINE_${jobName}_JOB_DURATION_SECONDS_HISTOGRAM metric -- see here

I think ms makes a ton of sense since bull itself calculates duration with milliseconds and most of the jobs only take less than a second anyway. It's also made pretty explicit that it's ms because of the metric name so I don't think there should be any confusion. I can get rid of them though if we want to keep things standard across every metric
I found the prefix a really easy thing to grep when searching for metrics but I can remove it if you think it adds too much noise. The alternatives are greping for JOB or queue but those seemed pretty ambiguous.
Would it instead make sense to just get rid of those original job duration metrics in favor of the generalized bull queue metrics?

jonaylor89 · 2022-08-01T21:31:29Z

can we replace the __default__ job names with the actual job names here too? if there are any differing jobs in these queues.
some other queues we should monitor should be the imageProcessingQueue, transcodingQueue, updateReplicaSetQueue. I would take a look at these queues here https://github.com/AudiusProject/audius-protocol/blob/master/creator-node/src/serviceRegistry.js#L51

I think for anything state machine related, it only runs one job type

vicky-g · 2022-08-01T21:38:23Z

can we replace the __default__ job names with the actual job names here too? if there are any differing jobs in these queues.
some other queues we should monitor should be the imageProcessingQueue, transcodingQueue, updateReplicaSetQueue. I would take a look at these queues here https://github.com/AudiusProject/audius-protocol/blob/master/creator-node/src/serviceRegistry.js#L51
I think for anything state machine related, it only runs one job type

let's confirm this just to be sure. if it's just one job, then it's okay to not add job names!

theoilie · 2022-08-01T21:48:50Z

@jonaylor89

sounds good -- just wanted to check
sorry, I wasn't super clear about that. I actually meant the label called queue_prefix
for sure -- you should be able to exclude an array of already-tracked jobs from the original job metrics here and then do a .filter() for that array here

jonaylor89 · 2022-08-01T22:15:18Z

Quick note from a call @vicky-g and I had - skipping adding metrics to TranscodeQueue because adding metrics would require a bit more of a systemic lift. Should be something added later down the line though

jonaylor89 · 2022-08-02T01:26:59Z

3. for sure -- you should be able to exclude an array of already-tracked jobs from the original job metrics here and then do a .filter() for that array here

This PR adds metrics to all of those queues so no need to do a .filter(), we can just delete the old metrics

jonaylor89 · 2022-08-02T01:28:25Z

for sure -- you should be able to exclude an array of already-tracked jobs from the original job metrics here and then do a .filter() for that array here
This PR adds metrics to all of those queues so no need to do a .filter(), we can just delete the old metrics

Or actually, let's keep these for now because I want to see if the labels show anything different.

theoilie

one small question but LGTM! maybe we should have a Linear card to make sure we clean up the original duplicate duration monitoring metrics for state machine?

SidSethi · 2022-08-02T13:55:41Z

btw, all prometheus metrics are meant to be recorded as seconds, or the "base unit" per docs https://prometheus.io/docs/practices/naming/

SidSethi

an additional test in prometheus.test.js might be valuable?

jonaylor89 · 2022-08-02T15:25:38Z

btw, all prometheus metrics are meant to be recorded as seconds, or the "base unit" per docs https://prometheus.io/docs/practices/naming/

Gotcha, I can change it over to seconds then,

SidSethi · 2022-08-02T16:26:52Z

tests broken

## Changelog - 2022-08-04 [be35ce8] INF-210 fix || exit 1 logic (#3635) [Joaquin Casares] - 2022-08-04 [ae4bd30] [C-765] Add native libs entrypoint (#3626) [Dylan Jeffers] - 2022-08-04 [1e04215] [C-739] Patch @openzeppelin/upgrades Initializable.sol fields (#3584) [Dylan Jeffers] - 2022-08-04 [01f924a] Fix add track to playlist notification timestamp (#3629) [Isaac Solo] - 2022-08-03 [fcfdc3e] Remove unused labels (#3628) [Theo Ilie] - 2022-08-03 [2d2fcca] [CON-301] add prometheus to queues (#3595) [Johannes Naylor] - 2022-08-03 [798b7fa] CON-303 Cache CN 200-status /health_check responses for 1sec in nginx (#3624) [Sid Sethi] - 2022-08-03 [b33a56c] Throw error in syncImmediateQueue (#3625) [Dheeraj Manjunath] - 2022-08-03 [1239375] Tests for aggregate table triggers (#3623) [Steve Perkins] - 2022-08-03 [e164665] INF-210 Finishing changes (#3617) [Joaquin Casares] - 2022-08-03 [9b5f4c9] New queue for immediate sync (#3619) [Dheeraj Manjunath] - 2022-08-03 [5cef789] Fix attemptNumber not getting updated + increase queue histories (#3622) [Theo Ilie] - 2022-08-03 [683d545] Related artists index2 (#3621) [Steve Perkins] - 2022-08-03 [c3a0149] Change path due to recent libs change (#3620) [Cheran] - 2022-08-03 [216bf25] Land #21 from docs.audius.org (#3514) [Raymond Jacobson] - 2022-08-02 [54713a7] [C-736] Refactor AudiusLibs to typescript (#3597) [Dylan Jeffers] - 2022-08-02 [54b7db8] Fix runtime includes TypeError (#3178) [Dylan Jeffers] - 2022-08-02 [89e0db2] Bump sdk to v0.0.29 [audius-infra]

## Changelog - 2022-08-04 [2d720a6] Fix bundles (#3639) [Sebastian Klingler] - 2022-08-04 [d2b051d] INF-210 grab VERSION after exiting subshell that bumped version (#3636) [Joaquin Casares] - 2022-08-04 [27433f5] Remove extra done() callback and add sync job result (#3634) [Theo Ilie] - 2022-08-04 [be35ce8] INF-210 fix || exit 1 logic (#3635) [Joaquin Casares] - 2022-08-04 [ae4bd30] [C-765] Add native libs entrypoint (#3626) [Dylan Jeffers] - 2022-08-04 [1e04215] [C-739] Patch @openzeppelin/upgrades Initializable.sol fields (#3584) [Dylan Jeffers] - 2022-08-04 [01f924a] Fix add track to playlist notification timestamp (#3629) [Isaac Solo] - 2022-08-03 [fcfdc3e] Remove unused labels (#3628) [Theo Ilie] - 2022-08-03 [2d2fcca] [CON-301] add prometheus to queues (#3595) [Johannes Naylor] - 2022-08-03 [798b7fa] CON-303 Cache CN 200-status /health_check responses for 1sec in nginx (#3624) [Sid Sethi] - 2022-08-03 [b33a56c] Throw error in syncImmediateQueue (#3625) [Dheeraj Manjunath] - 2022-08-03 [1239375] Tests for aggregate table triggers (#3623) [Steve Perkins] - 2022-08-03 [e164665] INF-210 Finishing changes (#3617) [Joaquin Casares] - 2022-08-03 [9b5f4c9] New queue for immediate sync (#3619) [Dheeraj Manjunath] - 2022-08-03 [5cef789] Fix attemptNumber not getting updated + increase queue histories (#3622) [Theo Ilie] - 2022-08-03 [683d545] Related artists index2 (#3621) [Steve Perkins] - 2022-08-03 [c3a0149] Change path due to recent libs change (#3620) [Cheran] - 2022-08-03 [216bf25] Land #21 from docs.audius.org (#3514) [Raymond Jacobson] - 2022-08-02 [54713a7] [C-736] Refactor AudiusLibs to typescript (#3597) [Dylan Jeffers] - 2022-08-02 [54b7db8] Fix runtime includes TypeError (#3178) [Dylan Jeffers] - 2022-08-02 [89e0db2] Bump sdk to v0.0.29 [audius-infra]

## Changelog - 2022-08-04 [a3556c3] include v as VERSION prefix (#3641) [Joaquin Casares] - 2022-08-04 [7755c57] Update SDK (#3633) [Michael Piazza] - 2022-08-04 [3f6256f] INF-210 rename GIT_TAG to GIT_COMMIT (#3637) [Joaquin Casares] - 2022-08-04 [2d720a6] Fix bundles (#3639) [Sebastian Klingler] - 2022-08-04 [d2b051d] INF-210 grab VERSION after exiting subshell that bumped version (#3636) [Joaquin Casares] - 2022-08-04 [27433f5] Remove extra done() callback and add sync job result (#3634) [Theo Ilie] - 2022-08-04 [be35ce8] INF-210 fix || exit 1 logic (#3635) [Joaquin Casares] - 2022-08-04 [ae4bd30] [C-765] Add native libs entrypoint (#3626) [Dylan Jeffers] - 2022-08-04 [1e04215] [C-739] Patch @openzeppelin/upgrades Initializable.sol fields (#3584) [Dylan Jeffers] - 2022-08-04 [01f924a] Fix add track to playlist notification timestamp (#3629) [Isaac Solo] - 2022-08-03 [fcfdc3e] Remove unused labels (#3628) [Theo Ilie] - 2022-08-03 [2d2fcca] [CON-301] add prometheus to queues (#3595) [Johannes Naylor] - 2022-08-03 [798b7fa] CON-303 Cache CN 200-status /health_check responses for 1sec in nginx (#3624) [Sid Sethi] - 2022-08-03 [b33a56c] Throw error in syncImmediateQueue (#3625) [Dheeraj Manjunath] - 2022-08-03 [1239375] Tests for aggregate table triggers (#3623) [Steve Perkins] - 2022-08-03 [e164665] INF-210 Finishing changes (#3617) [Joaquin Casares] - 2022-08-03 [9b5f4c9] New queue for immediate sync (#3619) [Dheeraj Manjunath] - 2022-08-03 [5cef789] Fix attemptNumber not getting updated + increase queue histories (#3622) [Theo Ilie] - 2022-08-03 [683d545] Related artists index2 (#3621) [Steve Perkins] - 2022-08-03 [c3a0149] Change path due to recent libs change (#3620) [Cheran] - 2022-08-03 [216bf25] Land #21 from docs.audius.org (#3514) [Raymond Jacobson] - 2022-08-02 [54713a7] [C-736] Refactor AudiusLibs to typescript (#3597) [Dylan Jeffers] - 2022-08-02 [54b7db8] Fix runtime includes TypeError (#3178) [Dylan Jeffers] - 2022-08-02 [89e0db2] Bump sdk to v0.0.29 [audius-infra]

[1957c34] Add remove from playlist overflow action (#3621) Kyle Shanks [67e0012] [C-2712] Clear favorites on sign-out (#3620) Dylan Jeffers [97b6b94] [PAY-1421] Fix android reaction offsets (#3611) Michael Piazza [9867571] [PAY-1494] Change chats copy to beginning of message history (#3617) Reed [1b7ca71] Add overflow menu options for track list items on mobile (#3608) Kyle Shanks [810f0df] [PAY-1487] Increase hit slop of mobile dms send button (#3618) Reed [06dae51] [PAY-1470] Remove border radius from track/playlist tiles (#3613) Marcus Pasell [dbdfb84] [PAY-1469] Clear the search after creating a chat (#3616) Marcus Pasell [3f31554] [PAY-1489] Add more space to reacted to messages (#3615) Marcus Pasell [ed4f321] [PAY-1473] Clear input on chat change (#3614) Marcus Pasell [e9683d9] Use emojis instead of 'heart' etc as reactions (#3602) Marcus Pasell [192fd44] [PAY-1486] DMs: Fix purple border around unfurls (#3612) Marcus Pasell [b0c2e4a] Lowercase library restricted handle (#3590) Isaac Solo [a8daa72] Change text to 'Beginning of Conversation' (#3605) Marcus Pasell [332c0c0] Developer app modal - small fixes (#3609) nicoback2 [0e43db1] [PAY-1476] Inbox unavailable copy update (#3607) Reed [d862fd5] [PAY-1484] Allow reactions while keyboard is open on mobile (#3606) Reed [3bd5928] [PAY-944] DMs: Add Mobile Web drawer prompting app download (#3565) Marcus Pasell [5bea105] Wait for libs to init before initting SDK (#3604) Marcus Pasell [f4d28e0] Add option to cache bust node_modules (#3603) Dylan Jeffers [9b165c4] [PAY-1455] Optimize reactions perf (maybe) (#3599) Michael Piazza [0a1a68b] [PAY-1465] Auto-nav to chat only when permitted (#3598) Reed [72e9f92] [C-2665 C-2714] Add developer apps settings modal (#3589) Dylan Jeffers [b787344] [PAY-1456] Fix followee-gated create chat crash (#3593) Reed [dbae5bd] Reduce MessageLockedButton size on profile screen (#3597) Reed [097879b] [PAY-1437] Fix drawers sharing state causing crash (#3595) Reed [818b215] [C-2770] Fix issue where playlist library can disappear (#3596) Dylan Jeffers [f3ada88] [PAY-1461] Format follower count in chat search screen (#3594) Reed [eb924e7] [C-2713] Add track metadata fields to new upload form (#3574) Andrew Mendelsohn [be56d1f] Fix mobile textinput borders + labels (#3592) Reed [fc7541b] Update collection list id flow to add the create tile (#3591) Kyle Shanks [dc15518] [PAY-1432] Fix chat playlist artist sometimes undefined (#3585) Reed [399d0b5] [C-2588] Update share modal and drawer to properly add user twitter handle (#3584) Kyle Shanks [9f30855] [C-2761] Add mutations to audius-query (#3581) Dylan Jeffers [597dfe5] [PAY-1448] End the race between SDK and Libs, once and for all (#3588) Marcus Pasell [56914cf] [C-2768] Update InputV2, add TextField/TextAreaField (#3587) Dylan Jeffers [c9358b6] [CON-742] Make users and track actions v2 for v2 users/tracks even when feature flags are disabled (#3582) Theo Ilie [a94f035] audius-query debug flag usage in README (#3586) Reed [bceb3fe] [INF-417] Generate sourcemaps when running web:prod (#3583) Sebastian Klingler [f4ad466] [PAY-1454] Redline mobile header to latest figma design (#3576) Michael Piazza [eec6af0] [PAY-1405] Add padding to bottom of chat user search screen (#3580) Reed [a6c8ece] [PAY-1435] Navigate to chat after unblocking user on mobile (#3578) Reed [ee1b6c3] [PLAT-659] Metamask sign in/up on ACDC (#3563) Raymond Jacobson [fbd4053] [C-2472] Update mobile track list items for playlists to have the overflow menu (#3577) Kyle Shanks [51f44ac] [PAY-1399] Fix Android chat send button color (#3575) Reed [7d440de] [PAY-1442] Fix drawer touchables on android (#3572) Reed [8c90ff6] Allow drag and dropping tracks into chat (#3573) Michael Piazza [f7489e0] Upgrade dapp store version to v1.5.26 (#3504) Dylan Jeffers [6be0c64] [PAY-1440][PAY-1441] Mobile inbox settings UI fixes (#3571) Reed [001007e] [PAY-1434] Dismiss keyboard on create chat screen row press (#3569) Reed [c70e9fe] [PAY-1446] Set MessageLocked icon in profile screen to 0.4 opacity (#3570) Reed [2cc8ad0] [C-2716] Improve notifications on fresh account (#3568) Dylan Jeffers [01f05ba] [C-2474] Generate playlist artwork from track artwork (#3518) Dylan Jeffers [0355c10] [PAY-1325] Remove userbadges from chat unavailable message in chat screen (#3567) Reed [da10bbc] [PAY-1389] CTA on create chat when not permitted (#3566) Reed

add prometheus to queues
fb0e5a7

jonaylor89 requested review from SidSethi and theoilie August 1, 2022 17:23

pull-request-sizeBot added the size/S label Aug 1, 2022

jonaylor89 added 3 commits August 1, 2022 17:42

add null check
14b1c49

fix tests
a274b64

rm segments
65a08aa

pull-request-sizeBot added size/L and removed size/S labels Aug 1, 2022

rm test track
36a14ff

pull-request-sizeBot added size/M and removed size/L labels Aug 1, 2022

jonaylor89 marked this pull request as ready for review August 1, 2022 18:33

theoilie reviewed Aug 1, 2022
View reviewed changes

add metrics to more queues
84dcb20

jonaylor89 added 2 commits August 1, 2022 22:12

remov
c9b1070

Merge branch 'master' into con-301
728734a

jonaylor89 added 7 commits August 1, 2022 22:36

lint
560191b

rm unused var
b96b497

adds labels
c4b1a25

refactor
34e18d7

refactor
6e12ccd

typo
cdc0a48

fix tests
9ad870c

jonaylor89 requested a review from theoilie August 2, 2022 01:41

theoilie approved these changes Aug 2, 2022
View reviewed changes

Comment threadcreator-node/test/playlists.test.js Outdated

SidSethi reviewed Aug 2, 2022
View reviewed changes

Comment threadcreator-node/src/services/prometheusMonitoring/prometheusRegistry.ts

SidSethi reviewed Aug 2, 2022
View reviewed changes

Comment threadcreator-node/src/ImageProcessingQueue.js

.only()
4b06f18

jonaylor89 added 2 commits August 2, 2022 15:30

ms to s
478017a

add simple test
90b246b

pull-request-sizeBot added size/L and removed size/M labels Aug 2, 2022

jonaylor89 requested a review from SidSethi August 2, 2022 15:43

jonaylor89 added 4 commits August 2, 2022 20:36

add test
065fb7a

ms to s
98dcf38

Merge branch 'master' into con-301
e369b03

linting
50558d3

jonaylor89 merged commit 2d2fcca into masterAug 4, 2022

jonaylor89 deleted the con-301 branch August 4, 2022 01:19

sliptype pushed a commit that referenced this pull request Sep 10, 2023
[PAY-1437] Fix drawers sharing state causing crash (#3595)
f4fa6f5

AudiusProject deleted a comment from linearBotSep 11, 2023

Uh oh!

Conversation

jonaylor89 commented Aug 1, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Tests

Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

Uh oh!

vicky-g commented Aug 1, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theoilie left a comment

Choose a reason for hiding this comment

Uh oh!

jonaylor89 commented Aug 1, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonaylor89 commented Aug 1, 2022

Uh oh!

vicky-g commented Aug 1, 2022

Uh oh!

theoilie commented Aug 1, 2022

Uh oh!

jonaylor89 commented Aug 1, 2022

Uh oh!

jonaylor89 commented Aug 2, 2022

Uh oh!

jonaylor89 commented Aug 2, 2022

Uh oh!

theoilie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

SidSethi commented Aug 2, 2022

Uh oh!

SidSethi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jonaylor89 commented Aug 2, 2022

Uh oh!

SidSethi commented Aug 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jonaylor89 commented Aug 1, 2022•
edited
Loading

vicky-g commented Aug 1, 2022•
edited
Loading

jonaylor89 commented Aug 1, 2022•
edited
Loading