Skip to content

[PAY-485][PAY-491] Handle premium content signature - #3610

Merged
sddioulde merged 11 commits into
masterfrom
sd-premium-content-signature
Aug 11, 2022
Merged

[PAY-485][PAY-491] Handle premium content signature#3610
sddioulde merged 11 commits into
masterfrom
sd-premium-content-signature

Conversation

@sddioulde

@sddiouldesddioulde commented Aug 2, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • Add function to generate signature for premium content in DN
  • Add premium content signature recovery and verification middleware in CN

Added @types/express in CN too to import types like Request, Response, etc.

Tests

  • Added a unit test for the signature generation and recovery in DN
  • Manually tested that recoverWallet does correctly get the wallet of the signer (DN) given the signed data and signature from DN
  • Added tests for the signature verification in CN

Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

There are logs at different parts of the flow to help with debugging.

piazzatron
piazzatron reviewed Aug 4, 2022
View reviewed changes

@piazzatronpiazzatron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, awesome job with the tests! Mostly nits - let's also get @SidSethi and @vicky-g's eyes on this before we merge

Comment threadcreator-node/src/apiSigning.js Outdated
Comment threadcreator-node/src/middlewares/premiumContent/premiumContentMiddleware.ts
Comment threadcreator-node/src/premiumContent/types.ts
Comment threadcreator-node/src/premiumContent/helpers.ts Outdated
Comment threadcreator-node/src/premiumContent/helpers.ts Outdated
Comment threadcreator-node/src/middlewares/premiumContent/premiumContentMiddleware.ts Outdated
Comment threadcreator-node/src/middlewares/premiumContent/premiumContentMiddleware.ts
Comment threadcreator-node/src/middlewares/premiumContent/premiumContentMiddleware.ts Outdated
Comment threadcreator-node/src/utils.js Outdated
Comment threadcreator-node/src/utils.js Outdated
@sddioulde
sddioulde requested a review from vicky-gAugust 8, 2022 16:52
@sddioulde
sddiouldeforce-pushed the sd-premium-content-signature branch from 04f803c to 5311c83CompareAugust 9, 2022 14:18
vicky-g
vicky-g reviewed Aug 9, 2022
View reviewed changes
Comment threadcreator-node/src/utils/registeredNodes.ts Outdated
vicky-g
vicky-g reviewed Aug 9, 2022
View reviewed changes
Comment threadcreator-node/src/premiumContent/helpers.ts Outdated
SidSethi
SidSethi reviewed Aug 9, 2022
View reviewed changes

@SidSethiSidSethi left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few small things in addition to other folks previous comments, generally looks great!!
also appreciate the test coverage

Comment threadcreator-node/scripts/run-tests.sh
Comment threadcreator-node/src/apiSigning.js Outdated
Comment threadcreator-node/src/middlewares/premiumContent/premiumContentMiddleware.test.ts
Comment threadcreator-node/src/utils/registeredNodes.ts
Comment threadcreator-node/src/utils/registeredNodes.ts
Comment threadcreator-node/src/utils/registeredNodes.ts
Comment threadcreator-node/src/middlewares/premiumContent/premiumContentMiddleware.ts
Comment threadcreator-node/src/premiumContent/helpers.ts
@sddioulde
sddiouldeforce-pushed the sd-premium-content-signature branch from d72eb45 to 1b66eedCompareAugust 10, 2022 15:56
@sddioulde
sddiouldeforce-pushed the sd-premium-content-signature branch from 1b66eed to ed83ea6CompareAugust 10, 2022 16:03
vicky-g
vicky-g reviewed Aug 11, 2022
View reviewed changes
Comment threadcreator-node/src/apiSigning.js
vicky-g
vicky-g approved these changes Aug 11, 2022
View reviewed changes

@vicky-gvicky-g left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! one small thing about adding a comment for fetching registered DNs

SidSethi
SidSethi approved these changes Aug 11, 2022
View reviewed changes

@SidSethiSidSethi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Comment threadcreator-node/src/utils/getRegisteredDiscoveryNodes.ts Outdated
@sddioulde
sddioulde merged commit 23a6c3b into masterAug 11, 2022
@sddioulde
sddioulde deleted the sd-premium-content-signature branch August 11, 2022 21:51
audius-infra pushed a commit that referenced this pull request Aug 12, 2022
audius-infra
Bump sdk to v0.0.34
4143fbb
## Changelog
- 2022-08-12 [c38a6a8] Update @solana/spl-token to 0.1.8 (#3689) [Marcus Pasell]
- 2022-08-12 [587b38e] CON-327 Miscellaneous secondarySyncFromPrimary() improvements to logic + metric tracking (#3678) [Sid Sethi]
- 2022-08-12 [1afa5d5] [CON-324] Add orphaned data recovery queue (#3680) [Theo Ilie]
- 2022-08-12 [10599f4] Handle zero error code (#3686) [Saliou Diallo]
- 2022-08-12 [2346960] Use abuse error codes in relay (#3683) [Raymond Jacobson]
- 2022-08-12 [c3f578e] populate save_count in feed endpoint (#3684) [Steve Perkins]
- 2022-08-11 [5e6217f] Revert "[PLAT-259] Upgrade EthereumTx version (#3606)" (#3682) [Raymond Jacobson]
- 2022-08-11 [a44aad2] Fix bad notifs (#3681) [Saliou Diallo]
- 2022-08-11 [23a6c3b] [PAY-485][PAY-491] Handle premium content signature (#3610) [Saliou Diallo]
- 2022-08-11 [a478a1d] [PAY-459] Add dethroned notifications on Identity (#3674) [Michael Piazza]
- 2022-08-11 [8fb6084] Add a log before force resync happen (#3677) [vicky :)]
- 2022-08-11 [47f55f4] [PAY-506] Exposes AAO error code (#3662) [Reed]
- 2022-08-11 [4bc58cf] Filter out notifications from bad initiators (#3676) [Saliou Diallo]
- 2022-08-11 [e01c91c] Prevent extra unnecessary reconfig events (#3671) [vicky :)]
- 2022-08-11 [cff11a9] Fix downgrades (#3667) [Joseph Lee]
- 2022-08-11 [424ff50] Add disable flag to logspout (#3672) [Dheeraj Manjunath]
- 2022-08-11 [bac7669] Bump sdk to v0.0.33 [audius-infra]
audius-infra pushed a commit that referenced this pull request Aug 12, 2022
audius-infra
Bump sdk to v0.0.34
82dcf35
## Changelog
- 2022-08-12 [c38a6a8] Update @solana/spl-token to 0.1.8 (#3689) [Marcus Pasell]
- 2022-08-12 [587b38e] CON-327 Miscellaneous secondarySyncFromPrimary() improvements to logic + metric tracking (#3678) [Sid Sethi]
- 2022-08-12 [1afa5d5] [CON-324] Add orphaned data recovery queue (#3680) [Theo Ilie]
- 2022-08-12 [10599f4] Handle zero error code (#3686) [Saliou Diallo]
- 2022-08-12 [2346960] Use abuse error codes in relay (#3683) [Raymond Jacobson]
- 2022-08-12 [c3f578e] populate save_count in feed endpoint (#3684) [Steve Perkins]
- 2022-08-11 [5e6217f] Revert "[PLAT-259] Upgrade EthereumTx version (#3606)" (#3682) [Raymond Jacobson]
- 2022-08-11 [a44aad2] Fix bad notifs (#3681) [Saliou Diallo]
- 2022-08-11 [23a6c3b] [PAY-485][PAY-491] Handle premium content signature (#3610) [Saliou Diallo]
- 2022-08-11 [a478a1d] [PAY-459] Add dethroned notifications on Identity (#3674) [Michael Piazza]
- 2022-08-11 [8fb6084] Add a log before force resync happen (#3677) [vicky :)]
- 2022-08-11 [47f55f4] [PAY-506] Exposes AAO error code (#3662) [Reed]
- 2022-08-11 [4bc58cf] Filter out notifications from bad initiators (#3676) [Saliou Diallo]
- 2022-08-11 [e01c91c] Prevent extra unnecessary reconfig events (#3671) [vicky :)]
- 2022-08-11 [cff11a9] Fix downgrades (#3667) [Joseph Lee]
- 2022-08-11 [424ff50] Add disable flag to logspout (#3672) [Dheeraj Manjunath]
- 2022-08-11 [bac7669] Bump sdk to v0.0.33 [audius-infra]
dmanjunath pushed a commit that referenced this pull request Aug 16, 2022
@sddiouldeSaliou Diallo@dmanjunath
[PAY-485][PAY-491] Handle premium content signature (#3610)
3db7d3a
* Add premium content signature generation in DN
* Add premium content signature verification middleware in CN
* Add typescript to eslint and add mocha types
* Add premiumContentMiddleware tests and refactor
* Run typescript unit tests
* Clean up
* Move getAllRegisteredDNodes to typescript file
* Refactor
* Add comments
* Add retries to fetching registered discovery nodes
* Update type
Co-authored-by: Saliou Diallo <saliou@audius.co>
sliptype pushed a commit that referenced this pull request Sep 10, 2023
@amendelsohn
[C-2676] Rough release date modal (#3610)
930a352
sliptype pushed a commit that referenced this pull request Sep 10, 2023
audius-infra
v1.5.30
ecc0d94
[fe5fda4] Fix entity button widths (#3650) Dylan Jeffers
[820e79e] Fix user profile always showing artist tabs (#3648) Dylan Jeffers
[bc34b6f] [C-2697] Fix mobile playlist qa issues (#3638) Dylan Jeffers
[3e8d7e8] Mobile chats recalculate container bottom on keyboard shown (#3644) Reed
[39928cf] Bump app versions for full release (#3643) Reed
[437e971] Update SDK to v3.0.3-beta.56 (#3641) Marcus Pasell
[3e42cb2] [PAY-1526] Mobile chat reaction picker shadow (#3642) Reed
[ab33206] Amplitude tracking for chat report abuse (#3639) Reed
[6f570c6] Put playlist-artwork generation behind flag (#3640) Dylan Jeffers
[2f1f40d] [C-2475] Add desktop favorites playlist tab (#3637) Dylan Jeffers
[394cacb] [PAY-1516] Chat report abuse flow (#3636) Reed
[82204ec] [C-2763] Fix desktop playlist qa issues (#3634) Dylan Jeffers
[3912407] Implement OAuth Write Popup C-2664 (#3628) nicoback2
[7e13b54] [C-2783] Add terms of service link (#3635) Dylan Jeffers
[bda6eeb] Refactor: extract reusable modal field component (#3631) Andrew Mendelsohn
[c2a59dc] [PAY-1319] Fix emoji keyboard overlapping chat text input (#3629) Reed
[14150ec] [C-2784] Refactor track page to use entity button (#3624) Dylan Jeffers
[5a3e74e] [PAY-1457] Add amplitude analytics to chat features (#3627) Marcus Pasell
[d1aee10] [PAY-1412] Reset player state on app load (#3632) Reed
[965330c] [PAY-1191] Finesse keyboard enter/exit animations (#3633) Michael Piazza
[c9c531e] Create grant upon making developer app (#3630) nicoback2
[a33de30] [PAY-1464] DMs: Go to chat after successful tip (#3625) Marcus Pasell
[646a5eb] [PLAT-1015] Remove entity manager feature flag (#3619) Raymond Jacobson
[31450e7] [PAY-1498][PAY-1477] Misc mobile DMs UI Fixes (#3626) Michael Piazza
[a08f3e7] [C-2760, C-2779] Fix header for playlist and artists tabs in explore screen (#3579) Kyle Shanks
[9a98157] [C-2676] Rough release date modal (#3610) Andrew Mendelsohn
[5e9a847] [C-2771, C-2772] Add duplicate add to playlist confirmation drawer and modal (#3601) Kyle Shanks
[49ca553] [PAY-1468] Fix mobile chats copy message button (#3623) Reed
[193ae1c] [PAY-1483] Patch RN to fix textinput multiline onchange not firing (#3622) Reed
@AudiusProjectAudiusProject deleted a comment from linearBotSep 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@piazzatronpiazzatronpiazzatron left review comments
@SidSethiSidSethiSidSethi approved these changes
@vicky-gvicky-gvicky-g approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sddioulde@SidSethi@piazzatron@vicky-g