Uh oh!
There was an error while loading. Please reload this page.
CON-328 Add manual mergePrimaryAndSecondary route for testing - #3685
Merged
Conversation
SidSethi
commented
Aug 15, 2022
| // Error if this node is not primary for user | ||
| if (userReplicaSet[0] !== selfEndpoint) { | ||
| throw new Error(`Failure - this node is not primary for user`) | ||
| } |
ContributorAuthor
There was a problem hiding this comment.
😬 this should have been locked down earlier
Contributor
There was a problem hiding this comment.
check out my comment below and lmk what you think. we should fetch this data from chain vs discovery
SidSethi
marked this pull request as ready for review
August 15, 2022 18:52
SidSethi
commented
Aug 15, 2022
ContributorAuthor
@theoilie tagged since this impacts your orphaned data recovery work (see PR desc) |
dmanjunath
suggested changes
Aug 15, 2022
dmanjunath
left a comment
Contributor
There was a problem hiding this comment.
thanks for putting out this fix, had a few comments about the primarySyncFromSecondary flow
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| // Error if this node is not primary for user | ||
| if (userReplicaSet[0] !== selfEndpoint) { | ||
| throw new Error(`Failure - this node is not primary for user`) | ||
| } |
Contributor
There was a problem hiding this comment.
check out my comment below and lmk what you think. we should fetch this data from chain vs discovery
dmanjunath
approved these changes
Aug 15, 2022
dmanjunath
left a comment
Contributor
There was a problem hiding this comment.
fixing the chain pull in a fast follow. approving this for now
theoilie
approved these changes
Aug 15, 2022
theoilie
left a comment
Contributor
There was a problem hiding this comment.
LGTM! I'll play around with this route for orphaned data recovery later today
Uh oh!
There was an error while loading. Please reload this page.
dmanjunath pushed a commit
that referenced
this pull request
Aug 16, 2022
dmanjunath pushed a commit
that referenced
this pull request
Aug 16, 2022
audius-infra pushed a commit
that referenced
this pull request
Aug 16, 2022
## Changelog - 2022-08-16 [87ed35a] [PLAT-289] Add endpoint for playlist tracks (#3697) [Raymond Jacobson] - 2022-08-16 [18e908a] Log stack traces of update-replica-set errors (#3702) [Theo Ilie] - 2022-08-16 [1536f99] Add playlist metadata timestamp type (#3701) [Isaac Solo] - 2022-08-16 [c581870] Remove playlist is occupied API (#3700) [Isaac Solo] - 2022-08-16 [1f7241d] New optimizely flag for push notifs (#3699) [Michael Piazza] - 2022-08-16 [56a12d1] Add entity manager contract ABI (#3698) [Isaac Solo] - 2022-08-16 [07cf9af] [C-785] Add request sorters to hist/fav/tracks (#3665) [Raymond Jacobson] - 2022-08-15 [e3d752f] Add entity manager for playlist actions (#3400) [Hareesh Nagaraj] - 2022-08-15 [14ec490] CON-328 Add manual mergePrimaryAndSecondary route for testing (#3685) [Sid Sethi] - 2022-08-15 [4b8d48d] Allow previously abusive users to redeem themselves for next relays (#3687) [Saliou Diallo] - 2022-08-12 [97dd5d3] Add to push notifs list (#3690) [Michael Piazza] - 2022-08-12 [1a38384] Add custom headers to all axios calls to health check in content node (#3688) [Dheeraj Manjunath] - 2022-08-12 [82dcf35] Bump sdk to v0.0.34 [audius-infra]
audius-infra pushed a commit
that referenced
this pull request
Aug 16, 2022
## Changelog - 2022-08-16 [87ed35a] [PLAT-289] Add endpoint for playlist tracks (#3697) [Raymond Jacobson] - 2022-08-16 [18e908a] Log stack traces of update-replica-set errors (#3702) [Theo Ilie] - 2022-08-16 [1536f99] Add playlist metadata timestamp type (#3701) [Isaac Solo] - 2022-08-16 [c581870] Remove playlist is occupied API (#3700) [Isaac Solo] - 2022-08-16 [1f7241d] New optimizely flag for push notifs (#3699) [Michael Piazza] - 2022-08-16 [56a12d1] Add entity manager contract ABI (#3698) [Isaac Solo] - 2022-08-16 [07cf9af] [C-785] Add request sorters to hist/fav/tracks (#3665) [Raymond Jacobson] - 2022-08-15 [e3d752f] Add entity manager for playlist actions (#3400) [Hareesh Nagaraj] - 2022-08-15 [14ec490] CON-328 Add manual mergePrimaryAndSecondary route for testing (#3685) [Sid Sethi] - 2022-08-15 [4b8d48d] Allow previously abusive users to redeem themselves for next relays (#3687) [Saliou Diallo] - 2022-08-12 [97dd5d3] Add to push notifs list (#3690) [Michael Piazza] - 2022-08-12 [1a38384] Add custom headers to all axios calls to health check in content node (#3688) [Dheeraj Manjunath] - 2022-08-12 [82dcf35] Bump sdk to v0.0.34 [audius-infra]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
POST /merge_primary_and_secondary?wallet=<user_wallet>&endpoint=<secondary_endpoint>to be able to manually issue a sync of modeMERGE_PRIMARY_AND_SECONDARYfrom_manual_routeparam to secondary sync overridemergePrimaryAndSecondaryEnabledflagprimarySyncFromSecondaryflow to only work on user's primaryNote:
primarySyncFromSecondary()currently works if called withendpointthat is not a user secondary. We should maybe lock this down a bit but it'll also be required for Orphaned Data RecoveryNits: add
npm run buildstep and addbuild/dir to.gitignoreTests
Existing test coverage
Manual tests for
POST /merge_primary_and_secondary:walletorendpointnot passed inprimarySyncFromSecondary()fails if called on node that is not primary forwalletprimarySyncFromSecondary()succeeds if called withendpointthat is not secondary for userprimarySyncFromSecondary()succeeds in happy pathMonitoring - How will this change be monitored? Are there sufficient logs / alerts?
Check for calls to
/merge_primary_and_secondary, check metrics foraudius_cn_issue_sync_request_duration_secondswithsync_mode="merge_primary_and_secondary"