Skip to content

[PAY-487] DN - Handle premium track access for track apis - #3783

Merged
sddioulde merged 32 commits into
masterfrom
sd-pc-dn-read
Sep 8, 2022
Merged

[PAY-487] DN - Handle premium track access for track apis#3783
sddioulde merged 32 commits into
masterfrom
sd-pc-dn-read

Conversation

@sddioulde

@sddiouldesddioulde commented Aug 29, 2022

Copy link
Copy Markdown
Contributor

Description

  • Add has_current_user_unlocked and, if user has access, the premium_content_signature to metadata of prremium tracks
  • Filter out premium tracks from public apis
  • Use a global constant to determine whether full api tracks should filter out premium tracks in trending flows. For now, we are filtering them out
  • Grant premium track access to owner of that track
  • Improve premium track access check flow

Question that I would like to answer ideally as part of this PR:
Should stems_of premium track be returned? same for remixes_of and remix_track_parents? Answer is yes for now (after discussing with product)

Tests

  • test_populate_track_metadata integration test
  • going to spin up services locally and make some premium tracks and make sure apis return correct response

Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

@sddioulde
sddioulde marked this pull request as draft August 29, 2022 16:13
@sddioulde
sddiouldeforce-pushed the sd-pc-dn-read branch 5 times, most recently from 91d78b9 to d599e07CompareAugust 29, 2022 20:32
Base automatically changed from sd-pc-dn-write to masterAugust 29, 2022 23:44
@sddioulde
sddiouldeforce-pushed the sd-pc-dn-read branch 6 times, most recently from ef4afa9 to 5674cdfCompareAugust 30, 2022 17:58
@sddiouldesddioulde changed the title Draft WIP[PAY-486] DN - Handle premium track access for track apisAug 30, 2022
@sddiouldesddioulde added the discovery-node Discovery Node (previously known as Discovery Provider) label Aug 30, 2022
@sddioulde
sddioulde marked this pull request as ready for review August 30, 2022 20:22
@sddiouldesddioulde changed the title [PAY-486] DN - Handle premium track access for track apis[PAY-486][PAY-487] DN - Handle premium track access for track apisAug 30, 2022
@sddiouldesddioulde changed the title [PAY-486][PAY-487] DN - Handle premium track access for track apis[PAY-487] DN - Handle premium track access for track apisAug 30, 2022
@sddioulde
sddioulde merged commit 4911903 into masterSep 8, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discovery-nodeDiscovery Node (previously known as Discovery Provider)size/XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@sddioulde@stereosteve@isaacsolo@piazzatron