Skip to content

Add ServiceSelection class for specific services to override - #399

Merged
raymondjacobson merged 3 commits into
masterfrom
rj-service-selection
May 4, 2020
Merged

Add ServiceSelection class for specific services to override#399
raymondjacobson merged 3 commits into
masterfrom
rj-service-selection

Conversation

@raymondjacobson

@raymondjacobsonraymondjacobson commented Apr 25, 2020•
edited
Loading

Copy link
Copy Markdown
Member

This is the first PR that will enable a new form of service selection.

Best way to understand this is to review the ServiceSelection.js class and the .test.js file

hareeshnagaraj
hareeshnagaraj reviewed Apr 27, 2020
View reviewed changes
Comment threadlibs/src/service-selection/ServiceSelection.js
Comment threadlibs/src/service-selection/ServiceSelection.test.js
Comment threadlibs/src/service-selection/ServiceSelection.js
Comment threadlibs/src/services/discoveryProvider/index.js
raymondjacobson
raymondjacobson commented Apr 27, 2020
View reviewed changes
Comment threadlibs/src/service-selection/ServiceSelection.test.js
@hareeshnagaraj

hareeshnagaraj commented Apr 27, 2020

Copy link
Copy Markdown
Contributor

looks good to me, let's wait to publish on npm until we have integration with services?

hareeshnagaraj
hareeshnagaraj approved these changes Apr 27, 2020
View reviewed changes

@hareeshnagarajhareeshnagaraj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0 looks good

@raymondjacobson

raymondjacobson commented Apr 27, 2020

Copy link
Copy Markdown
MemberAuthor

looks good to me, let's wait to publish on npm until we have integration with services?

Yessir!

@raymondjacobsonraymondjacobson mentioned this pull request Apr 28, 2020
Merged
vicky-g
vicky-g reviewed Apr 29, 2020
View reviewed changes
Comment threadlibs/src/service-selection/ServiceSelection.js
vicky-g
vicky-g reviewed Apr 29, 2020
View reviewed changes
Comment threadlibs/src/service-selection/ServiceSelection.js
vicky-g
vicky-g reviewed Apr 29, 2020
View reviewed changes
Comment threadlibs/src/service-selection/ServiceSelection.test.js
@raymondjacobson
Add ServiceSelection class for specific services to override
b31efbf
@raymondjacobson
Clean up
d10cc3b
@raymondjacobson
New discprov service selection (#402)
ef8eb67
* Add DiscoveryProviderSelection
* Rebase and cleanup
* Undo comment
* Reverse check valid dp versions
* Clean up
* Revert discprov index changes
* Fix imports
* Fix api call and cleanup
@raymondjacobson
raymondjacobson merged commit 319028c into masterMay 4, 2020
@raymondjacobson
raymondjacobson deleted the rj-service-selection branch May 4, 2020 20:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@hareeshnagarajhareeshnagarajhareeshnagaraj approved these changes
@vicky-gvicky-gvicky-g approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@raymondjacobson@hareeshnagaraj@vicky-g