Skip to content

Model support for Remixes - #408

Merged
jowlee merged 8 commits into
masterfrom
rj-remixes
May 11, 2020
Merged

Model support for Remixes#408
jowlee merged 8 commits into
masterfrom
rj-remixes

Conversation

@raymondjacobson

@raymondjacobsonraymondjacobson commented Apr 30, 2020

Copy link
Copy Markdown
Member

No description provided.

piazzatron
piazzatron approved these changes Apr 30, 2020
View reviewed changes
Comment threaddiscovery-provider/src/models.py Outdated
Comment threaddiscovery-provider/src/tasks/tracks.py Outdated
Comment threaddiscovery-provider/src/tasks/tracks.py
dmanjunath
dmanjunath reviewed Apr 30, 2020
View reviewed changes
Comment threaddiscovery-provider/src/models.py Outdated
Comment threaddiscovery-provider/src/tasks/tracks.py Outdated
Comment threaddiscovery-provider/alembic/versions/7b3f27e78b84_add_credits_table.py
hareeshnagaraj
hareeshnagaraj reviewed May 1, 2020
View reviewed changes

@hareeshnagarajhareeshnagaraj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the replay of credit split changes should get fixed before we merge in, but we can address it in steps as well

Comment threaddiscovery-provider/src/tasks/tracks.py Outdated
@raymondjacobsonraymondjacobson changed the title Model support for credits splitsModel support for RemixesMay 11, 2020
raymondjacobsonand others added 8 commits May 11, 2020 14:50
@raymondjacobson@jowlee
Move credits_splits to jsonb
bf352ed
@raymondjacobson@jowlee
Add credits table
3186e1a
@raymondjacobson@jowlee
Fix key
cc78f17
@raymondjacobson@jowlee
Add indexing flow for credits splits
29e6e87
@raymondjacobson@jowlee
Fix lint
590e4bd
@raymondjacobson@jowlee
Remove logs and fix key constraint
84eaee9
@jowlee
Discprov remix parent/children and populate metadata (#419)
3d438e1
* Update discprov tbls w/ remixes
* Update indexing flow to add remix relationship
* Add remix parent/children query and populate metadata w/ remix info
* Fix discprov linting
* Added some comments and pagniate to remix endpoints
* More comments fix queries
@jowlee
Check if remix and stem is null and remove index on remix
e37ae18
@raymondjacobson

raymondjacobson commented May 11, 2020

Copy link
Copy Markdown
MemberAuthor

LGTM @jowlee !

@jowlee
jowlee merged commit 7972dfd into masterMay 11, 2020
@jowlee
jowlee deleted the rj-remixes branch May 11, 2020 20:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jowleejowleeAwaiting requested review from jowlee
3 more reviewers
@dmanjunathdmanjunathdmanjunath left review comments
@hareeshnagarajhareeshnagarajhareeshnagaraj left review comments
@piazzatronpiazzatronpiazzatron approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@raymondjacobson@dmanjunath@hareeshnagaraj@piazzatron@jowlee