Uh oh!
There was an error while loading. Please reload this page.
[eth-contracts] All working state - #470
Closed
hareeshnagaraj wants to merge 86 commits into
Closed
Conversation
hareeshnagaraj
commented
May 18, 2020
Contributor
- Total changes for eth-contracts
* First pass of multiple endpoints in SP contracts * Includes unit test validation
* Hardcoded list of SP types and associated min/max bounds * Unit tests to confirm min/max threshold behavior * Unit test for multiple endpoints / account / type
…s-protocol into hn_eth_contracts_dev
* Prerequisite for continued delegation work * Switch stake tracking model to use a global multiplier that is incremented as funds are added * All existing tests passing with new code
* Delegation with rewards split functionality * Stake for SP direct tracked in ServiceProviderFactory, delegate stakes now tracked in DelegateManager * Claims forwarded through DelegateManager, slash handled by delegateManager as well * Revamped reward functionality, with proportional on-demant mint of tokens when claim issued * Undelegate request and lockup added * Governance with vote functionality now working, validated with slash
…r contracts + migrations + tests (#382)
… ServiceProviderFactory (#376) * Enforce callers through registry for all staking functions
* Expose CRUD for known service types to governance or deployer
…Manager, Clean up Initializable pattern (#393)
* Undelegate lockup duration modification allowed
* Test validation * Function re-ordering + re-naming + versionIsValid + updateFundingRoundBlockDiff Co-authored-by: Sid Sethi <sidsethi93@gmail.com>
* Separate 'current round' state from configuration variables, enabling fundingAmount modification during ongoing round
* Add SafeMath everywhere we use uints * run coverage in circleci * last one didnt work. run coverage in circleci * try again for run coverage in circleci * break lint into a top level task in circle * forgot these files * lint * ClaimsManager.sol using SafeMath * re-enable tests + lint * Governance.sol * Few more contracts * This is causing some problems * this makes the stack too deep error go away * Lets see if coveralls works * comment * wrong place * continue on * specify coverage path * maybe it's the initial period * string? * Stupid period * Add coverage badge to README * Remove this before I forget * This is an actual bug * BIG bug fix * Final conversion for DelegateManager * Remove return declaration * Remove unused Safemath
* Remove shadowed vars * Acknowledge possible re-entrancy bug * Fix re-entrancy possibility here * Move the comment
* Remove explicit false check * Re-entrancy (non-token transfer) in Registry * Cleanup * Limit voting to only Yes/No votes * Stupid
…o use new governance override pattern" (#485)
* Enforce stake restrictions if a claim is pending for a given service provider
* Unused function calls * Revert * Test fix * Reduce unused returns * Try to abstract some stuff without changing order * Remove spFactory double init * Move some stuff around
* Increased coverage for ServiceTypeManager, ServiceProviderFactory, Staking. DelegateManager
* More tests * bug fix * this is why you don't copy paste
* Restructure spDeployerCut calculation to address crytic
* Fix unused return value in validateBalance flow, https://crytic.io/AudiusProject/audius-protocol/117/security_checks/mlt8Dl0gQ5Gxt-oxTB3vDA * Update default values for constants - creator node type min stake - 200,000 AUD creator node type max stake - 3,000,000 AUD discovery provider type min stake - 200,000 AUD discovery provider type max stake - 2,000,000 AUD fundingRoundBlockDiff - 46523 blocks fundingAmount - 1342465.75342 AUD
* some comments * More comments * more comments * docs for ContractManager.sol * Two more contracts to go * ServiceTypeManager.sol * Staking.sol should be done * Lint * Update with most recent mainnet changes * lint fixes * AudiusAdminUpgradeability comment fixes * Lints * Claims fix * DelegateManageer comments update * Minor * Migration comment * Commenit Co-authored-by: Sid Sethi <sidsethi93@gmail.com> Co-authored-by: Hareesh Nagaraj <hareesh.nagaraj@gmail.com>
* Strict equality * Local shadowing
SidSethi
commented
Aug 18, 2020
Contributor
Closing this PR as all changes were included in subsequent PR that was merged directly into master: #564 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.