') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Single transaction sign up by isaacsolo · Pull Request #5456 · AudiusProject/apps · GitHub
Skip to content

Single transaction sign up - #5456

Merged
isaacsolo merged 8 commits into
mainfrom
is-single-tx-signup
Jun 21, 2023
Merged

Single transaction sign up#5456
isaacsolo merged 8 commits into
mainfrom
is-single-tx-signup

Conversation

@isaacsolo

@isaacsoloisaacsolo commented Jun 21, 2023

Copy link
Copy Markdown

Description

Currently sign up can take up to 3 transactions: create user record, update handle, update images. This change makes it a single relay.

Also fixing the indexing side so the metadata is saved to the user record.

How Has This Been Tested?

Linked SDK and tested against stage. Confirmed single tx signup works. Confirmed multi tx signup works.

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

@isaacsolo
isaacsolo requested a review from theoilieJune 21, 2023 19:17
theoilie
theoilie approved these changes Jun 21, 2023
View reviewed changes

@theoilietheoilie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Comment threaddiscovery-provider/src/tasks/entity_manager/user.py Outdated
cid_type[metadata_cid] = metadata_type
cid_metadata[metadata_cid] = params.metadata
user_record.metadata_multihash = metadata_cid
user_record = update_legacy_user_images(user_record)

@theoilietheoilieJun 21, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this flow will only happen for storage v2 users right? maybe it's better to remove this line and stop using update_legacy_user_images going forward, since all the v2 user stuff only sets the correct _sizes fields and not the legacy ones

@isaacsolo
isaacsolo merged commit 1b19b60 into mainJun 21, 2023
@isaacsolo
isaacsolo deleted the is-single-tx-signup branch June 21, 2023 23:21
audius-infra pushed a commit that referenced this pull request Jun 21, 2023
audius-infra
@audius/sdk: v2.0.3-beta.53
28ad068
[skip ci]
## Changelog
- 2023-06-21 [1b19b60] Single transaction sign up (#5456) [Isaac Solo]
- 2023-06-20 [2399c1d] @audius/sdk: v2.0.3-beta.52 [audius-infra]
audius-infra pushed a commit that referenced this pull request Jun 21, 2023
audius-infra
@audius/sdk: v2.0.3-beta.53
1947e1e
[skip ci]
## Changelog
- 2023-06-21 [1b19b60] Single transaction sign up (#5456) [Isaac Solo]
- 2023-06-20 [2399c1d] @audius/sdk: v2.0.3-beta.52 [audius-infra]
isaacsolo pushed a commit that referenced this pull request Jun 23, 2023
Isaac Solo
Revert "Single transaction sign up (#5456)"
c54a268
This reverts commit 1b19b60.
@rickyromborickyrombo mentioned this pull request Jun 23, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@theoilietheoilietheoilie approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@isaacsolo@theoilie