Uh oh!
There was an error while loading. Please reload this page.
Fix album repost triggers - #5767
Merged
Merged
Conversation
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
My fix https://github.com/AudiusProject/audius-protocol/pull/5467/files wasn't complete. That fix was intended to use album repost_type so the handle_repost trigger would recognize an album vs playlist.
The client still sends playlist entity type so existing reposts wouldn't be found https://github.com/AudiusProject/audius-protocol/blob/main/discovery-provider/src/tasks/entity_manager/entity_manager.py#L736-L737. This allows users to repost multiple times, bypassing the duplicate check.
This change modifies the trigger to just check the playlist table and use that to determine is_album instead of the repost_type. It also cleans up duplicate reposts and ensures we only use playlist repost_type.
How Has This Been Tested?
Tested on sandbox. Migration took a while but worked ~ 5-10 mins.
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.