Skip to content

[C-3050] Update the text and icon for the ImageSelectionButton#5974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kyle-Shanks merged 1 commit into from
Sep 12, 2023
Merged

[C-3050] Update the text and icon for the ImageSelectionButton #5974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/web/src/components/image-selection/ImageSelectionButton.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { useRef, useState } from 'react'

import { Button, ButtonType, IconPencil } from '@audius/stems'
import { Button, ButtonType, IconCamera } from '@audius/stems'
import cn from 'classnames'
import PropTypes from 'prop-types'
import ReactDropzone from 'react-dropzone'
Expand DownExpand Up@@ -81,7 +81,7 @@ const ImageSelectionButton = ({
[styles.hide]: showModal
})}
text={buttonText}
leftIcon={<IconPencil />}
rightIcon={<IconCamera />}
type={ButtonType.WHITE}
onClick={handleClick}
buttonType='button'
Expand DownExpand Up@@ -110,7 +110,7 @@ const ImageSelectionButton = ({
[styles.hide]: hasImage
})}
text={buttonText}
leftIcon={<IconPencil />}
rightIcon={<IconCamera />}
type={ButtonType.WHITE}
onClick={handleClick}
buttonType='button'
Expand Down
5 changes: 0 additions & 5 deletions packages/web/src/components/upload/UploadArtwork.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,10 +9,6 @@ import Toast from 'components/toast/Toast'

import styles from './UploadArtwork.module.css'

const messages = {
imageName: 'Artwork'
}

const UploadArtwork = (props) => {
const [processing, setProcessing] = useState(false)
const [showTip, setShowTip] = useState(false)
Expand DownExpand Up@@ -69,7 +65,6 @@ const UploadArtwork = (props) => {
<ImageSelectionButton
anchorRef={imageSelectionAnchorRef}
defaultPopupOpen={props.defaultPopupOpen}
imageName={messages.imageName}
hasImage={hasImage}
error={props.imageProcessingError}
onOpenPopup={props.onOpenPopup}
Expand Down