Uh oh!
There was an error while loading. Please reload this page.
Make DN delister synchronous with indexer - #6315
Conversation
| "update_delist_statuses", | ||
| kwargs={"current_block_timestamp": next_block["timestamp"]}, | ||
| ) | ||
| ).get(timeout=1) |
There was a problem hiding this comment.
task executes async but this simulates a synchronous execution: it waits 1s for the task to complete, if it does not, it raises an exception (caught below). the actual task isn't terminated
https://docs.celeryq.dev/en/latest/reference/celery.result.html#celery.result.AsyncResult.get
There was a problem hiding this comment.
however will have to adjust the batch size to fetch from trusted notifier each iteration and this timeout to be reasonably on par
| @celery.task(name="update_delist_statuses", bind=True) | ||
| @celery.task(name="update_delist_statuses", bind=True, soft_time_limit=1, time_limit=2) |
There was a problem hiding this comment.
caps the task at a 1s time limit, 2s hard limit.
the soft_time_limit raises a SoftTimeLimitExceeded exception after 1s, which gets caught and subsequently the finally clause releases any locks held.
the time_limit hard-kills the task. the lock has a timeout set so if it happens to not get released properly in this case, it wont block future tasks forever
isaacsolo
left a comment
There was a problem hiding this comment.
looks good as long as update_delist_statuses can run within 1s
6e4c8c5 to
ca9c3a9Compareaudius-infra
commented
Dec 2, 2023
Preview this change https://demo.audius.co/mbrier/proto-1343/tn-try-again |
michellebrier
commented
Dec 2, 2023
closing in favor of #6832 - a better soln |
Description
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.