Uh oh!
There was an error while loading. Please reload this page.
[Protocol Dashboard] Show Audius profile info and link to profile if wallet is connected to an Audius account [C-3579] - #7132
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dylanjeffers
left a comment
There was a problem hiding this comment.
This all looks excellent! react-query is reasonable just curious about Audius-query feasibility. Likely can just figure this out once we figure out data fetching in general
Uh oh!
There was an error while loading. Please reload this page.
| import IconBronzeBadgeSVG from 'assets/img/iconBronzeBadge.svg?react' | ||
| import IconGoldBadgeSVG from 'assets/img/iconGoldBadge.svg?react' | ||
| import IconPlatinumBadgeSVG from 'assets/img/iconPlatinumBadge.svg?react' |
There was a problem hiding this comment.
Nice job adding this to protocol for now. Long term you thinking we have a harmony component for all this?
There was a problem hiding this comment.
| /> | ||
| {audiusProfile == null ? null : ( | ||
| <a | ||
| aria-label="Go to user's Audius profile" |
| } | ||
| export const useDashboardWalletUser = (wallet: string) => { | ||
| return useQuery({ |
There was a problem hiding this comment.
Cool! So do we have redux on the dashboard? If so I'm wondering if it would be unreasonable to use Audius query?
There was a problem hiding this comment.
we do have redux on the dashboard, but I didn't think using Audius-query made sense here because we don't have/need a normalized cache for this. using react-query keeps things abstracted away and simple
| audiusProfile?: DashboardWalletUser | null | ||
| status: Status.Failure | Status.Loading | ||
| } | ||
| export const useUser = ({ wallet }: UseUserProps): UseUserResponse => { |
| const preload = async (image: string, cb: () => void) => { | ||
| await new Promise(resolve => { | ||
| await new Promise(_resolve => { |
There was a problem hiding this comment.
You didn't add this but I don't think there's any point to this promise
Uh oh!
There was an error while loading. Please reload this page.
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
05c16fb to
47bd0e1Compare
Description
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.