[PAY-2356] Mobile track screen stems & download section by dharit-tan · Pull Request #7207 · AudiusProject/apps

dharit-tan · 2024-01-16T23:17:08Z

Description

Add expandable stems & download section to mobile track screen. Show/hide depending on lossless feature flag.
Pulled out Expandable into its own component, cc @schottra (open to suggestions on the design, the hook feels a bit ugly but it's the best solution I could come up with).

Notes:

Download buttons do not work - download logic not implemented yet.
stems metadata is missing orig_filename so put in placeholder text for video.

How Has This Been Tested?

Local ios + android stage - confirmed Expandable changes don't break on either.

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2024-01-16.at.21.09.56.mp4

vercel · 2024-01-16T23:17:14Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
audius-web-ssr	⬜️ Ignored (Inspect)	Visit Preview		Jan 17, 2024 9:38pm

schottra

Looks good!

schottra · 2024-01-17T15:58:37Z

 ) : null}
 <View style={styles.buttonSection}>
- {!hasStreamAccess && !isOwner && streamConditions && trackId ? (
+ {!hasStreamAccess &&


This feels like so many booleans to be coordinating, especially since we do it in multiple places. Is there any use in consolidating it into a variable we calculate once above? Hopefully one that indicates what exactly we're checking (userCanStream?)

yeah i agree. was going back and forth with design and there are a few different cases to consider, so will follow up in next PR for this.

schottra · 2024-01-17T16:08:31Z

+
+import { IconReceive } from '@audius/harmony-native'
+import { Text } from 'app/components/core'
+import { PlainButton } from 'app/harmony-native/components/Button/PlainButton/PlainButton'


Why the two different locations for harmony-native? In the process of migrating?

schottra · 2024-01-17T16:09:16Z

+type DownloadRowProps = {
+ trackId: ID
+ quality: DownloadQuality
+ // onDownload: (trackId: ID, category?: string, parentTrackId?: ID) => void


Seeing this commented code in a few places in this file. Meant to be uncommented?

schottra · 2024-01-17T16:19:22Z

- const { hasStreamAccess, hasDownloadAccess } = useGatedContentAccess(
- track as Track
- ) // track is of type Track | SearchTrack but we only care about some of their common fields, maybe worth refactoring later
+ const { hasStreamAccess } = useGatedContentAccess(track as Track) // track is of type Track | SearchTrack but we only care about some of their common fields, maybe worth refactoring later


useGatedContentAccess could just be updated to use Pick<Track, 'fields' | 'we' | 'care' | 'about'> and then it won't matter what type you pass in as long as it has those fields in it?

…arch * origin/main: (76 commits) [C-3637] Add OTP flow for new sign-up (#7227) [C-3642] Handle "user past account creation" edge case scenarios in web (#7225) Fix DDEX dockerfile (#7226) [Web] [Libs] Disconnect dashboard wallet - web and SDK changes (#7209) [C-3640] Reduce toast duration app-wide (#7224) [C-3639] Fix empty album tab state (#7222) [C-3621] Fix scrolling issues on new sign up Password & Handle pages (web) (#7204) Get public IP in nginx (#7223) [C-3149 C-3122 C-3051 C-3625 C-3481] Fix add track to playlist (#7221) [C-3583 C-3634 C-3404] Add harmony-native to native sign up (#7210) Remove yield* in JS file (#7134) Make FilterButton a controlled component (#6993) [C-3649] Update create password screen to move when keyboard opens to display validation (#7220) [PAY-2356] Mobile track screen stems & download section (#7207) [Web] Add OTP to OAuth login flow [C-3643] (#7212) Openresty container (#7214) Export plain button from harmony native (#7217) CircleCI self-hosted runners: lower cleanup thresholds (#7216) Fix otp after #7196 (#7215) [C-3638] Fix saga ci (#7211) ...

[b94153b] Convert mobile DownloadRow to harmony (#7237) Reed [62b8611] [C-3597] Add ellipses to track tile titles (#7234) Dylan Jeffers [eba9299] [C-3678, C-3657] Fix android radial-gradient bug, Fix sign-up panel top border-radius (#7236) Dylan Jeffers [bf9d2ea] Fix sign ups failing halfway through saga (#7240) JD Francis [f355286] Re-add downloads when lossless downloads flag disabled (#7235) Reed [0ffd417] [C-3677] Fix onclick for upload a track chip (#7232) Andrew Mendelsohn [f9132ca] Filter sitemaps properly (#7233) Raymond Jacobson [5f8d5d2] Fix max width issue on select artists page (#7229) JD Francis [dc4fa10] [DOCS] - repair reference links and set config to throw errors on breaks (#7231) Sam Gutentag [f6ad76f] [PAY-2361] Fix search es with new gated fields (#7230) Saliou Diallo [5d97832] [PAY-2319] Add offramp on web (#7153) Randy Schott [eab69ec] [PAY-2364] Fix nft gated tracks (#7228) Saliou Diallo [12af10e] [C-3637] Add OTP flow for new sign-up (#7227) Dylan Jeffers [4d68c2a] [C-3642] Handle "user past account creation" edge case scenarios in web (#7225) JD Francis [60b843d] Fix DDEX dockerfile (#7226) Michelle Brier [c3c2148] [Web] [Libs] Disconnect dashboard wallet - web and SDK changes (#7209) nicoback2 [b7d03e3] [C-3640] Reduce toast duration app-wide (#7224) Andrew Mendelsohn [120c8f6] [C-3639] Fix empty album tab state (#7222) Andrew Mendelsohn [059312d] [C-3621] Fix scrolling issues on new sign up Password & Handle pages (web) (#7204) JD Francis [557fd96] Get public IP in nginx (#7223) Isaac Solo [0046ab4] [C-3149 C-3122 C-3051 C-3625 C-3481] Fix add track to playlist (#7221) Dylan Jeffers [ba711b6] [C-3583 C-3634 C-3404] Add harmony-native to native sign up (#7210) Dylan Jeffers [335cfa4] Remove yield* in JS file (#7134) Marcus Pasell [fa7a9d9] Make FilterButton a controlled component (#6993) Marcus Pasell [1eb3aa1] [C-3649] Update create password screen to move when keyboard opens to display validation (#7220) Kyle Shanks [55b5192] [PAY-2356] Mobile track screen stems & download section (#7207) Reed [c0b2b66] [Web] Add OTP to OAuth login flow [C-3643] (#7212) nicoback2 [f5cee04] Openresty container (#7214) Steve Perkins [33f7597] Export plain button from harmony native (#7217) Kyle Shanks [13412f3] CircleCI self-hosted runners: lower cleanup thresholds (#7216) Danny [c57618e] Fix otp after #7196 (#7215) Raymond Jacobson [31629e6] [C-3638] Fix saga ci (#7211) Dylan Jeffers [ab09783] Fix ISO date format for dayjs (#7206) Isaac Solo [abc71bf] Fix stems & downloads appearing erroneously web (#7202) Reed [fb38737] [PAY-2351] Fix height on add funds (#7172) Raymond Jacobson [38221f2] [C-3614, C-3615] Update image storage for new sign up flow to conform with old structure (#7200) Kyle Shanks [b0bf87d] use slog-gorm package (#7199) Steve Perkins [ce50f32] Gitignore snippets (#7201) Reed [204894c] Fix audius-cmd test (#7208) Saliou Diallo [f5226c7] [C-3630] Refactor signon screens to use native-harmony (#7192) Dylan Jeffers [bcc180f] Bypass OTP for testflight account (#7196) Saliou Diallo [94ec3d0] Update mobile version to 1.1.83 for release (#7203) Dylan Jeffers [ab1d3e9] Add USDC gated downloads flow (#6899) Saliou Diallo [966e438] [C-3608] Increase pressable area for cover photo upload (native) (#7165) JD Francis [9012df5] [C-2190] Fix track player interruptions (#7198) Dylan Jeffers [d12d824] [C-3632] Return null instead of NOT_FOUND in trpc-server (#7184) Andrew Mendelsohn [b391ada] Bump version to 0.6.19 audius-infra [ecbd9b1] Bump version to 0.6.18 audius-infra [625839b] Fix repair signup (#7197) Marcus Pasell [fc5131e] Add sendgrid param (#7195) Raymond Jacobson [d530b0e] Bump app builds (#7194) Raymond Jacobson [8d031a4] [PROTO-1599] Add OTP support (#7193) Raymond Jacobson

[df201c4] [C-3651] Add box-shadow to text-input (#7259) Dylan Jeffers [3436391] Remove track player patch (#7256) Dylan Jeffers [2dd727a] [C-3633] Fix upload tags (#7246) Dylan Jeffers [336abe5] [PAY-2362] Allow offline download (#7253) Saliou Diallo [bdc4997] Re-add download buttons to mobile track page (#7254) Reed [5f2045c] Add auto upgrade logs to vector (#7251) Isaac Solo [d87e13f] Update styles to wrap properly (#7248) Saliou Diallo [1599367] [PROTO-1598] Use tRPC in ddex (#7150) Theo Ilie [09b5dc7] Qm sync (#7250) Steve Perkins [cc892ea] Remove scheduled release filter from sitemaps (#7247) Isaac Solo [3211ca2] Fix stylelint (#7245) Saliou Diallo [270f107] Increase chat reaction emoji sizes (#7241) Reed [26b0f0c] [PAY-2331] Add lossless download info section in upload (#7219) Saliou Diallo [2a15a64] v1.5.62 (#7243) Dylan Jeffers [b94153b] Convert mobile DownloadRow to harmony (#7237) Reed [62b8611] [C-3597] Add ellipses to track tile titles (#7234) Dylan Jeffers [eba9299] [C-3678, C-3657] Fix android radial-gradient bug, Fix sign-up panel top border-radius (#7236) Dylan Jeffers [bf9d2ea] Fix sign ups failing halfway through saga (#7240) JD Francis [f355286] Re-add downloads when lossless downloads flag disabled (#7235) Reed [0ffd417] [C-3677] Fix onclick for upload a track chip (#7232) Andrew Mendelsohn [f9132ca] Filter sitemaps properly (#7233) Raymond Jacobson [5f8d5d2] Fix max width issue on select artists page (#7229) JD Francis [dc4fa10] [DOCS] - repair reference links and set config to throw errors on breaks (#7231) Sam Gutentag [f6ad76f] [PAY-2361] Fix search es with new gated fields (#7230) Saliou Diallo [5d97832] [PAY-2319] Add offramp on web (#7153) Randy Schott [eab69ec] [PAY-2364] Fix nft gated tracks (#7228) Saliou Diallo [12af10e] [C-3637] Add OTP flow for new sign-up (#7227) Dylan Jeffers [4d68c2a] [C-3642] Handle "user past account creation" edge case scenarios in web (#7225) JD Francis [60b843d] Fix DDEX dockerfile (#7226) Michelle Brier [c3c2148] [Web] [Libs] Disconnect dashboard wallet - web and SDK changes (#7209) nicoback2 [b7d03e3] [C-3640] Reduce toast duration app-wide (#7224) Andrew Mendelsohn [120c8f6] [C-3639] Fix empty album tab state (#7222) Andrew Mendelsohn [059312d] [C-3621] Fix scrolling issues on new sign up Password & Handle pages (web) (#7204) JD Francis [557fd96] Get public IP in nginx (#7223) Isaac Solo [0046ab4] [C-3149 C-3122 C-3051 C-3625 C-3481] Fix add track to playlist (#7221) Dylan Jeffers [ba711b6] [C-3583 C-3634 C-3404] Add harmony-native to native sign up (#7210) Dylan Jeffers [335cfa4] Remove yield* in JS file (#7134) Marcus Pasell [fa7a9d9] Make FilterButton a controlled component (#6993) Marcus Pasell [1eb3aa1] [C-3649] Update create password screen to move when keyboard opens to display validation (#7220) Kyle Shanks [55b5192] [PAY-2356] Mobile track screen stems & download section (#7207) Reed [c0b2b66] [Web] Add OTP to OAuth login flow [C-3643] (#7212) nicoback2 [f5cee04] Openresty container (#7214) Steve Perkins [33f7597] Export plain button from harmony native (#7217) Kyle Shanks [13412f3] CircleCI self-hosted runners: lower cleanup thresholds (#7216) Danny [c57618e] Fix otp after #7196 (#7215) Raymond Jacobson [31629e6] [C-3638] Fix saga ci (#7211) Dylan Jeffers [ab09783] Fix ISO date format for dayjs (#7206) Isaac Solo [abc71bf] Fix stems & downloads appearing erroneously web (#7202) Reed [fb38737] [PAY-2351] Fix height on add funds (#7172) Raymond Jacobson [38221f2] [C-3614, C-3615] Update image storage for new sign up flow to conform with old structure (#7200) Kyle Shanks [b0bf87d] use slog-gorm package (#7199) Steve Perkins [ce50f32] Gitignore snippets (#7201) Reed [204894c] Fix audius-cmd test (#7208) Saliou Diallo [f5226c7] [C-3630] Refactor signon screens to use native-harmony (#7192) Dylan Jeffers [bcc180f] Bypass OTP for testflight account (#7196) Saliou Diallo [94ec3d0] Update mobile version to 1.1.83 for release (#7203) Dylan Jeffers [ab1d3e9] Add USDC gated downloads flow (#6899) Saliou Diallo [966e438] [C-3608] Increase pressable area for cover photo upload (native) (#7165) JD Francis [9012df5] [C-2190] Fix track player interruptions (#7198) Dylan Jeffers [d12d824] [C-3632] Return null instead of NOT_FOUND in trpc-server (#7184) Andrew Mendelsohn [b391ada] Bump version to 0.6.19 audius-infra [ecbd9b1] Bump version to 0.6.18 audius-infra [625839b] Fix repair signup (#7197) Marcus Pasell [fc5131e] Add sendgrid param (#7195) Raymond Jacobson [d530b0e] Bump app builds (#7194) Raymond Jacobson [8d031a4] [PROTO-1599] Add OTP support (#7193) Raymond Jacobson

[PAY-2356] Mobile track screen stems & download section
a7cbaaf

dharit-tan requested review from schottra and sddioulde January 16, 2024 23:17

pull-request-sizeBot added the size/L label Jan 16, 2024

dharit-tan commented Jan 16, 2024
View reviewed changes

Comment threadpackages/mobile/src/components/summary-table/SummaryTable.tsx

dharit-tan added 2 commits January 16, 2024 20:47

Fix track type
ba96ab1

DownloadRow
284cc1d

pull-request-sizeBot added size/XL and removed size/L labels Jan 17, 2024

dharit-tan added 2 commits January 16, 2024 21:10

fix expandable bug, filenames
7f46764

Merge remote-tracking branch 'origin/main' into rt-mobile
39abdf1

schottra approved these changes Jan 17, 2024
View reviewed changes

dharit-tan added 2 commits January 17, 2024 14:52

randy PR comments
ce8d48b

track as Track
24bee30

dharit-tan merged commit 55b5192 into mainJan 17, 2024

dharit-tan deleted the rt-mobile branch January 17, 2024 22:33

Navigation Menu

Uh oh!

[PAY-2356] Mobile track screen stems & download section - #7207

[PAY-2356] Mobile track screen stems & download section#7207
dharit-tan merged 7 commits into
mainfrom
rt-mobile

dharit-tan commented Jan 16, 2024•
edited
Loading

Uh oh!

vercelBot commented Jan 16, 2024•
edited
Loading

Uh oh!

Uh oh!

schottra left a comment

Uh oh!

schottraJan 17, 2024

Uh oh!

dharit-tanJan 17, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

schottraJan 17, 2024

Uh oh!

schottraJan 17, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

schottraJan 17, 2024

Uh oh!

dharit-tanJan 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

dharit-tan commented Jan 16, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Uh oh!

vercelBot commented Jan 16, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

schottra left a comment

Choose a reason for hiding this comment

Uh oh!

schottraJan 17, 2024

Choose a reason for hiding this comment

Uh oh!

dharit-tanJan 17, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

schottraJan 17, 2024

Choose a reason for hiding this comment

Uh oh!

schottraJan 17, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

schottraJan 17, 2024

Choose a reason for hiding this comment

Uh oh!

dharit-tanJan 17, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dharit-tan commented Jan 16, 2024•
edited
Loading

vercelBot commented Jan 16, 2024•
edited
Loading