Uh oh!
There was an error while loading. Please reload this page.
[Protocol Dashboard] Fix user images not loading when MetaMask not connected; add loading state for OAuth modal [C-3694 C-3693] - #7258
Merged
Conversation
nicoback2
requested review from
a team and sliptype
and removed request for
a teamJanuary 20, 2024 00:04
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
nicoback2
commented
Jan 20, 2024
| @@ -0,0 +1,43 @@ | |||
| .container { | |||
ContributorAuthor
There was a problem hiding this comment.
Copy pasted this and LoadingSpinner from /embed
nicoback2
commented
Jan 20, 2024
| } | ||
| return instance | ||
| } | ||
| initAudiusSdk() |
ContributorAuthor
There was a problem hiding this comment.
we don't need to init sdk in setup.ts anymore since we don't need the auth functions, so we can just init sdk here and get rid of the async stuff.
sliptype
approved these changes
Jan 22, 2024
| } | ||
| return instance | ||
| } | ||
| initAudiusSdk() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Tested locally against stage
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.