Uh oh!
There was an error while loading. Please reload this page.
[PAY-2332][PAY-2358] More work on stems and downloads upload and edit flows - #7382
Merged
Merged
Conversation
audius-infra
commented
Jan 30, 2024
Collaborator
Preview this change https://demo.audius.co/sd-stems-and-downloads-next |
added 15 commits
January 30, 2024 13:35
audius-infra
commented
Jan 30, 2024
Collaborator
Preview this change https://demo.audius.co/sd-stems-and-downloads-next |
sddiouldeforce-pushed
the
sd-stems-and-downloads
branch
from
January 30, 2024 18:48
67bbf7a to
b20f102Comparesddiouldeforce-pushed
the
sd-stems-and-downloads-next
branch
from
January 30, 2024 18:48
cb1709c to
fcb2d3fCompareaudius-infra
commented
Jan 30, 2024
Collaborator
Preview this change https://demo.audius.co/sd-stems-and-downloads-next |
| } | ||
| }, | ||
| price: (price: number) => | ||
| price.toLocaleString('en-US', { style: 'currency', currency: 'USD' }), |
| usdc_purchase: { price } | ||
| } = downloadConditions as USDCPurchaseConditions | ||
| setDownloadConditions({ | ||
| // @ts-ignore fully formed in saga (validated + added splits) |
| } = downloadConditions as USDCPurchaseConditions | ||
| setDownloadConditions({ | ||
| // @ts-ignore fully formed in saga (validated + added splits) | ||
| usdc_purchase: { price: Math.round(price) } |
Contributor
There was a problem hiding this comment.
does this not get rid of the decimal places
| href={AUDIO_FILE_FORMATS_LINK} | ||
| target='_blank' | ||
| isExternal | ||
| css={{ color: '#a30cb3' }} |
dharit-tan
approved these changes
Jan 31, 2024
dharit-tan
left a comment
Contributor
There was a problem hiding this comment.
main thing is the decimal places comment, otherwise looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Second PR to add new lossless / stems and downloads UI. Commits show the breakdown of the work.
Merges into #7333
How Has This Been Tested?
local web dapp vs stage