[C-2928] Add auth request signing middleware to sdk by raymondjacobson · Pull Request #7724 · AudiusProject/apps

raymondjacobson · 2024-02-27T17:48:41Z

Description

Add auth middleware to sign requests. Now the client can stop calling audiusBackend to sign requests for sdk. Every request is signed by default and signatures are cached as to not slow down requests.
Add sdk login/signup via light hedgehog integration. This allows this new developer flow as previously history was an endpoint guarded by request auth headers:

const audiusSdk = sdk({
appName: 'Example',
userAuth: true
})
await audiusSdk.services.auth.signIn({
email: '<email@email.com>',
password: '<password>'
})
const history = await audiusSdk.full.users.getUsersTrackHistory({
id: userId,
limit: 1
})

This does not accomplish, but sets us up to be able to have AppAuth request a user's history

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Unit tests for middleware
New examples/ dir in sdk that runs through an example usage
npm run web:stage and test routes that were updated: history, payments views, downloads, etc.

audius-infra · 2024-02-29T05:46:14Z

Preview this change https://demo.audius.co/rj-c-2928

sliptype

Wow this is huge! Big unlock for libs -> sdk migration

audius-infra · 2024-03-01T00:19:59Z

Preview this change https://demo.audius.co/rj-c-2928

rickyrombo

Love it, looks great!

rickyrombo · 2024-03-01T00:06:17Z

+ otp?: string
+ }) => {
+ await this.hedgehog.waitUntilReady()
+ const wallet = await this.hedgehog.login({


maybe a "nice to have" here would be a special error type for OTP requests, but it's not important rn

audius-infra · 2024-03-01T07:25:07Z

Preview this change https://demo.audius.co/rj-c-2928

[73c35e5] Bump mobile app version for full-app release (#7770) Dylan Jeffers [fa9c7ce] [PAY-2490] Delete backfill txs tables (#7768) Reed [acf5840] Fix reset-password-modal icon + ui (#7769) Dylan Jeffers [cb9c022] [C-3929] Fix select-artist genres (#7765) Dylan Jeffers [709ff70] Fix reset password (#7767) Marcus Pasell [1c1474e] [C-3708] Fix wallet text clipping issue in withdrawals table (#7762) Kyle Shanks [7f4b187] Add an isNativeMobile prop to amplitude (#7766) JD Francis [4f6972f] [PAY-2527] Return `playlists_containing_track` from track apis (#7764) Andrew Mendelsohn [dbc6dc1] Fix download buttons erroneously displaying (#7763) Reed [8cf2464] [PAY-2531] Grant access to stream track if user has purchased album (#7753) Reed [762a9ac] [C-3926] Add error helper text to new sign in password field (#7761) Kyle Shanks [6d6117f] [C-3885] Migrate to harmony text-link (#7746) Dylan Jeffers [82dd8c5] Update dapp-store build artifacts audius-infra [1c554c6] [C-3924] Fix misc font/type issues on purchase flow (#7760) Raymond Jacobson [b695203] [C-3923] Remove double badges on purchase flow (#7759) Raymond Jacobson [e1dd6e0] [PAY-2488] Remove stripe option from purchase flow (#7755) Raymond Jacobson [4931acb] Bump version to 0.6.50 audius-infra [c8eaa02] [C-2928] Add auth request signing middleware to sdk (#7724) Raymond Jacobson [0d2d3b1] Add verifier checks to discovery relay (#7756) Raymond Jacobson [c3f0a99] useHarmonyField (#7514) Marcus Pasell [ce226e7] Publish harmony to npm (#7751) Sebastian Klingler [d5c0c98] [C-3897] Fix ai-attribution dropdown (#7754) Dylan Jeffers [26f9c7d] [PAY-2533] Index album purchases (#7735) Andrew Mendelsohn [375f5b5] [C-3888] Add header-shadow to sign-up-screen (#7750) Dylan Jeffers [dbbbc88] @audius/sdk: v3.0.35 audius-infra [5125501] [DRVL-16] - Documentation Site Updates (#7699) Sam Gutentag [2738765] Use turbo for sdk release (#7748) Sebastian Klingler [23072cd] [C-3918] Fix wallet and dev-apps icons (#7749) Dylan Jeffers [a4bbe1c] Update stem limit to 20 (#7745) Raymond Jacobson [f4863c6] Fix social sign ups redirecting unintentionally (#7744) JD Francis [557142b] Disable play button if all collection tracks deleted (#7743) Saliou Diallo [5f28d5d] Add others to skip otp (#7741) Raymond Jacobson [b33bc5b] Add download gated column (#7742) Saliou Diallo [9f0f84e] Bump version to 0.6.49 audius-infra [c2a9c46] Add ddex_app field for ddex tracks/playlists to discovery (#7734) Michelle Brier [c932495] [PROTO-1686] Setup DDEX choreography infra and related improvements (#7739) Theo Ilie [aec57f9] Misc sign up social fixes (#7737) JD Francis [682a384] [ONC-35] Fix crash on android due to react native importing images as numbers (#7738) Marcus Pasell [273be01] Misc Sign up fixes (spacing & page swipe animation) (#7736) JD Francis [cb39083] [ONC-34] Fix bug in mobile suggested collection tracks (#7731) Saliou Diallo [8db7400] [C-3866] Update placement of theme reset in mobile sign out to make colors display properly (#7728) Kyle Shanks [0d15ae7] [C-3898] Fix faded gray screen android on sign up (#7730) JD Francis [a0d314b] Bump version to 0.6.48 audius-infra [f43e956] [PROTO-1513] Add e2e ddex test (#7733) Theo Ilie [f5ad4c3] Fix harmony ssr (#7732) Dylan Jeffers [06af9d2] [C-3909] Fix upload track challenge copy (#7729) Saliou Diallo [8f73c19] [C-3899] Fix android able to go back on signup (#7727) JD Francis [d04b4bc] [PAY-2529] Index album stream_conditions (#7720) Reed [8966f88] [QA-779][QA-704] Fix some UI issues (#7725) Saliou Diallo [d29c83f] Misc Sign Up QA Fixes (#7722) JD Francis [90b098a] Discovery placement hosts (#7718) Steve Perkins [9674780] Bump version to 0.6.47 audius-infra [398db27] PROTO-1574: sepolia (#7698) alecsavvy [40583e6] Improve search analytics (#7696) Isaac Solo [3e1b544] Add env linter (#7697) Raymond Jacobson [5a3498c] [DVRL-11] Move client history requests to sdk (#7679) Raymond Jacobson [beb054b] Remove all usage of PROTOCOL_DIR env var (#7714) Danny [6230eca] [PAY-2528] is_stream_gated + stream_conditions on Playlist (#7717) Reed [4136985] [PAY-2524, PAY-2525, PAY-2526] Add collections_containing_track field to tracks (#7708) Andrew Mendelsohn [f25cc23] Fix the same typo in another spot (#7716) Theo Ilie [f51ccd8] [C-3858] Additional padding on select artists screen (#7715) JD Francis [9ff7262] [C-3858] Social sign on loading screen adjustments (#7710) JD Francis [4c3a35c] Fix typo breaking audius-compose push (#7713) Theo Ilie [74facea] Bump mobile versions for prod release (#7712) Dylan Jeffers [392bb21] Bump version to 0.6.46 audius-infra

[skip ci] ## Changelog - 2024-03-11 [f1d70a2] [INF-663] Fix external package versioning in monorepo (#7783) [Sebastian Klingler] - 2024-03-09 [51ec3ab] v1.5.71 [audius-infra] - 2024-03-02 [fb7f377] v1.5.70 [audius-infra] - 2024-03-02 [43d0fea] v1.5.69 [audius-infra] - 2024-03-01 [fa9c7ce] [PAY-2490] Delete backfill txs tables (#7768) [Reed] - 2024-02-29 [c8eaa02] [C-2928] Add auth request signing middleware to sdk (#7724) [Raymond Jacobson] - 2024-02-29 [26f9c7d] [PAY-2533] Index album purchases (#7735) [Andrew Mendelsohn] - 2024-02-29 [dbbbc88] @audius/sdk: v3.0.35 [audius-infra]

pull-request-sizeBot added the size/L label Feb 27, 2024

[C-2928] Add request signing middleware
004e0fa

raymondjacobson force-pushed the rj-c-2928 branch from b17fb73 to 004e0faCompare February 29, 2024 05:23

pull-request-sizeBot added size/XL and removed size/L labels Feb 29, 2024

raymondjacobson marked this pull request as ready for review February 29, 2024 05:28

Remove unnecessary
c463cf8

raymondjacobson requested review from nicoback2, rickyrombo, schottra and sliptype February 29, 2024 05:28

sliptype approved these changes Feb 29, 2024
View reviewed changes

rickyrombo reviewed Feb 29, 2024
View reviewed changes

raymondjacobson added 3 commits February 29, 2024 15:19

Quick feedback
aaebb9f

Use injection
f2151f7

Fix typo
a6bd7af

raymondjacobson requested a review from rickyrombo March 1, 2024 00:02

rickyrombo approved these changes Mar 1, 2024
View reviewed changes

Address comments, add custom error impl
ece3b9a

raymondjacobson enabled auto-merge (squash) March 1, 2024 07:16

raymondjacobson merged commit c8eaa02 into mainMar 1, 2024

raymondjacobson deleted the rj-c-2928 branch March 1, 2024 07:30

raymondjacobson mentioned this pull request Mar 3, 2024
[C-3921] Stop sending signature headers as params #7774
Merged

sliptype mentioned this pull request Mar 29, 2024
[C-4087] Fix library not loading #7983
Merged

Uh oh!

Conversation

raymondjacobson commented Feb 27, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Uh oh!

audius-infra commented Feb 29, 2024

Uh oh!

sliptype left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

audius-infra commented Mar 1, 2024

Uh oh!

rickyrombo left a comment

Choose a reason for hiding this comment

Uh oh!

rickyromboMar 1, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

audius-infra commented Mar 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

raymondjacobson commented Feb 27, 2024•
edited
Loading