Uh oh!
There was an error while loading. Please reload this page.
[ONC-40] Reload the page if the git sha doesn't match the latest - #7771
Merged
Conversation
raymondjacobson
approved these changes
Mar 2, 2024
Uh oh!
There was an error while loading. Please reload this page.
| function* reloadDaemon() { | ||
| yield* fork(visibilityPollingDaemon, checkGitSHA()) | ||
| yield* fork(foregroundPollingDaemon, checkGitSHA(), SHA_CHECK_MS) |
There was a problem hiding this comment.
i feel like it's enough to only check this when the app comes back into the foreground
ContributorAuthor
There was a problem hiding this comment.
Probably, but with a request this cheap why not do it anyway? 😃
audius-infra
commented
Mar 2, 2024
Collaborator
Preview this change https://demo.audius.co/mjp-reload-git-sha |
sddioulde
approved these changes
Mar 2, 2024
dylanjeffers
approved these changes
Mar 2, 2024
dylanjeffers
left a comment
Contributor
There was a problem hiding this comment.
this is dope! and it appears this only runs in web saga land right?
rickyrombo
enabled auto-merge (squash)
March 2, 2024 01:11
audius-infra
commented
Mar 2, 2024
Collaborator
Preview this change https://demo.audius.co/mjp-reload-git-sha |
audius-infra pushed a commit
that referenced
this pull request
Mar 2, 2024
[959eac4] [PAY-2530] Add repost buttons to purchase success (#7757) Raymond Jacobson [b21f725] [ONC-40] Reload the page if the git sha doesn't match the latest (#7771) Marcus Pasell [871638e] Format artist tracks and followers count (#7772) Dylan Jeffers [1ba8759] Disable play button if all collection tracks deleted on web (#7752) Saliou Diallo
This was referenced Mar 11, 2024
rickyrombo added a commit
that referenced
this pull request
Mar 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ONC-40
Previous iteration used the env var, but on the rare chance that doesn't change, decided for local var instead.